Re: [U-Boot] [PATCH 2/3] fw_env: fix incorrect usage of open(O_CREAT)

[Joe Hershberger]

Hi Mike,

On Sat, Nov 10, 2012 at 11:47 PM, Mike Frysinger vap...@gentoo.org wrote:
 When using open(), the O_CREAT flag must be given a mode, otherwise it
 uses random garbage from the stack.  Also, it can fail to build:

 In file included from /usr/include/fcntl.h:290:0,
  from fw_env_main.c:42:
 In function 'open',
 inlined from 'main' at fw_env_main.c:97:9:
 /usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode' 
 declared
 with attribute error: open with O_CREAT in second argument needs 3 
 arguments

 Signed-off-by: Mike Frysinger vap...@gentoo.org

Acked-by: Joe Hershberger joe.hershber...@ni.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] fw_env: fix incorrect usage of open(O_CREAT)

[Christian Riesch]

Hi,

On Sun, Nov 11, 2012 at 6:47 AM, Mike Frysinger vap...@gentoo.org wrote:
 When using open(), the O_CREAT flag must be given a mode, otherwise it
 uses random garbage from the stack.  Also, it can fail to build:

 In file included from /usr/include/fcntl.h:290:0,
  from fw_env_main.c:42:
 In function 'open',
 inlined from 'main' at fw_env_main.c:97:9:
 /usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode' 
 declared
 with attribute error: open with O_CREAT in second argument needs 3 
 arguments

Could someone please pick up this patchset?

http://patchwork.ozlabs.org/patch/198241/
http://patchwork.ozlabs.org/patch/198243/
http://patchwork.ozlabs.org/patch/198242/

make env is currently broken for me.
Thank you!
Regards, Christian


 Signed-off-by: Mike Frysinger vap...@gentoo.org
 ---
  tools/env/fw_env_main.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/tools/env/fw_env_main.c b/tools/env/fw_env_main.c
 index c855f4c..40ea3f6 100644
 --- a/tools/env/fw_env_main.c
 +++ b/tools/env/fw_env_main.c
 @@ -94,7 +94,7 @@ int main(int argc, char *argv[])
 int lockfd = -1;
 int retval = EXIT_SUCCESS;

 -   lockfd = open(lockname, O_WRONLY | O_CREAT | O_TRUNC);
 +   lockfd = open(lockname, O_WRONLY | O_CREAT | O_TRUNC, 0666);
 if (-1 == lockfd) {
 fprintf(stderr, Error opening lock file %s\n, lockname);
 return EXIT_FAILURE;
 --
 1.7.12.4

 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 2/3] fw_env: fix incorrect usage of open(O_CREAT)

[Mike Frysinger]

When using open(), the O_CREAT flag must be given a mode, otherwise it
uses random garbage from the stack.  Also, it can fail to build:

In file included from /usr/include/fcntl.h:290:0,
 from fw_env_main.c:42:
In function 'open',
inlined from 'main' at fw_env_main.c:97:9:
/usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode' declared
with attribute error: open with O_CREAT in second argument needs 3 
arguments

Signed-off-by: Mike Frysinger vap...@gentoo.org
---
 tools/env/fw_env_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/env/fw_env_main.c b/tools/env/fw_env_main.c
index c855f4c..40ea3f6 100644
--- a/tools/env/fw_env_main.c
+++ b/tools/env/fw_env_main.c
@@ -94,7 +94,7 @@ int main(int argc, char *argv[])
int lockfd = -1;
int retval = EXIT_SUCCESS;
 
-   lockfd = open(lockname, O_WRONLY | O_CREAT | O_TRUNC);
+   lockfd = open(lockname, O_WRONLY | O_CREAT | O_TRUNC, 0666);
if (-1 == lockfd) {
fprintf(stderr, Error opening lock file %s\n, lockname);
return EXIT_FAILURE;
-- 
1.7.12.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot