Re: [U-Boot] [PATCH 2/4] usb:composite: USB Mass Storage - f_mass_storage.c from Linux kernel

2013-01-25 Thread Piotr Wilczek
Dear Marek Vasut,

 -Original Message-
 From: Marek Vasut [mailto:ma...@denx.de]
 Sent: Thursday, January 24, 2013 1:34 PM
 To: Piotr Wilczek
 Cc: u-boot@lists.denx.de; Minkyu Kang; Kyungmin Park; Lukasz Majewski;
 Tom Rini
 Subject: Re: [PATCH 2/4] usb:composite: USB Mass Storage -
 f_mass_storage.c from Linux kernel
 
 Dear Piotr Wilczek,
 
  The f_mass_storage.c source file from v2.6.36 Linux kernel.
 
  commit 8876f5e7d3b2a320777dd4f6f5301d474c97a06c
  Author: Michal Nazarewicz m.nazarew...@samsung.com
  Date:   Mon Jun 21 13:57:09 2010 +0200
 
  USB: gadget: f_mass_storage: added eject callback
 
  Signed-off-by: Lukasz Majewski l.majew...@samsung.com
  Signed-off-by: Piotr Wilczek p.wilc...@samsung.com
  Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
 
 Why is there so much code that's crudely commented out, like in the
 synchronize_cache function?
 
I remove it in v2

 Best regards,
 Marek Vasut

Best regards,
Piotr Wilczek

---
Samsung RD Poland (SRPOL) | Linux Platform Group


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 2/4] usb:composite: USB Mass Storage - f_mass_storage.c from Linux kernel

2013-01-24 Thread Marek Vasut
Dear Piotr Wilczek,

 The f_mass_storage.c source file from v2.6.36 Linux kernel.
 
 commit 8876f5e7d3b2a320777dd4f6f5301d474c97a06c
 Author: Michal Nazarewicz m.nazarew...@samsung.com
 Date:   Mon Jun 21 13:57:09 2010 +0200
 
 USB: gadget: f_mass_storage: added eject callback
 
 Signed-off-by: Lukasz Majewski l.majew...@samsung.com
 Signed-off-by: Piotr Wilczek p.wilc...@samsung.com
 Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

Why is there so much code that's crudely commented out, like in the 
synchronize_cache function?

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot