Re: [U-Boot] [PATCH 2/6] arm: am57xx: Enable Fastboot

2016-03-08 Thread Tom Rini
On Tue, Mar 08, 2016 at 06:42:24PM +0700, Semen Protsenko wrote:

> From: Sam Protsenko 
> 
> Enable fastboot by default for AM57XX EVM.
> 
> This is based on following patch modified accordingly:
> http://git.omapzoom.org/?p=repo/u-boot.git;a=commit;h=b2e04f92b5d91c708b6fd6b79d2266966ac51f4b
> 
> Signed-off-by: Sam Protsenko 

Since you're spending some time in here, can you please start converting
some of the fastboot options over to Kconfig?  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 2/6] arm: am57xx: Enable Fastboot

2016-03-08 Thread Lokesh Vutla


On Tuesday 08 March 2016 05:12 PM, Semen Protsenko wrote:
> From: Sam Protsenko 
> 
> Enable fastboot by default for AM57XX EVM.
> 
> This is based on following patch modified accordingly:
> http://git.omapzoom.org/?p=repo/u-boot.git;a=commit;h=b2e04f92b5d91c708b6fd6b79d2266966ac51f4b

Also mention that you are guarding for non SPL

Other than that:
Reviewed-by: Lokesh Vutla 

Thanks and regards,
Lokesh

> 
> Signed-off-by: Sam Protsenko 
> ---
>  include/configs/am57xx_evm.h | 11 +++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/include/configs/am57xx_evm.h b/include/configs/am57xx_evm.h
> index 9191d61..9a740d4 100644
> --- a/include/configs/am57xx_evm.h
> +++ b/include/configs/am57xx_evm.h
> @@ -36,11 +36,22 @@
>  
>  #define CONFIG_SYS_OMAP_ABE_SYSCK
>  
> +#ifndef CONFIG_SPL_BUILD
>  /* Define the default GPT table for eMMC */
>  #define PARTS_DEFAULT \
>   "uuid_disk=${uuid_gpt_disk};" \
>   "name=rootfs,start=2MiB,size=-,uuid=${uuid_gpt_rootfs}"
>  
> +/* Fastboot */
> +#define CONFIG_USB_FUNCTION_FASTBOOT
> +#define CONFIG_CMD_FASTBOOT
> +#define CONFIG_ANDROID_BOOT_IMAGE
> +#define CONFIG_FASTBOOT_BUF_ADDR CONFIG_SYS_LOAD_ADDR
> +#define CONFIG_FASTBOOT_BUF_SIZE 0x2F00
> +#define CONFIG_FASTBOOT_FLASH
> +#define CONFIG_FASTBOOT_FLASH_MMC_DEV1
> +#endif
> +
>  #include 
>  
>  /* Enhance our eMMC support / experience. */
> 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 2/6] arm: am57xx: Enable Fastboot

2016-03-08 Thread Semen Protsenko
From: Sam Protsenko 

Enable fastboot by default for AM57XX EVM.

This is based on following patch modified accordingly:
http://git.omapzoom.org/?p=repo/u-boot.git;a=commit;h=b2e04f92b5d91c708b6fd6b79d2266966ac51f4b

Signed-off-by: Sam Protsenko 
---
 include/configs/am57xx_evm.h | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/include/configs/am57xx_evm.h b/include/configs/am57xx_evm.h
index 9191d61..9a740d4 100644
--- a/include/configs/am57xx_evm.h
+++ b/include/configs/am57xx_evm.h
@@ -36,11 +36,22 @@
 
 #define CONFIG_SYS_OMAP_ABE_SYSCK
 
+#ifndef CONFIG_SPL_BUILD
 /* Define the default GPT table for eMMC */
 #define PARTS_DEFAULT \
"uuid_disk=${uuid_gpt_disk};" \
"name=rootfs,start=2MiB,size=-,uuid=${uuid_gpt_rootfs}"
 
+/* Fastboot */
+#define CONFIG_USB_FUNCTION_FASTBOOT
+#define CONFIG_CMD_FASTBOOT
+#define CONFIG_ANDROID_BOOT_IMAGE
+#define CONFIG_FASTBOOT_BUF_ADDR   CONFIG_SYS_LOAD_ADDR
+#define CONFIG_FASTBOOT_BUF_SIZE   0x2F00
+#define CONFIG_FASTBOOT_FLASH
+#define CONFIG_FASTBOOT_FLASH_MMC_DEV  1
+#endif
+
 #include 
 
 /* Enhance our eMMC support / experience. */
-- 
2.7.0

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot