Re: [U-Boot] [PATCH 2/7] scsi: add children devices binding

[Simon Glass]

On 23 March 2017 at 03:29,   wrote:
> From: Ken Ma 
>
> - When scsi controller acts as a bus, we need to bind its children
>   scsi devices(scsi hdd, cd, dvd, scanner) to their drivers as spi
>   controller binds spi flashes, so scsi-uclass's post bind function
>   calls dm_scan_fdt_dev() to bind scsi subnode devices;
> - When scsi controller is a Serial Attached SCSI, it can also work as
>   a pure controller as an on-board component on the motherboard, it may
>   has no subnodes in fdt, then dm_scan_fdt_dev() does nothing and has
>   no effect.
>
> Signed-off-by: Ken Ma 
> Cc: Simon Glass 
> Cc: Stefan Roese 
> Cc: Michal Simek 
> Reviewed-on: http://vgitil04.il.marvell.com:8080/35425
> Tested-by: iSoC Platform CI 
> Reviewed-by: Omri Itach 
> Reviewed-by: Kostya Porotchkin 
> ---
>  drivers/block/scsi-uclass.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 2/7] scsi: add children devices binding

[make]

From: Ken Ma 

- When scsi controller acts as a bus, we need to bind its children
  scsi devices(scsi hdd, cd, dvd, scanner) to their drivers as spi
  controller binds spi flashes, so scsi-uclass's post bind function
  calls dm_scan_fdt_dev() to bind scsi subnode devices;
- When scsi controller is a Serial Attached SCSI, it can also work as
  a pure controller as an on-board component on the motherboard, it may
  has no subnodes in fdt, then dm_scan_fdt_dev() does nothing and has
  no effect.

Signed-off-by: Ken Ma 
Cc: Simon Glass 
Cc: Stefan Roese 
Cc: Michal Simek 
Reviewed-on: http://vgitil04.il.marvell.com:8080/35425
Tested-by: iSoC Platform CI 
Reviewed-by: Omri Itach 
Reviewed-by: Kostya Porotchkin 
---
 drivers/block/scsi-uclass.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/block/scsi-uclass.c b/drivers/block/scsi-uclass.c
index 3bf026b..86eddfc 100644
--- a/drivers/block/scsi-uclass.c
+++ b/drivers/block/scsi-uclass.c
@@ -45,6 +45,9 @@ static int scsi_post_bind(struct udevice *dev)
 {
/* Get uclass plat data from fdt */
scsi_ofdata_to_uclass_platdata(dev);
+
+   /* bind subnode devices */
+   return dm_scan_fdt_dev(dev);
 }
 
 UCLASS_DRIVER(scsi) = {
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot