Re: [U-Boot] [PATCH 26/26] configs: mtmips: add necessary drivers for mtmips boards
On Wed, 2019-08-28 at 15:40 +0200, Stefan Roese wrote: > On 28.08.19 15:35, Daniel Schwierzeck wrote: > > > > > > Am 28.08.19 um 08:38 schrieb Weijie Gao: > >> This patch adds pinctrl driver, clock gate driver and reset controller > >> support for defconfig files of mtmips boards. > >> > >> Signed-off-by: Weijie Gao > >> --- > >> configs/gardena-smart-gateway-mt7688_defconfig | 6 ++ > >> configs/linkit-smart-7688_defconfig| 6 ++ > >> 2 files changed, 12 insertions(+) > >> > >> diff --git a/configs/gardena-smart-gateway-mt7688_defconfig > >> b/configs/gardena-smart-gateway-mt7688_defconfig > >> index 1e270cb61d..83e793042a 100644 > >> --- a/configs/gardena-smart-gateway-mt7688_defconfig > >> +++ b/configs/gardena-smart-gateway-mt7688_defconfig > >> @@ -49,6 +49,7 @@ CONFIG_NET_RANDOM_ETHADDR=y > >> CONFIG_HAVE_BLOCK_DEVICE=y > >> CONFIG_BOOTCOUNT_LIMIT=y > >> CONFIG_CLK=y > >> +CONFIG_CLK_MTMIPS_GATE=y > >> CONFIG_LED=y > >> CONFIG_LED_BLINK=y > >> CONFIG_LED_GPIO=y > >> @@ -67,10 +68,15 @@ CONFIG_PHYLIB=y > >> CONFIG_PHY_FIXED=y > >> CONFIG_MT7628_ETH=y > >> CONFIG_PHY=y > >> +CONFIG_PINCTRL=y > >> +CONFIG_PINMUX=y > >> +CONFIG_PINCONF=y > >> +CONFIG_PINCTRL_MT7628=y > >> CONFIG_POWER_DOMAIN=y > >> CONFIG_RAM=y > >> CONFIG_DM_RESET=y > >> # CONFIG_SPL_SERIAL_PRESENT is not set > >> +CONFIG_RESET_MTMIPS=y > > > > if the SoC only works with those drivers enabled, you should consider to > > select all according Kconfig symbols in arch/mips/mach-mtmips/Kconfig so > > an user can't configure a non-working board config by mistake. > > I agree. Please move those selections to Kconfig (select XXX). > > And please re-think about using the generic drivers for pinctrl and clock > (as also remarked by Daniel). > > Thanks, > Stefan > > > > >> CONFIG_MTK_SERIAL=y > >> CONFIG_SPI=y > >> CONFIG_MT7621_SPI=y > >> diff --git a/configs/linkit-smart-7688_defconfig > >> b/configs/linkit-smart-7688_defconfig > >> index 743cc48166..13f5cf8a21 100644 > >> --- a/configs/linkit-smart-7688_defconfig > >> +++ b/configs/linkit-smart-7688_defconfig > >> @@ -40,6 +40,7 @@ CONFIG_NET_RANDOM_ETHADDR=y > >> # CONFIG_DM_DEVICE_REMOVE is not set > >> CONFIG_BLK=y > >> CONFIG_CLK=y > >> +CONFIG_CLK_MTMIPS_GATE=y > >> CONFIG_LED=y > >> CONFIG_LED_BLINK=y > >> CONFIG_LED_GPIO=y > >> @@ -55,10 +56,15 @@ CONFIG_PHY_FIXED=y > >> CONFIG_MT7628_ETH=y > >> CONFIG_PHY=y > >> CONFIG_MT76X8_USB_PHY=y > >> +CONFIG_PINCTRL=y > >> +CONFIG_PINMUX=y > >> +CONFIG_PINCONF=y > >> +CONFIG_PINCTRL_MT7628=y > >> CONFIG_POWER_DOMAIN=y > >> CONFIG_RAM=y > >> CONFIG_DM_RESET=y > >> # CONFIG_SPL_SERIAL_PRESENT is not set > >> +CONFIG_RESET_MTMIPS=y > >> CONFIG_MTK_SERIAL=y > >> CONFIG_SPI=y > >> CONFIG_MT7621_SPI=y > >> > > > > Viele Grüße, > Stefan > I'll move them to mach-mtmips/Kconfig. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 26/26] configs: mtmips: add necessary drivers for mtmips boards
On 28.08.19 15:35, Daniel Schwierzeck wrote: Am 28.08.19 um 08:38 schrieb Weijie Gao: This patch adds pinctrl driver, clock gate driver and reset controller support for defconfig files of mtmips boards. Signed-off-by: Weijie Gao --- configs/gardena-smart-gateway-mt7688_defconfig | 6 ++ configs/linkit-smart-7688_defconfig| 6 ++ 2 files changed, 12 insertions(+) diff --git a/configs/gardena-smart-gateway-mt7688_defconfig b/configs/gardena-smart-gateway-mt7688_defconfig index 1e270cb61d..83e793042a 100644 --- a/configs/gardena-smart-gateway-mt7688_defconfig +++ b/configs/gardena-smart-gateway-mt7688_defconfig @@ -49,6 +49,7 @@ CONFIG_NET_RANDOM_ETHADDR=y CONFIG_HAVE_BLOCK_DEVICE=y CONFIG_BOOTCOUNT_LIMIT=y CONFIG_CLK=y +CONFIG_CLK_MTMIPS_GATE=y CONFIG_LED=y CONFIG_LED_BLINK=y CONFIG_LED_GPIO=y @@ -67,10 +68,15 @@ CONFIG_PHYLIB=y CONFIG_PHY_FIXED=y CONFIG_MT7628_ETH=y CONFIG_PHY=y +CONFIG_PINCTRL=y +CONFIG_PINMUX=y +CONFIG_PINCONF=y +CONFIG_PINCTRL_MT7628=y CONFIG_POWER_DOMAIN=y CONFIG_RAM=y CONFIG_DM_RESET=y # CONFIG_SPL_SERIAL_PRESENT is not set +CONFIG_RESET_MTMIPS=y if the SoC only works with those drivers enabled, you should consider to select all according Kconfig symbols in arch/mips/mach-mtmips/Kconfig so an user can't configure a non-working board config by mistake. I agree. Please move those selections to Kconfig (select XXX). And please re-think about using the generic drivers for pinctrl and clock (as also remarked by Daniel). Thanks, Stefan CONFIG_MTK_SERIAL=y CONFIG_SPI=y CONFIG_MT7621_SPI=y diff --git a/configs/linkit-smart-7688_defconfig b/configs/linkit-smart-7688_defconfig index 743cc48166..13f5cf8a21 100644 --- a/configs/linkit-smart-7688_defconfig +++ b/configs/linkit-smart-7688_defconfig @@ -40,6 +40,7 @@ CONFIG_NET_RANDOM_ETHADDR=y # CONFIG_DM_DEVICE_REMOVE is not set CONFIG_BLK=y CONFIG_CLK=y +CONFIG_CLK_MTMIPS_GATE=y CONFIG_LED=y CONFIG_LED_BLINK=y CONFIG_LED_GPIO=y @@ -55,10 +56,15 @@ CONFIG_PHY_FIXED=y CONFIG_MT7628_ETH=y CONFIG_PHY=y CONFIG_MT76X8_USB_PHY=y +CONFIG_PINCTRL=y +CONFIG_PINMUX=y +CONFIG_PINCONF=y +CONFIG_PINCTRL_MT7628=y CONFIG_POWER_DOMAIN=y CONFIG_RAM=y CONFIG_DM_RESET=y # CONFIG_SPL_SERIAL_PRESENT is not set +CONFIG_RESET_MTMIPS=y CONFIG_MTK_SERIAL=y CONFIG_SPI=y CONFIG_MT7621_SPI=y Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: s...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH 26/26] configs: mtmips: add necessary drivers for mtmips boards
Am 28.08.19 um 08:38 schrieb Weijie Gao: > This patch adds pinctrl driver, clock gate driver and reset controller > support for defconfig files of mtmips boards. > > Signed-off-by: Weijie Gao > --- > configs/gardena-smart-gateway-mt7688_defconfig | 6 ++ > configs/linkit-smart-7688_defconfig| 6 ++ > 2 files changed, 12 insertions(+) > > diff --git a/configs/gardena-smart-gateway-mt7688_defconfig > b/configs/gardena-smart-gateway-mt7688_defconfig > index 1e270cb61d..83e793042a 100644 > --- a/configs/gardena-smart-gateway-mt7688_defconfig > +++ b/configs/gardena-smart-gateway-mt7688_defconfig > @@ -49,6 +49,7 @@ CONFIG_NET_RANDOM_ETHADDR=y > CONFIG_HAVE_BLOCK_DEVICE=y > CONFIG_BOOTCOUNT_LIMIT=y > CONFIG_CLK=y > +CONFIG_CLK_MTMIPS_GATE=y > CONFIG_LED=y > CONFIG_LED_BLINK=y > CONFIG_LED_GPIO=y > @@ -67,10 +68,15 @@ CONFIG_PHYLIB=y > CONFIG_PHY_FIXED=y > CONFIG_MT7628_ETH=y > CONFIG_PHY=y > +CONFIG_PINCTRL=y > +CONFIG_PINMUX=y > +CONFIG_PINCONF=y > +CONFIG_PINCTRL_MT7628=y > CONFIG_POWER_DOMAIN=y > CONFIG_RAM=y > CONFIG_DM_RESET=y > # CONFIG_SPL_SERIAL_PRESENT is not set > +CONFIG_RESET_MTMIPS=y if the SoC only works with those drivers enabled, you should consider to select all according Kconfig symbols in arch/mips/mach-mtmips/Kconfig so an user can't configure a non-working board config by mistake. > CONFIG_MTK_SERIAL=y > CONFIG_SPI=y > CONFIG_MT7621_SPI=y > diff --git a/configs/linkit-smart-7688_defconfig > b/configs/linkit-smart-7688_defconfig > index 743cc48166..13f5cf8a21 100644 > --- a/configs/linkit-smart-7688_defconfig > +++ b/configs/linkit-smart-7688_defconfig > @@ -40,6 +40,7 @@ CONFIG_NET_RANDOM_ETHADDR=y > # CONFIG_DM_DEVICE_REMOVE is not set > CONFIG_BLK=y > CONFIG_CLK=y > +CONFIG_CLK_MTMIPS_GATE=y > CONFIG_LED=y > CONFIG_LED_BLINK=y > CONFIG_LED_GPIO=y > @@ -55,10 +56,15 @@ CONFIG_PHY_FIXED=y > CONFIG_MT7628_ETH=y > CONFIG_PHY=y > CONFIG_MT76X8_USB_PHY=y > +CONFIG_PINCTRL=y > +CONFIG_PINMUX=y > +CONFIG_PINCONF=y > +CONFIG_PINCTRL_MT7628=y > CONFIG_POWER_DOMAIN=y > CONFIG_RAM=y > CONFIG_DM_RESET=y > # CONFIG_SPL_SERIAL_PRESENT is not set > +CONFIG_RESET_MTMIPS=y > CONFIG_MTK_SERIAL=y > CONFIG_SPI=y > CONFIG_MT7621_SPI=y > -- - Daniel ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH 26/26] configs: mtmips: add necessary drivers for mtmips boards
This patch adds pinctrl driver, clock gate driver and reset controller support for defconfig files of mtmips boards. Signed-off-by: Weijie Gao --- configs/gardena-smart-gateway-mt7688_defconfig | 6 ++ configs/linkit-smart-7688_defconfig| 6 ++ 2 files changed, 12 insertions(+) diff --git a/configs/gardena-smart-gateway-mt7688_defconfig b/configs/gardena-smart-gateway-mt7688_defconfig index 1e270cb61d..83e793042a 100644 --- a/configs/gardena-smart-gateway-mt7688_defconfig +++ b/configs/gardena-smart-gateway-mt7688_defconfig @@ -49,6 +49,7 @@ CONFIG_NET_RANDOM_ETHADDR=y CONFIG_HAVE_BLOCK_DEVICE=y CONFIG_BOOTCOUNT_LIMIT=y CONFIG_CLK=y +CONFIG_CLK_MTMIPS_GATE=y CONFIG_LED=y CONFIG_LED_BLINK=y CONFIG_LED_GPIO=y @@ -67,10 +68,15 @@ CONFIG_PHYLIB=y CONFIG_PHY_FIXED=y CONFIG_MT7628_ETH=y CONFIG_PHY=y +CONFIG_PINCTRL=y +CONFIG_PINMUX=y +CONFIG_PINCONF=y +CONFIG_PINCTRL_MT7628=y CONFIG_POWER_DOMAIN=y CONFIG_RAM=y CONFIG_DM_RESET=y # CONFIG_SPL_SERIAL_PRESENT is not set +CONFIG_RESET_MTMIPS=y CONFIG_MTK_SERIAL=y CONFIG_SPI=y CONFIG_MT7621_SPI=y diff --git a/configs/linkit-smart-7688_defconfig b/configs/linkit-smart-7688_defconfig index 743cc48166..13f5cf8a21 100644 --- a/configs/linkit-smart-7688_defconfig +++ b/configs/linkit-smart-7688_defconfig @@ -40,6 +40,7 @@ CONFIG_NET_RANDOM_ETHADDR=y # CONFIG_DM_DEVICE_REMOVE is not set CONFIG_BLK=y CONFIG_CLK=y +CONFIG_CLK_MTMIPS_GATE=y CONFIG_LED=y CONFIG_LED_BLINK=y CONFIG_LED_GPIO=y @@ -55,10 +56,15 @@ CONFIG_PHY_FIXED=y CONFIG_MT7628_ETH=y CONFIG_PHY=y CONFIG_MT76X8_USB_PHY=y +CONFIG_PINCTRL=y +CONFIG_PINMUX=y +CONFIG_PINCONF=y +CONFIG_PINCTRL_MT7628=y CONFIG_POWER_DOMAIN=y CONFIG_RAM=y CONFIG_DM_RESET=y # CONFIG_SPL_SERIAL_PRESENT is not set +CONFIG_RESET_MTMIPS=y CONFIG_MTK_SERIAL=y CONFIG_SPI=y CONFIG_MT7621_SPI=y -- 2.17.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
