Re: [U-Boot] [PATCH 3/3] TI: TNETV107X EVM initial support

2010-03-31 Thread Chemparathy, Cyril
Wolfgang,

[...]
   Is davinci correct here?
 
  Yes, this SOC has the exact same controller as on Davinci, and therefore
  the NAND driver is reused.
 
 But you don't call this a Davinci-Board, or do you?

Davinci NAND is a bit of a misnomer since this particular EMIF block is
commonly used across multiple TI devices.  Unfortunately, this misnomer
(amongst others) carries forward into the kernel too.  Consequently, if we
use a different device name here, the mtdparts variable won't be usable as
a kernel command-line argument.

Regards
Cyril.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 3/3] TI: TNETV107X EVM initial support

2010-03-30 Thread Wolfgang Denk
Dear Cyril Chemparathy,

In message 1269893792-15248-4-git-send-email-cy...@ti.com you wrote:
 TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a
 bunch on on-chip integrated peripherals.  This patch adds support for the
 TNETV107X EVM board.
 
 Signed-off-by: Cyril Chemparathy cy...@ti.com
 ---
  MAKEALL   |1 +
  Makefile  |3 +
  board/ti/tnetv107xevm/Makefile|   49 
  board/ti/tnetv107xevm/config.mk   |   20 
  board/ti/tnetv107xevm/sdb_board.c |   66 +++
  board/ti/tnetv107xevm/u-boot.lds  |   48 
  include/configs/tnetv107x_evm.h   |  225 
 +
  7 files changed, 412 insertions(+), 0 deletions(-)
  create mode 100644 board/ti/tnetv107xevm/Makefile
  create mode 100644 board/ti/tnetv107xevm/config.mk
  create mode 100644 board/ti/tnetv107xevm/sdb_board.c
  create mode 100644 board/ti/tnetv107xevm/u-boot.lds
  create mode 100644 include/configs/tnetv107x_evm.h

Entry to MAINTAINERS missing.

 diff --git a/Makefile b/Makefile
 index c0e73de..e723e7c 100644
 --- a/Makefile
 +++ b/Makefile
 @@ -2936,6 +2936,9 @@ davinci_dm365evm_config :   unconfig
  davinci_dm6467evm_config :   unconfig
   @$(MKCONFIG) $(@:_config=) arm arm926ejs dm6467evm davinci davinci
  
 +tnetv107x_evm_config: unconfig
 + @$(MKCONFIG) $(@:_config=) arm arm1176 tnetv107xevm ti tnetv107x
 +
  imx27lite_config:unconfig
   @$(MKCONFIG) $(@:_config=) arm arm926ejs imx27lite logicpd mx27

Please keep lists sorted - board names, and architectures. arm1176 has
no place among arm926ejs systems.

 diff --git a/board/ti/tnetv107xevm/u-boot.lds 
 b/board/ti/tnetv107xevm/u-boot.lds
 new file mode 100644
 index 000..3afa17f
 --- /dev/null
 +++ b/board/ti/tnetv107xevm/u-boot.lds

Do you really need board specific linker scripts? Or would one common
linker script for all (or at least for most of the) boards be
sufficient?

 diff --git a/include/configs/tnetv107x_evm.h b/include/configs/tnetv107x_evm.h
 new file mode 100644
 index 000..795e3f1
 --- /dev/null
 +++ b/include/configs/tnetv107x_evm.h
...
 +//
 +/* Architecture, CPU, etc.  */
 +//

Incorrect multiline comment styile. Please fix globally.

 +#define MTDIDS_DEFAULT   nand0=davinci_nand.0
 +#define MTDPARTS_DEFAULT mtdparts=davinci_nand.0:  \
 + 1536k(uboot)ro,   \
 + 128k(params)ro,   \
 + 4m(kernel),   \
 + -(filesystem)

Is davinci correct here?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
I have a theory that it's impossible to prove anything, but  I  can't
prove it.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 3/3] TI: TNETV107X EVM initial support

2010-03-30 Thread Chemparathy, Cyril
Hi Wolfgang,

Thanks.  Will send out a v2 with these changed.

[...]
  +#define MTDPARTS_DEFAULT   mtdparts=davinci_nand.0:  \
  +   1536k(uboot)ro,   \
  +   128k(params)ro,   \
  +   4m(kernel),   \
  +   -(filesystem)
 
 Is davinci correct here?

Yes, this SOC has the exact same controller as on Davinci, and therefore
the NAND driver is reused.

Regards
Cyril.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 3/3] TI: TNETV107X EVM initial support

2010-03-30 Thread Wolfgang Denk
Dear Chemparathy, Cyril,

In message 8ffaa0bfc4e5374b8f85f65fe1f2bfa58babc...@dlee02.ent.ti.com you 
wrote:
 
 [...]
   +#define MTDPARTS_DEFAULT mtdparts=davinci_nand.0:  \
   + 1536k(uboot)ro,   \
   + 128k(params)ro,   \
   + 4m(kernel),   \
   + -(filesystem)
  
  Is davinci correct here?

 Yes, this SOC has the exact same controller as on Davinci, and therefore
 the NAND driver is reused.

But you don't call this a Davinci-Board, or do you?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
There are three ways to get something done:
(1) Do it yourself.
(2) Hire someone to do it for you.
(3) Forbid your kids to do it.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 3/3] TI: TNETV107X EVM initial support

2010-03-29 Thread Cyril Chemparathy
TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a
bunch on on-chip integrated peripherals.  This patch adds support for the
TNETV107X EVM board.

Signed-off-by: Cyril Chemparathy cy...@ti.com
---
 MAKEALL   |1 +
 Makefile  |3 +
 board/ti/tnetv107xevm/Makefile|   49 
 board/ti/tnetv107xevm/config.mk   |   20 
 board/ti/tnetv107xevm/sdb_board.c |   66 +++
 board/ti/tnetv107xevm/u-boot.lds  |   48 
 include/configs/tnetv107x_evm.h   |  225 +
 7 files changed, 412 insertions(+), 0 deletions(-)
 create mode 100644 board/ti/tnetv107xevm/Makefile
 create mode 100644 board/ti/tnetv107xevm/config.mk
 create mode 100644 board/ti/tnetv107xevm/sdb_board.c
 create mode 100644 board/ti/tnetv107xevm/u-boot.lds
 create mode 100644 include/configs/tnetv107x_evm.h

diff --git a/MAKEALL b/MAKEALL
index a88c31e..63d8d16 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -623,6 +623,7 @@ LIST_ARM11=\
mx31pdk_nand\
qong\
smdk6400\
+   tnetv107x_evm   \
 
 
 #
diff --git a/Makefile b/Makefile
index c0e73de..e723e7c 100644
--- a/Makefile
+++ b/Makefile
@@ -2936,6 +2936,9 @@ davinci_dm365evm_config : unconfig
 davinci_dm6467evm_config : unconfig
@$(MKCONFIG) $(@:_config=) arm arm926ejs dm6467evm davinci davinci
 
+tnetv107x_evm_config: unconfig
+   @$(MKCONFIG) $(@:_config=) arm arm1176 tnetv107xevm ti tnetv107x
+
 imx27lite_config:  unconfig
@$(MKCONFIG) $(@:_config=) arm arm926ejs imx27lite logicpd mx27
 
diff --git a/board/ti/tnetv107xevm/Makefile b/board/ti/tnetv107xevm/Makefile
new file mode 100644
index 000..2446c2a
--- /dev/null
+++ b/board/ti/tnetv107xevm/Makefile
@@ -0,0 +1,49 @@
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+#
+
+include $(TOPDIR)/config.mk
+
+LIB= $(obj)lib$(BOARD).a
+
+COBJS  += sdb_board.o
+
+SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS   := $(addprefix $(obj),$(COBJS))
+SOBJS  := $(addprefix $(obj),$(SOBJS))
+
+.PHONY: all
+
+all: $(LIB)
+
+$(LIB):$(obj).depend $(OBJS) $(SOBJS)
+   $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
+
+clean:
+   rm -f $(SOBJS) $(OBJS)
+
+distclean: clean
+   rm -f $(LIB) core *.bak *~ .depend
+
+#
+# This is for $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#
diff --git a/board/ti/tnetv107xevm/config.mk b/board/ti/tnetv107xevm/config.mk
new file mode 100644
index 000..d24d49a
--- /dev/null
+++ b/board/ti/tnetv107xevm/config.mk
@@ -0,0 +1,20 @@
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+#
+
+TEXT_BASE = 0x83FC
diff --git a/board/ti/tnetv107xevm/sdb_board.c 
b/board/ti/tnetv107xevm/sdb_board.c
new file mode 100644
index 000..fa7b49c
--- /dev/null
+++ b/board/ti/tnetv107xevm/sdb_board.c
@@ -0,0 +1,66 @@
+/*
+ * TNETV107X-EVM: Board initialization
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.