Re: [U-Boot] [PATCH 3/3] drivers: net: pfe_eth: Disable autonegotiation for 2.5G SGMII

2018-01-09 Thread York Sun 
On 01/09/2018 08:15 AM, Bhaskar Upadhaya wrote:
> 
> 
>> -Original Message-
>> From: York Sun
>> Sent: Tuesday, January 09, 2018 12:13 AM
>> To: Bhaskar Upadhaya ; u-boot@lists.denx.de
>> Subject: Re: [PATCH 3/3] drivers: net: pfe_eth: Disable autonegotiation for 
>> 2.5G
>> SGMII
>>
>> On 11/29/2017 09:13 PM, Bhaskar Upadhaya wrote:
>>> PCS initialization sequence for 2.5G SGMII interface governs auto
>>> negotiation to be in disabled mode
>>>
>>> Signed-off-by: Bhaskar Upadhaya 
>>> ---
>>> Depends on
>>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
>>>
>> chwork.ozlabs.org%2Fcover%2F823205=02%7C01%7Cyork.sun%40nxp.co
>> m%7
>>>
>> Cb59aad3d38094ace132e08d537b11a48%7C686ea1d3bc2b4c6fa92cd99c5c3016
>> 35%7
>>>
>> C0%7C0%7C636476156146644483=4AvC%2FgaoUi5mwTuEZFJr1uSTV2n1
>> %2BAVF
>>> yNIZhuQ3XUQ%3D=0
>>>
>>
>> Bhaskar,
>>
>> I wonder if we can skip this patch and apply other patches. The PFE patch 
>> set is
>> not accepted yet.
>>
>> York
> 
> York, I will send another set of patches which are independent of PFE so that 
> at least Hexa platform support can be accepted without PFE.
> 

When you send another set, please squash your patch
http://patchwork.ozlabs.org/patch/846030/

York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 3/3] drivers: net: pfe_eth: Disable autonegotiation for 2.5G SGMII

2018-01-09 Thread Bhaskar Upadhaya 


>-Original Message-
>From: York Sun
>Sent: Tuesday, January 09, 2018 12:13 AM
>To: Bhaskar Upadhaya ; u-boot@lists.denx.de
>Subject: Re: [PATCH 3/3] drivers: net: pfe_eth: Disable autonegotiation for 
>2.5G
>SGMII
>
>On 11/29/2017 09:13 PM, Bhaskar Upadhaya wrote:
>> PCS initialization sequence for 2.5G SGMII interface governs auto
>> negotiation to be in disabled mode
>>
>> Signed-off-by: Bhaskar Upadhaya 
>> ---
>> Depends on
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
>>
>chwork.ozlabs.org%2Fcover%2F823205=02%7C01%7Cyork.sun%40nxp.co
>m%7
>>
>Cb59aad3d38094ace132e08d537b11a48%7C686ea1d3bc2b4c6fa92cd99c5c3016
>35%7
>>
>C0%7C0%7C636476156146644483=4AvC%2FgaoUi5mwTuEZFJr1uSTV2n1
>%2BAVF
>> yNIZhuQ3XUQ%3D=0
>>
>
>Bhaskar,
>
>I wonder if we can skip this patch and apply other patches. The PFE patch set 
>is
>not accepted yet.
>
>York

York, I will send another set of patches which are independent of PFE so that 
at least Hexa platform support can be accepted without PFE.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 3/3] drivers: net: pfe_eth: Disable autonegotiation for 2.5G SGMII

2018-01-08 Thread York Sun 
On 11/29/2017 09:13 PM, Bhaskar Upadhaya wrote:
> PCS initialization sequence for 2.5G SGMII interface governs
> auto negotiation to be in disabled mode
> 
> Signed-off-by: Bhaskar Upadhaya 
> ---
> Depends on 
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fcover%2F823205=02%7C01%7Cyork.sun%40nxp.com%7Cb59aad3d38094ace132e08d537b11a48%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636476156146644483=4AvC%2FgaoUi5mwTuEZFJr1uSTV2n1%2BAVFyNIZhuQ3XUQ%3D=0
> 

Bhaskar,

I wonder if we can skip this patch and apply other patches. The PFE
patch set is not accepted yet.

York
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 3/3] drivers: net: pfe_eth: Disable autonegotiation for 2.5G SGMII

2017-11-30 Thread Bhaskar Upadhaya 
PCS initialization sequence for 2.5G SGMII interface governs
auto negotiation to be in disabled mode

Signed-off-by: Bhaskar Upadhaya 
---
Depends on https://patchwork.ozlabs.org/cover/823205

 drivers/net/pfe_eth/pfe_eth.c   | 3 +++
 include/pfe_eth/pfe/cbus/emac.h | 1 +
 2 files changed, 4 insertions(+)

diff --git a/drivers/net/pfe_eth/pfe_eth.c b/drivers/net/pfe_eth/pfe_eth.c
index 4db823f..01b745b 100644
--- a/drivers/net/pfe_eth/pfe_eth.c
+++ b/drivers/net/pfe_eth/pfe_eth.c
@@ -426,6 +426,9 @@ static void ls1012a_configure_serdes(struct ls1012a_eth_dev 
*priv)
value = PHY_SGMII_CR_DEF_VAL;
if (!sgmii_2500)
value |= PHY_SGMII_CR_RESET_AN;
+   /* Disable Auto neg for 2.5G SGMII as it doesn't support auto neg*/
+   if (sgmii_2500)
+   value &= ~PHY_SGMII_ENABLE_AN;
ls1012a_phy_write(, 0, MDIO_DEVAD_NONE, 0, value);
 }
 
diff --git a/include/pfe_eth/pfe/cbus/emac.h b/include/pfe_eth/pfe/cbus/emac.h
index 3cfcd99..b61f3ad 100644
--- a/include/pfe_eth/pfe/cbus/emac.h
+++ b/include/pfe_eth/pfe/cbus/emac.h
@@ -146,5 +146,6 @@ enum mac_speed {SPEED_10M, SPEED_100M, SPEED_1000M, 
SPEED_1000M_PCS};
 #define PHY_SGMII_IF_MODE_AN0x0002
 #define PHY_SGMII_IF_MODE_SGMII 0x0001
 #define PHY_SGMII_IF_MODE_SGMII_GBT 0x0008
+#define PHY_SGMII_ENABLE_AN 0x1000
 
 #endif /* _EMAC_H_ */
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot