Re: [U-Boot] [PATCH 3/5] Removed unused define, CONFIG_ARMV7.
Dear Christopher Harvey, In message <20110704184659.gg3...@harvey-pc.matrox.com> you wrote: > > > Need the empty line that wasn't there before? Same Q for every file in > > this patch. > > I generated this patch with sed actually. I could easily re-run it and > tell it to remove the newlines. Lets see if it gets > considered/accepted first. Please fix this (and the other comments), and it goes in. > > > #define CONFIG_SYS_TEXT_BASE 0x6080 > > > > > > /* High Level Configuration Options */ > > > -#define CONFIG_ARMV7 1 > > > + > > > > > > > If that was the only remaining high level config option, should the > > comment be removed? > > I figured maintainers would get to it eventually. Such "eventually" never works. Please go through this manually and clean up. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Wenn Du ein' weise Antwort verlangst, Mußt Du vernünftig fragen. -- Goethe, Invektiven ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/5] Removed unused define, CONFIG_ARMV7.
On Mon, Jul 04, 2011 at 02:00:12PM -0400, Jason wrote: > On Mon, Jul 04, 2011 at 01:44:26PM -0400, Christopher Harvey wrote: > > Signed-off-by: Christopher Harvey > > --- > > include/configs/am3517_crane.h |2 +- > > include/configs/am3517_evm.h|2 +- > > include/configs/ca9x4_ct_vxp.h |2 +- > > include/configs/cm_t35.h|2 +- > > include/configs/devkit8000.h|2 +- > > include/configs/dig297.h|2 +- > > include/configs/igep0020.h |2 +- > > include/configs/igep0030.h |2 +- > > include/configs/omap3_beagle.h |2 +- > > include/configs/omap3_evm.h |2 +- > > include/configs/omap3_overo.h |2 +- > > include/configs/omap3_pandora.h |2 +- > > include/configs/omap3_sdp3430.h |2 +- > > include/configs/omap3_zoom1.h |2 +- > > include/configs/omap3_zoom2.h |2 +- > > include/configs/omap4_panda.h |2 +- > > include/configs/omap4_sdp4430.h |2 +- > > include/configs/s5p_goni.h |2 +- > > include/configs/s5pc210_universal.h |2 +- > > include/configs/smdkc100.h |2 +- > > include/configs/smdkv310.h |2 +- > > 21 files changed, 21 insertions(+), 21 deletions(-) > > > > diff --git a/include/configs/am3517_crane.h b/include/configs/am3517_crane.h > > index 09cb951..b809053 100644 > > --- a/include/configs/am3517_crane.h > > +++ b/include/configs/am3517_crane.h > > @@ -28,7 +28,7 @@ > > /* > > * High Level Configuration Options > > */ > > -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ > > + > > Need the empty line that wasn't there before? Same Q for every file in > this patch. I generated this patch with sed actually. I could easily re-run it and tell it to remove the newlines. Lets see if it gets considered/accepted first. > > > #define CONFIG_OMAP1 /* in a TI OMAP core */ > > #define CONFIG_OMAP34XX1 /* which is a 34XX */ > > #define CONFIG_OMAP3_AM3517CRANE 1 /* working with CRANEBOARD */ > > diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h > > index 80ad342..db026c4 100644 > > --- a/include/configs/am3517_evm.h > > +++ b/include/configs/am3517_evm.h > > @@ -28,7 +28,7 @@ > > /* > > * High Level Configuration Options > > */ > > -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ > > + > > #define CONFIG_OMAP1 /* in a TI OMAP core */ > > #define CONFIG_OMAP34XX1 /* which is a 34XX */ > > #define CONFIG_OMAP3_AM3517EVM 1 /* working with AM3517EVM */ > > diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h > > index 7f83249..fd92137 100644 > > --- a/include/configs/ca9x4_ct_vxp.h > > +++ b/include/configs/ca9x4_ct_vxp.h > > @@ -33,7 +33,7 @@ > > #define CONFIG_SYS_TEXT_BASE 0x6080 > > > > /* High Level Configuration Options */ > > -#define CONFIG_ARMV7 1 > > + > > > > If that was the only remaining high level config option, should the > comment be removed? I figured maintainers would get to it eventually. > > > #define CONFIG_SYS_MEMTEST_START 0x6000 > > #define CONFIG_SYS_MEMTEST_END 0x2000 > > diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h > > index 93a1b26..b4cec35 100644 > > --- a/include/configs/cm_t35.h > > +++ b/include/configs/cm_t35.h > > @@ -36,7 +36,7 @@ > > /* > > * High Level Configuration Options > > */ > > -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ > > + > > #define CONFIG_OMAP1 /* in a TI OMAP core */ > > #define CONFIG_OMAP34XX1 /* which is a 34XX */ > > #define CONFIG_OMAP34301 /* which is in a 3430 */ > > diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h > > index 125c690..f97a4ed 100644 > > --- a/include/configs/devkit8000.h > > +++ b/include/configs/devkit8000.h > > @@ -32,7 +32,7 @@ > > #define __CONFIG_H > > > > /* High Level Configuration Options */ > > -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ > > + > > #define CONFIG_OMAP1 /* in a TI OMAP core */ > > #define CONFIG_OMAP34XX1 /* which is a 34XX */ > > #define CONFIG_OMAP34301 /* which is in a 3430 */ > > diff --git a/include/configs/dig297.h b/include/configs/dig297.h > > index 7aeb24e..ee0c6be 100644 > > --- a/include/configs/dig297.h > > +++ b/include/configs/dig297.h > > @@ -35,7 +35,7 @@ > > /* > > * High Level Configuration Options > > */ > > -#define CONFIG_ARMV7 /* This is an ARM V7 CPU core */ > > + > > #define CONFIG_OMAP/* in a TI OMAP core */ > > #define CONFIG_OMAP34XX/* which is a 34XX */ > > #define CONFIG_OMAP3430
Re: [U-Boot] [PATCH 3/5] Removed unused define, CONFIG_ARMV7.
On Mon, Jul 04, 2011 at 01:44:26PM -0400, Christopher Harvey wrote: > Signed-off-by: Christopher Harvey > --- > include/configs/am3517_crane.h |2 +- > include/configs/am3517_evm.h|2 +- > include/configs/ca9x4_ct_vxp.h |2 +- > include/configs/cm_t35.h|2 +- > include/configs/devkit8000.h|2 +- > include/configs/dig297.h|2 +- > include/configs/igep0020.h |2 +- > include/configs/igep0030.h |2 +- > include/configs/omap3_beagle.h |2 +- > include/configs/omap3_evm.h |2 +- > include/configs/omap3_overo.h |2 +- > include/configs/omap3_pandora.h |2 +- > include/configs/omap3_sdp3430.h |2 +- > include/configs/omap3_zoom1.h |2 +- > include/configs/omap3_zoom2.h |2 +- > include/configs/omap4_panda.h |2 +- > include/configs/omap4_sdp4430.h |2 +- > include/configs/s5p_goni.h |2 +- > include/configs/s5pc210_universal.h |2 +- > include/configs/smdkc100.h |2 +- > include/configs/smdkv310.h |2 +- > 21 files changed, 21 insertions(+), 21 deletions(-) > > diff --git a/include/configs/am3517_crane.h b/include/configs/am3517_crane.h > index 09cb951..b809053 100644 > --- a/include/configs/am3517_crane.h > +++ b/include/configs/am3517_crane.h > @@ -28,7 +28,7 @@ > /* > * High Level Configuration Options > */ > -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ > + Need the empty line that wasn't there before? Same Q for every file in this patch. > #define CONFIG_OMAP 1 /* in a TI OMAP core */ > #define CONFIG_OMAP34XX 1 /* which is a 34XX */ > #define CONFIG_OMAP3_AM3517CRANE 1 /* working with CRANEBOARD */ > diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h > index 80ad342..db026c4 100644 > --- a/include/configs/am3517_evm.h > +++ b/include/configs/am3517_evm.h > @@ -28,7 +28,7 @@ > /* > * High Level Configuration Options > */ > -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ > + > #define CONFIG_OMAP 1 /* in a TI OMAP core */ > #define CONFIG_OMAP34XX 1 /* which is a 34XX */ > #define CONFIG_OMAP3_AM3517EVM 1 /* working with AM3517EVM */ > diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h > index 7f83249..fd92137 100644 > --- a/include/configs/ca9x4_ct_vxp.h > +++ b/include/configs/ca9x4_ct_vxp.h > @@ -33,7 +33,7 @@ > #define CONFIG_SYS_TEXT_BASE 0x6080 > > /* High Level Configuration Options */ > -#define CONFIG_ARMV7 1 > + > If that was the only remaining high level config option, should the comment be removed? > #define CONFIG_SYS_MEMTEST_START 0x6000 > #define CONFIG_SYS_MEMTEST_END 0x2000 > diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h > index 93a1b26..b4cec35 100644 > --- a/include/configs/cm_t35.h > +++ b/include/configs/cm_t35.h > @@ -36,7 +36,7 @@ > /* > * High Level Configuration Options > */ > -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ > + > #define CONFIG_OMAP 1 /* in a TI OMAP core */ > #define CONFIG_OMAP34XX 1 /* which is a 34XX */ > #define CONFIG_OMAP3430 1 /* which is in a 3430 */ > diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h > index 125c690..f97a4ed 100644 > --- a/include/configs/devkit8000.h > +++ b/include/configs/devkit8000.h > @@ -32,7 +32,7 @@ > #define __CONFIG_H > > /* High Level Configuration Options */ > -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ > + > #define CONFIG_OMAP 1 /* in a TI OMAP core */ > #define CONFIG_OMAP34XX 1 /* which is a 34XX */ > #define CONFIG_OMAP3430 1 /* which is in a 3430 */ > diff --git a/include/configs/dig297.h b/include/configs/dig297.h > index 7aeb24e..ee0c6be 100644 > --- a/include/configs/dig297.h > +++ b/include/configs/dig297.h > @@ -35,7 +35,7 @@ > /* > * High Level Configuration Options > */ > -#define CONFIG_ARMV7 /* This is an ARM V7 CPU core */ > + > #define CONFIG_OMAP /* in a TI OMAP core */ > #define CONFIG_OMAP34XX /* which is a 34XX */ > #define CONFIG_OMAP3430 /* which is in a 3430 */ > diff --git a/include/configs/igep0020.h b/include/configs/igep0020.h > index 5af9bec..1c36bc2 100644 > --- a/include/configs/igep0020.h > +++ b/include/configs/igep0020.h > @@ -25,7 +25,7 @@ > /* > * High Level Configuration Options > */ > -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ > + > #define CONFIG_OMAP 1 /* in a TI OMAP core */ > #define CONFIG_OMAP34XX 1 /* which is a 34XX */ > #define CONFIG_OMAP3430 1 /
[U-Boot] [PATCH 3/5] Removed unused define, CONFIG_ARMV7.
Signed-off-by: Christopher Harvey --- include/configs/am3517_crane.h |2 +- include/configs/am3517_evm.h|2 +- include/configs/ca9x4_ct_vxp.h |2 +- include/configs/cm_t35.h|2 +- include/configs/devkit8000.h|2 +- include/configs/dig297.h|2 +- include/configs/igep0020.h |2 +- include/configs/igep0030.h |2 +- include/configs/omap3_beagle.h |2 +- include/configs/omap3_evm.h |2 +- include/configs/omap3_overo.h |2 +- include/configs/omap3_pandora.h |2 +- include/configs/omap3_sdp3430.h |2 +- include/configs/omap3_zoom1.h |2 +- include/configs/omap3_zoom2.h |2 +- include/configs/omap4_panda.h |2 +- include/configs/omap4_sdp4430.h |2 +- include/configs/s5p_goni.h |2 +- include/configs/s5pc210_universal.h |2 +- include/configs/smdkc100.h |2 +- include/configs/smdkv310.h |2 +- 21 files changed, 21 insertions(+), 21 deletions(-) diff --git a/include/configs/am3517_crane.h b/include/configs/am3517_crane.h index 09cb951..b809053 100644 --- a/include/configs/am3517_crane.h +++ b/include/configs/am3517_crane.h @@ -28,7 +28,7 @@ /* * High Level Configuration Options */ -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ + #define CONFIG_OMAP1 /* in a TI OMAP core */ #define CONFIG_OMAP34XX1 /* which is a 34XX */ #define CONFIG_OMAP3_AM3517CRANE 1 /* working with CRANEBOARD */ diff --git a/include/configs/am3517_evm.h b/include/configs/am3517_evm.h index 80ad342..db026c4 100644 --- a/include/configs/am3517_evm.h +++ b/include/configs/am3517_evm.h @@ -28,7 +28,7 @@ /* * High Level Configuration Options */ -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ + #define CONFIG_OMAP1 /* in a TI OMAP core */ #define CONFIG_OMAP34XX1 /* which is a 34XX */ #define CONFIG_OMAP3_AM3517EVM 1 /* working with AM3517EVM */ diff --git a/include/configs/ca9x4_ct_vxp.h b/include/configs/ca9x4_ct_vxp.h index 7f83249..fd92137 100644 --- a/include/configs/ca9x4_ct_vxp.h +++ b/include/configs/ca9x4_ct_vxp.h @@ -33,7 +33,7 @@ #define CONFIG_SYS_TEXT_BASE 0x6080 /* High Level Configuration Options */ -#define CONFIG_ARMV7 1 + #define CONFIG_SYS_MEMTEST_START 0x6000 #define CONFIG_SYS_MEMTEST_END 0x2000 diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h index 93a1b26..b4cec35 100644 --- a/include/configs/cm_t35.h +++ b/include/configs/cm_t35.h @@ -36,7 +36,7 @@ /* * High Level Configuration Options */ -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ + #define CONFIG_OMAP1 /* in a TI OMAP core */ #define CONFIG_OMAP34XX1 /* which is a 34XX */ #define CONFIG_OMAP34301 /* which is in a 3430 */ diff --git a/include/configs/devkit8000.h b/include/configs/devkit8000.h index 125c690..f97a4ed 100644 --- a/include/configs/devkit8000.h +++ b/include/configs/devkit8000.h @@ -32,7 +32,7 @@ #define __CONFIG_H /* High Level Configuration Options */ -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ + #define CONFIG_OMAP1 /* in a TI OMAP core */ #define CONFIG_OMAP34XX1 /* which is a 34XX */ #define CONFIG_OMAP34301 /* which is in a 3430 */ diff --git a/include/configs/dig297.h b/include/configs/dig297.h index 7aeb24e..ee0c6be 100644 --- a/include/configs/dig297.h +++ b/include/configs/dig297.h @@ -35,7 +35,7 @@ /* * High Level Configuration Options */ -#define CONFIG_ARMV7 /* This is an ARM V7 CPU core */ + #define CONFIG_OMAP/* in a TI OMAP core */ #define CONFIG_OMAP34XX/* which is a 34XX */ #define CONFIG_OMAP3430/* which is in a 3430 */ diff --git a/include/configs/igep0020.h b/include/configs/igep0020.h index 5af9bec..1c36bc2 100644 --- a/include/configs/igep0020.h +++ b/include/configs/igep0020.h @@ -25,7 +25,7 @@ /* * High Level Configuration Options */ -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ + #define CONFIG_OMAP1 /* in a TI OMAP core */ #define CONFIG_OMAP34XX1 /* which is a 34XX */ #define CONFIG_OMAP34301 /* which is in a 3430 */ diff --git a/include/configs/igep0030.h b/include/configs/igep0030.h index 92144af..8594b87 100644 --- a/include/configs/igep0030.h +++ b/include/configs/igep0030.h @@ -25,7 +25,7 @@ /* * High Level Configuration Options */ -#define CONFIG_ARMV7 1 /* This is an ARM V7 CPU core */ + #define CONFIG_OMAP1 /* in a TI OMAP core */ #define CONFIG_OMAP34XX1
