[U-Boot] [PATCH 3/5] sf: sf_dataflash: Remove CONFIG_SPI_DATAFLASH_WRITE_VERIFY option
Signed-off-by: Haikun Wang --- drivers/mtd/spi/sf_dataflash.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mtd/spi/sf_dataflash.c b/drivers/mtd/spi/sf_dataflash.c index 8f91527..6bf628b 100644 --- a/drivers/mtd/spi/sf_dataflash.c +++ b/drivers/mtd/spi/sf_dataflash.c @@ -371,7 +371,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, size_t len, goto release_bus; } -#ifdef CONFIG_SPI_DATAFLASH_WRITE_VERIFY /* (3) Compare to Buffer1 */ addr = pageaddr << dataflash->page_offset; command[0] = OP_COMPARE_BUF1; @@ -404,7 +403,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, size_t len, status = 0; } -#endif /* CONFIG_SPI_DATAFLASH_WRITE_VERIFY */ remaining = remaining - writelen; pageaddr++; to = 0; -- 2.1.0.27.g96db324 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/5] sf: sf_dataflash: Remove CONFIG_SPI_DATAFLASH_WRITE_VERIFY option
Hi, On 2 July 2015 at 03:12, Haikun Wang wrote: > Signed-off-by: Haikun Wang Missing commit message. Doesn't this mean it will always do the verify? > --- > drivers/mtd/spi/sf_dataflash.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/spi/sf_dataflash.c b/drivers/mtd/spi/sf_dataflash.c > index 8f91527..6bf628b 100644 > --- a/drivers/mtd/spi/sf_dataflash.c > +++ b/drivers/mtd/spi/sf_dataflash.c > @@ -371,7 +371,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, > size_t len, > goto release_bus; > } > > -#ifdef CONFIG_SPI_DATAFLASH_WRITE_VERIFY > /* (3) Compare to Buffer1 */ > addr = pageaddr << dataflash->page_offset; > command[0] = OP_COMPARE_BUF1; > @@ -404,7 +403,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, > size_t len, > status = 0; > } > > -#endif /* CONFIG_SPI_DATAFLASH_WRITE_VERIFY */ > remaining = remaining - writelen; > pageaddr++; > to = 0; > -- > 2.1.0.27.g96db324 > Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/5] sf: sf_dataflash: Remove CONFIG_SPI_DATAFLASH_WRITE_VERIFY option
On 7/7/2015 1:33 AM, Simon Glass wrote: > Hi, > > On 2 July 2015 at 03:12, Haikun Wang wrote: >> Signed-off-by: Haikun Wang > > Missing commit message. Doesn't this mean it will always do the verify? OK, I will add the commit message. It will always do the verify. > >> --- >> drivers/mtd/spi/sf_dataflash.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/mtd/spi/sf_dataflash.c b/drivers/mtd/spi/sf_dataflash.c >> index 8f91527..6bf628b 100644 >> --- a/drivers/mtd/spi/sf_dataflash.c >> +++ b/drivers/mtd/spi/sf_dataflash.c >> @@ -371,7 +371,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, >> size_t len, >> goto release_bus; >> } >> >> -#ifdef CONFIG_SPI_DATAFLASH_WRITE_VERIFY >> /* (3) Compare to Buffer1 */ >> addr = pageaddr << dataflash->page_offset; >> command[0] = OP_COMPARE_BUF1; >> @@ -404,7 +403,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, >> size_t len, >> status = 0; >> } >> >> -#endif /* CONFIG_SPI_DATAFLASH_WRITE_VERIFY */ >> remaining = remaining - writelen; >> pageaddr++; >> to = 0; >> -- >> 2.1.0.27.g96db324 >> > > Regards, > Simon > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 3/5] sf: sf_dataflash: Remove CONFIG_SPI_DATAFLASH_WRITE_VERIFY option
On 7/7/2015 1:33 AM, Simon Glass wrote: > Hi, > > On 2 July 2015 at 03:12, Haikun Wang wrote: >> Signed-off-by: Haikun Wang > > Missing commit message. Doesn't this mean it will always do the verify? > >> --- >> drivers/mtd/spi/sf_dataflash.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/mtd/spi/sf_dataflash.c b/drivers/mtd/spi/sf_dataflash.c >> index 8f91527..6bf628b 100644 >> --- a/drivers/mtd/spi/sf_dataflash.c >> +++ b/drivers/mtd/spi/sf_dataflash.c >> @@ -371,7 +371,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, >> size_t len, >> goto release_bus; >> } >> >> -#ifdef CONFIG_SPI_DATAFLASH_WRITE_VERIFY >> /* (3) Compare to Buffer1 */ >> addr = pageaddr << dataflash->page_offset; >> command[0] = OP_COMPARE_BUF1; >> @@ -404,7 +403,6 @@ int spi_dataflash_write(struct udevice *dev, u32 offset, >> size_t len, >> status = 0; >> } >> >> -#endif /* CONFIG_SPI_DATAFLASH_WRITE_VERIFY */ >> remaining = remaining - writelen; >> pageaddr++; >> to = 0; >> -- >> 2.1.0.27.g96db324 >> > > Regards, > Simon > Update my email address. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
