Re: [U-Boot] [PATCH 3/7] Remove instances of phy_read/write

2011-03-30 Thread Detlev Zundel
Hi Andy,

 There were a few files which were already using phy_read and phy_write
 for their PHY function names.  It's only a few places, and the name
 seems most appropriate for the high-level abstraction, so let's
 rename the other versions to something more specific.

 Also, uec_phy.c had a marvell_init function which I renamed to not
 conflict with the one in marvell.c

 Signed-off-by: Andy Fleming aflem...@freescale.com

Looks like these are harmless changes, so

Acked-by: Detlev Zundel d...@denx.de

Might be worthwhile to see some Tested-by from people with the hardware
though.

Cheers
  Detlev
  
-- 
By all means let's be open-minded, but not so open-minded that our
brains drop out.
-- Richard Dawkins
--
DENX Software Engineering GmbH,  MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH 3/7] Remove instances of phy_read/write

2011-03-29 Thread Andy Fleming
There were a few files which were already using phy_read and phy_write
for their PHY function names.  It's only a few places, and the name
seems most appropriate for the high-level abstraction, so let's
rename the other versions to something more specific.

Also, uec_phy.c had a marvell_init function which I renamed to not
conflict with the one in marvell.c

Signed-off-by: Andy Fleming aflem...@freescale.com
---
 drivers/net/dm9000x.c  |   18 +++---
 drivers/net/enc28j60.c |   24 
 drivers/net/uli526x.c  |   24 
 drivers/qe/uec.c   |3 -
 drivers/qe/uec_phy.c   |  145 
 5 files changed, 107 insertions(+), 107 deletions(-)

diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c
index 709f67a..b5c5573 100644
--- a/drivers/net/dm9000x.c
+++ b/drivers/net/dm9000x.c
@@ -110,8 +110,8 @@ static board_info_t dm9000_info;
 
 /* function declaration - */
 static int dm9000_probe(void);
-static u16 phy_read(int);
-static void phy_write(int, u16);
+static u16 dm9000_phy_read(int);
+static void dm9000_phy_write(int, u16);
 static u8 DM9000_ior(int);
 static void DM9000_iow(int reg, u8 value);
 
@@ -361,7 +361,7 @@ static int dm9000_init(struct eth_device *dev, bd_t *bd)
DM9000_iow(DM9000_IMR, IMR_PAR);
 
i = 0;
-   while (!(phy_read(1)  0x20)) { /* autonegation complete bit */
+   while (!(dm9000_phy_read(1)  0x20)) {  /* autonegation complete bit */
udelay(1000);
i++;
if (i == 1) {
@@ -371,7 +371,7 @@ static int dm9000_init(struct eth_device *dev, bd_t *bd)
}
 
/* see what we've got */
-   lnk = phy_read(17)  12;
+   lnk = dm9000_phy_read(17)  12;
printf(operating at );
switch (lnk) {
case 1:
@@ -445,7 +445,7 @@ static void dm9000_halt(struct eth_device *netdev)
DM9000_DBG(%s\n, __func__);
 
/* RESET devie */
-   phy_write(0, 0x8000);   /* PHY RESET */
+   dm9000_phy_write(0, 0x8000);/* PHY RESET */
DM9000_iow(DM9000_GPR, 0x01);   /* Power-Down PHY */
DM9000_iow(DM9000_IMR, 0x80);   /* Disable all interrupt */
DM9000_iow(DM9000_RCR, 0x00);   /* Disable RX */
@@ -581,7 +581,7 @@ DM9000_iow(int reg, u8 value)
Read a word from phyxcer
 */
 static u16
-phy_read(int reg)
+dm9000_phy_read(int reg)
 {
u16 val;
 
@@ -593,7 +593,7 @@ phy_read(int reg)
val = (DM9000_ior(DM9000_EPDRH)  8) | DM9000_ior(DM9000_EPDRL);
 
/* The read data keeps on REG_0D  REG_0E */
-   DM9000_DBG(phy_read(0x%x): 0x%x\n, reg, val);
+   DM9000_DBG(dm9000_phy_read(0x%x): 0x%x\n, reg, val);
return val;
 }
 
@@ -601,7 +601,7 @@ phy_read(int reg)
Write a word to phyxcer
 */
 static void
-phy_write(int reg, u16 value)
+dm9000_phy_write(int reg, u16 value)
 {
 
/* Fill the phyxcer register into REG_0C */
@@ -613,7 +613,7 @@ phy_write(int reg, u16 value)
DM9000_iow(DM9000_EPCR, 0xa);   /* Issue phyxcer write command */
udelay(500);/* Wait write complete */
DM9000_iow(DM9000_EPCR, 0x0);   /* Clear phyxcer write command */
-   DM9000_DBG(phy_write(reg:0x%x, value:0x%x)\n, reg, value);
+   DM9000_DBG(dm9000_phy_write(reg:0x%x, value:0x%x)\n, reg, value);
 }
 
 int dm9000_initialize(bd_t *bis)
diff --git a/drivers/net/enc28j60.c b/drivers/net/enc28j60.c
index 6c161b6..d55cacd 100644
--- a/drivers/net/enc28j60.c
+++ b/drivers/net/enc28j60.c
@@ -314,7 +314,7 @@ static void enc_release_bus(enc_dev_t *enc)
 /*
  * Read PHY register
  */
-static u16 phy_read(enc_dev_t *enc, const u8 addr)
+static u16 enc_phy_read(enc_dev_t *enc, const u8 addr)
 {
uint64_t etime;
u8 status;
@@ -339,7 +339,7 @@ static u16 phy_read(enc_dev_t *enc, const u8 addr)
 /*
  * Write PHY register
  */
-static void phy_write(enc_dev_t *enc, const u8 addr, const u16 data)
+static void enc_phy_write(enc_dev_t *enc, const u8 addr, const u16 data)
 {
uint64_t etime;
u8 status;
@@ -374,7 +374,7 @@ static int enc_phy_link_wait(enc_dev_t *enc)
 
 #ifdef CONFIG_ENC_SILENTLINK
/* check if we have a link, then just return */
-   status = phy_read(enc, PHY_REG_PHSTAT1);
+   status = enc_phy_read(enc, PHY_REG_PHSTAT1);
if (status  ENC_PHSTAT1_LLSTAT)
return 0;
 #endif
@@ -382,10 +382,10 @@ static int enc_phy_link_wait(enc_dev_t *enc)
/* wait for link with 1 second timeout */
etime = get_ticks() + get_tbclk();
while (get_ticks() = etime) {
-   status = phy_read(enc, PHY_REG_PHSTAT1);
+   status = enc_phy_read(enc, PHY_REG_PHSTAT1);
if (status  ENC_PHSTAT1_LLSTAT) {
/* now we have a link */
-   status = phy_read(enc, PHY_REG_PHSTAT2);
+   status = enc_phy_read(enc, PHY_REG_PHSTAT2);
duplex = (status