Re: [U-Boot] [PATCH 4/4] sandbox: Enable sound

2018-11-29 Thread sjg
Now that the buffer-overflow bug is fixed, we can enable sound on sandbox.
Drop the code which exits early.

Signed-off-by: Simon Glass 
---

 arch/sandbox/cpu/sdl.c | 19 ---
 1 file changed, 19 deletions(-)

Applied to u-boot-dm/master, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH 4/4] sandbox: Enable sound

2018-11-15 Thread Simon Glass
Now that the buffer-overflow bug is fixed, we can enable sound on sandbox.
Drop the code which exits early.

Signed-off-by: Simon Glass 
---

 arch/sandbox/cpu/sdl.c | 19 ---
 1 file changed, 19 deletions(-)

diff --git a/arch/sandbox/cpu/sdl.c b/arch/sandbox/cpu/sdl.c
index c940a473d7c..c7a8d945492 100644
--- a/arch/sandbox/cpu/sdl.c
+++ b/arch/sandbox/cpu/sdl.c
@@ -268,25 +268,6 @@ int sandbox_sdl_sound_init(void)
if (sdl.audio_active)
return 0;
 
-   /*
-* At present all sandbox sounds crash. This is probably due to
-* symbol name conflicts with U-Boot. We can remove the malloc()
-* probles with:
-*
-* #define USE_DL_PREFIX
-*
-* and get this:
-*
-* Assertion 'e->pollfd->fd == e->fd' failed at pulse/mainloop.c:676,
-*  function dispatch_pollfds(). Aborting.
-*
-* The right solution is probably to make U-Boot's names private or
-* link os.c and sdl.c against their libraries before liking with
-* U-Boot. TBD. For now sound is disabled.
-*/
-   printf("(Warning: sandbox sound disabled)\n");
-   return 0;
-
/* Set the audio format */
wanted.freq = SAMPLE_RATE;
wanted.format = AUDIO_S16;
-- 
2.19.1.1215.g8438c0b245-goog

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot