Re: [U-Boot] [PATCH 5/7] driver: net: ldpaa: Increase num of buffers for a pool
On 12/24/2015 02:03 AM, Prabhakar Kushwaha wrote: > Management Complex FW 9.0 set the hardware depletion to be 20 buffers > in order to support multiple pools in DPNI. This requires driver to fill > the pool with at least 21 to be able to receive frames. > > So, Increase number of buffers for a pool. > > Signed-off-by: Prabhakar Kushwaha > --- > drivers/net/ldpaa_eth/ldpaa_eth.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Slightly reformat commit message. Applied to u-boot-fsl-qoriq master. Awaiting upstream. Thanks. York ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/7] driver: net: ldpaa: Increase num of buffers for a pool
> -Original Message-
> From: york sun [mailto:york@nxp.com]
> Sent: Monday, January 25, 2016 10:50 PM
> To: Prabhakar Kushwaha ; u-boot@lists.denx.de
> Cc: Yusong Sun
> Subject: Re: [PATCH 5/7] driver: net: ldpaa: Increase num of buffers for a
> pool
>
> On 12/24/2015 02:03 AM, Prabhakar Kushwaha wrote:
> > Management Complex FW 9.0 set the hardware depletion to be 20 buffers
> > in order to support multiple pools in DPNI. This requires driver to
> > fill the pool with at least 21 to be able to receive frames.
> >
> > So, Increase number of buffers for a pool.
> >
> > Signed-off-by: Prabhakar Kushwaha
> > ---
> > drivers/net/ldpaa_eth/ldpaa_eth.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.h
> > b/drivers/net/ldpaa_eth/ldpaa_eth.h
> > index af41b27..3b16150 100644
> > --- a/drivers/net/ldpaa_eth/ldpaa_eth.h
> > +++ b/drivers/net/ldpaa_eth/ldpaa_eth.h
> > @@ -24,7 +24,7 @@ enum ldpaa_eth_type { };
> >
> > /* Arbitrary values for now, but we'll need to tune */
> > -#define LDPAA_ETH_NUM_BUFS (2 * 7)
> > +#define LDPAA_ETH_NUM_BUFS (7 * 7)
>
> You said at least 21, but actually use 49. Is there a connection?
>
Total Buffer must be >= 21.
Regards,
Prabhakar
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 5/7] driver: net: ldpaa: Increase num of buffers for a pool
On 12/24/2015 02:03 AM, Prabhakar Kushwaha wrote:
> Management Complex FW 9.0 set the hardware depletion to be 20 buffers
> in order to support multiple pools in DPNI. This requires driver to fill
> the pool with at least 21 to be able to receive frames.
>
> So, Increase number of buffers for a pool.
>
> Signed-off-by: Prabhakar Kushwaha
> ---
> drivers/net/ldpaa_eth/ldpaa_eth.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.h
> b/drivers/net/ldpaa_eth/ldpaa_eth.h
> index af41b27..3b16150 100644
> --- a/drivers/net/ldpaa_eth/ldpaa_eth.h
> +++ b/drivers/net/ldpaa_eth/ldpaa_eth.h
> @@ -24,7 +24,7 @@ enum ldpaa_eth_type {
> };
>
> /* Arbitrary values for now, but we'll need to tune */
> -#define LDPAA_ETH_NUM_BUFS (2 * 7)
> +#define LDPAA_ETH_NUM_BUFS (7 * 7)
You said at least 21, but actually use 49. Is there a connection?
York
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 5/7] driver: net: ldpaa: Increase num of buffers for a pool
Management Complex FW 9.0 set the hardware depletion to be 20 buffers
in order to support multiple pools in DPNI. This requires driver to fill
the pool with at least 21 to be able to receive frames.
So, Increase number of buffers for a pool.
Signed-off-by: Prabhakar Kushwaha
---
drivers/net/ldpaa_eth/ldpaa_eth.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ldpaa_eth/ldpaa_eth.h
b/drivers/net/ldpaa_eth/ldpaa_eth.h
index af41b27..3b16150 100644
--- a/drivers/net/ldpaa_eth/ldpaa_eth.h
+++ b/drivers/net/ldpaa_eth/ldpaa_eth.h
@@ -24,7 +24,7 @@ enum ldpaa_eth_type {
};
/* Arbitrary values for now, but we'll need to tune */
-#define LDPAA_ETH_NUM_BUFS (2 * 7)
+#define LDPAA_ETH_NUM_BUFS (7 * 7)
#define LDPAA_ETH_REFILL_THRESH(LDPAA_ETH_NUM_BUFS/2)
#define LDPAA_ETH_RX_BUFFER_SIZE 2048
--
1.9.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
