Re: [U-Boot] [PATCH 6/9] powerpc/mpc8548cds: Update config file
Dear Kumar Gala, In message 9c8cc940-a952-4323-8a48-bd6fb389a...@kernel.crashing.org you wrote: total: 0 errors, 1 warnings, 50 lines checked I don't agree with this checkpatch warning. The extra space adds to = readability so leaving this alone. Indentation must be done by TABs. Single spaces are not allowed. Please fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Cleverness and Style have no place in getting a project completed. -- Tom Christiansen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/9] powerpc/mpc8548cds: Update config file
On Oct 6, 2011, at 4:33 PM, Wolfgang Denk wrote: Dear Zhao Chenhui, In message 1315898131-27710-6-git-send-email-chenhui.z...@freescale.com you wrote: From: chenhui zhao chenhui.z...@freescale.com -Increase the size of malloc space. -Enable e1000 network card. -Change the location of env address. -Use hwconfig to turn off ECC. Signed-off-by: Zhao Chenhui chenhui.z...@freescale.com --- include/configs/MPC8548CDS.h | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) Checkpatch says: total: 0 errors, 1 warnings, 50 lines checked Please clean up and resubmit. Thanks. Best regards, Wolfgang Denk I don't agree with this checkpatch warning. The extra space adds to readability so leaving this alone. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/9] powerpc/mpc8548cds: Update config file
On Sep 13, 2011, at 2:15 AM, Zhao Chenhui wrote: From: chenhui zhao chenhui.z...@freescale.com -Increase the size of malloc space. -Enable e1000 network card. -Change the location of env address. -Use hwconfig to turn off ECC. Signed-off-by: Zhao Chenhui chenhui.z...@freescale.com --- include/configs/MPC8548CDS.h | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) applied to 85xx - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/9] powerpc/mpc8548cds: Update config file
Dear Zhao Chenhui, In message 1315898131-27710-6-git-send-email-chenhui.z...@freescale.com you wrote: From: chenhui zhao chenhui.z...@freescale.com -Increase the size of malloc space. -Enable e1000 network card. -Change the location of env address. -Use hwconfig to turn off ECC. Signed-off-by: Zhao Chenhui chenhui.z...@freescale.com --- include/configs/MPC8548CDS.h | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) Checkpatch says: total: 0 errors, 1 warnings, 50 lines checked Please clean up and resubmit. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The day-to-day travails of the IBM programmer are so amusing to most of us who are fortunate enough never to have been one - like watching Charlie Chaplin trying to cook a shoe. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 6/9] powerpc/mpc8548cds: Update config file
From: chenhui zhao chenhui.z...@freescale.com -Increase the size of malloc space. -Enable e1000 network card. -Change the location of env address. -Use hwconfig to turn off ECC. Signed-off-by: Zhao Chenhui chenhui.z...@freescale.com --- include/configs/MPC8548CDS.h | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/include/configs/MPC8548CDS.h b/include/configs/MPC8548CDS.h index 64745e1..2760af0 100644 --- a/include/configs/MPC8548CDS.h +++ b/include/configs/MPC8548CDS.h @@ -86,6 +86,7 @@ extern unsigned long get_clock_freq(void); #define CONFIG_SPD_EEPROM /* Use SPD EEPROM for DDR setup*/ #define CONFIG_DDR_SPD +#define CONFIG_DDR_ECC #define CONFIG_ECC_INIT_VIA_DDRCONTROLLER /* DDR controller or DMA? */ #define CONFIG_MEM_INIT_VALUE 0xDeadBeef @@ -162,6 +163,7 @@ extern unsigned long get_clock_freq(void); #define CONFIG_SYS_FLASH_CFI #define CONFIG_SYS_FLASH_EMPTY_INFO +#define CONFIG_HWCONFIG/* enable hwconfig */ /* * SDRAM on the Local Bus @@ -276,7 +278,7 @@ extern unsigned long get_clock_freq(void); #define CONFIG_SYS_INIT_SP_OFFSET CONFIG_SYS_GBL_DATA_OFFSET #define CONFIG_SYS_MONITOR_LEN (256 * 1024) /* Reserve 256 kB for Mon */ -#define CONFIG_SYS_MALLOC_LEN (128 * 1024)/* Reserved for malloc */ +#define CONFIG_SYS_MALLOC_LEN (1024 * 1024) /* Reserved for malloc */ /* Serial Port */ #define CONFIG_CONS_INDEX 2 @@ -382,6 +384,7 @@ extern unsigned long get_clock_freq(void); #undef CONFIG_EEPRO100 #undef CONFIG_TULIP +#define CONFIG_E1000 /* Define e1000 pci Ethernet card */ #undef CONFIG_PCI_SCAN_SHOW/* show pci devices on startup */ @@ -430,8 +433,12 @@ extern unsigned long get_clock_freq(void); * Environment */ #define CONFIG_ENV_IS_IN_FLASH 1 -#define CONFIG_ENV_ADDR(CONFIG_SYS_MONITOR_BASE + 0x4) -#define CONFIG_ENV_SECT_SIZE 0x4 /* 256K(one sector) for env */ +#if CONFIG_SYS_MONITOR_BASE 0xfff8 +#define CONFIG_ENV_ADDR0xfff8 +#else +#define CONFIG_ENV_ADDR(CONFIG_SYS_MONITOR_BASE - CONFIG_ENV_SECT_SIZE) +#endif +#define CONFIG_ENV_SECT_SIZE 0x2 /* 128K for env */ #define CONFIG_ENV_SIZE0x2000 #define CONFIG_LOADS_ECHO 1 /* echo on for serial download */ @@ -532,6 +539,7 @@ extern unsigned long get_clock_freq(void); #define CONFIG_BAUDRATE115200 #defineCONFIG_EXTRA_ENV_SETTINGS \ + hwconfig=fsl_ddr:ecc=off\0 \ netdev=eth0\0 \ uboot= MK_STR(CONFIG_UBOOTPATH) \0\ tftpflash=tftpboot $loadaddr $uboot;\ -- 1.6.4.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 6/9] powerpc/mpc8548cds: Update config file
On Tue, Sep 13, 2011 at 2:15 AM, Zhao Chenhui chenhui.z...@freescale.com wrote: From: chenhui zhao chenhui.z...@freescale.com -Increase the size of malloc space. -Enable e1000 network card. -Change the location of env address. -Use hwconfig to turn off ECC. Please repost this patch with a detailed explanation as to why these changes are being made. Why do you need more malloc space? Why enable only the E1000 card? What's wrong with the current environment address? And why does the default hwconfig need to turn off ECC? -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
