Re: [U-Boot] [PATCH 7/9] net: sun8i_emac: Fix build for non-H3/H5 SoCs

[Jagan Teki]

On Fri, Nov 10, 2017 at 11:34 AM, Chen-Yu Tsai  wrote:
> On Fri, Nov 10, 2017 at 2:01 PM, Jagan Teki  wrote:
>> On Fri, Nov 10, 2017 at 9:52 AM, Chen-Yu Tsai  wrote:
>>> On Wed, Sep 27, 2017 at 11:46 PM, Joe Hershberger
>>>  wrote:
 On Fri, Sep 22, 2017 at 2:26 AM, Chen-Yu Tsai  wrote:
> Only the H3/H5 SoCs have an internal PHY and its related clock and
> reset controls.
>
> Use an #ifdef to guard the internal PHY control code block so it
> can be built for other SoCs, such as the A83T or A64.
>
> Signed-off-by: Chen-Yu Tsai 

 Reviewed-by: Joe Hershberger 
>>>
>>> This hasn't been applied yet. Can someone apply this? Jagan?
>>
>> Few emac patches on this series still under review, was this independent fix?
>
> I would consider it an independent fix. Nothing prevents people from
> manually enabling the EMAC driver on other SoCs. They will then get
> a build fail that this patch fixes.
>
> As for the other patches, I respin them soon enough.

Applied to u-boot-sunxi/master

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 7/9] net: sun8i_emac: Fix build for non-H3/H5 SoCs

[Chen-Yu Tsai]

On Fri, Nov 10, 2017 at 2:01 PM, Jagan Teki  wrote:
> On Fri, Nov 10, 2017 at 9:52 AM, Chen-Yu Tsai  wrote:
>> On Wed, Sep 27, 2017 at 11:46 PM, Joe Hershberger
>>  wrote:
>>> On Fri, Sep 22, 2017 at 2:26 AM, Chen-Yu Tsai  wrote:
 Only the H3/H5 SoCs have an internal PHY and its related clock and
 reset controls.

 Use an #ifdef to guard the internal PHY control code block so it
 can be built for other SoCs, such as the A83T or A64.

 Signed-off-by: Chen-Yu Tsai 
>>>
>>> Reviewed-by: Joe Hershberger 
>>
>> This hasn't been applied yet. Can someone apply this? Jagan?
>
> Few emac patches on this series still under review, was this independent fix?

I would consider it an independent fix. Nothing prevents people from
manually enabling the EMAC driver on other SoCs. They will then get
a build fail that this patch fixes.

As for the other patches, I respin them soon enough.

ChenYu
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 7/9] net: sun8i_emac: Fix build for non-H3/H5 SoCs

[Jagan Teki]

On Fri, Nov 10, 2017 at 9:52 AM, Chen-Yu Tsai  wrote:
> On Wed, Sep 27, 2017 at 11:46 PM, Joe Hershberger
>  wrote:
>> On Fri, Sep 22, 2017 at 2:26 AM, Chen-Yu Tsai  wrote:
>>> Only the H3/H5 SoCs have an internal PHY and its related clock and
>>> reset controls.
>>>
>>> Use an #ifdef to guard the internal PHY control code block so it
>>> can be built for other SoCs, such as the A83T or A64.
>>>
>>> Signed-off-by: Chen-Yu Tsai 
>>
>> Reviewed-by: Joe Hershberger 
>
> This hasn't been applied yet. Can someone apply this? Jagan?

Few emac patches on this series still under review, was this independent fix?

-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 7/9] net: sun8i_emac: Fix build for non-H3/H5 SoCs

[Chen-Yu Tsai]

On Wed, Sep 27, 2017 at 11:46 PM, Joe Hershberger
 wrote:
> On Fri, Sep 22, 2017 at 2:26 AM, Chen-Yu Tsai  wrote:
>> Only the H3/H5 SoCs have an internal PHY and its related clock and
>> reset controls.
>>
>> Use an #ifdef to guard the internal PHY control code block so it
>> can be built for other SoCs, such as the A83T or A64.
>>
>> Signed-off-by: Chen-Yu Tsai 
>
> Reviewed-by: Joe Hershberger 

This hasn't been applied yet. Can someone apply this? Jagan?

Thanks
ChenYu
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 7/9] net: sun8i_emac: Fix build for non-H3/H5 SoCs

[Joe Hershberger]

On Fri, Sep 22, 2017 at 2:26 AM, Chen-Yu Tsai  wrote:
> Only the H3/H5 SoCs have an internal PHY and its related clock and
> reset controls.
>
> Use an #ifdef to guard the internal PHY control code block so it
> can be built for other SoCs, such as the A83T or A64.
>
> Signed-off-by: Chen-Yu Tsai 

Reviewed-by: Joe Hershberger 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH 7/9] net: sun8i_emac: Fix build for non-H3/H5 SoCs

[Maxime Ripard]

On Fri, Sep 22, 2017 at 07:26:33AM +, Chen-Yu Tsai wrote:
> Only the H3/H5 SoCs have an internal PHY and its related clock and
> reset controls.
> 
> Use an #ifdef to guard the internal PHY control code block so it
> can be built for other SoCs, such as the A83T or A64.
> 
> Signed-off-by: Chen-Yu Tsai 

Acked-by: Maxime Ripard 

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH 7/9] net: sun8i_emac: Fix build for non-H3/H5 SoCs

[Chen-Yu Tsai]

Only the H3/H5 SoCs have an internal PHY and its related clock and
reset controls.

Use an #ifdef to guard the internal PHY control code block so it
can be built for other SoCs, such as the A83T or A64.

Signed-off-by: Chen-Yu Tsai 
---
 drivers/net/sun8i_emac.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
index 5fa1b4c170d7..0a98a04967da 100644
--- a/drivers/net/sun8i_emac.c
+++ b/drivers/net/sun8i_emac.c
@@ -616,6 +616,8 @@ static void sun8i_emac_board_setup(struct emac_eth_dev 
*priv)
 {
struct sunxi_ccm_reg *ccm = (struct sunxi_ccm_reg *)SUNXI_CCM_BASE;
 
+#ifdef CONFIG_MACH_SUNXI_H3_H5
+   /* Only H3/H5 have clock controls for internal EPHY */
if (priv->use_internal_phy) {
/* Set clock gating for ephy */
setbits_le32(>bus_gate4, BIT(AHB_GATE_OFFSET_EPHY));
@@ -623,6 +625,7 @@ static void sun8i_emac_board_setup(struct emac_eth_dev 
*priv)
/* Deassert EPHY */
setbits_le32(>ahb_reset2_cfg, BIT(AHB_RESET_OFFSET_EPHY));
}
+#endif
 
/* Set clock gating for emac */
setbits_le32(>ahb_gate0, BIT(AHB_GATE_OFFSET_GMAC));
-- 
2.14.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot