Re: [U-Boot] [PATCH 8/8] video: imx25lcdc: add board_video_init() call

2014-05-16 Thread Jeroen Hofstee 
Hello Thomas,

On do, 2014-05-15 at 16:34 +0200, die...@gmx.de wrote:
 From: Thomas Diener die...@gmx.de
 
 Signed-off-by: Thomas Diener die...@gmx.de
 ---
  drivers/video/imx25lcdc.c |   19 +++
  1 file changed, 19 insertions(+)
 
 diff --git a/drivers/video/imx25lcdc.c b/drivers/video/imx25lcdc.c
 index 3b45472..94ef033 100644
 --- a/drivers/video/imx25lcdc.c
 +++ b/drivers/video/imx25lcdc.c
 @@ -23,6 +23,19 @@
  #define FB_SYNC_CLK_INV  (116) /* pixel clock inverted */
  
  /*
 + * We do not enforce board code to provide empty/unused
 + * functions for this driver and define weak default
 + * functions here.
 + */
 +unsigned int __board_video_init (void)
 +{
 + return 0;
 +}
 +
 +unsigned int board_video_init (void)
 + __attribute__((weak, alias(__board_video_init)));
 +

Cosmetic remark. You can merge these with a single __weak.

Regards,
Jeroen

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 8/8] video: imx25lcdc: add board_video_init() call

2014-05-15 Thread dietho 
From: Thomas Diener die...@gmx.de

Signed-off-by: Thomas Diener die...@gmx.de
---
 drivers/video/imx25lcdc.c |   19 +++
 1 file changed, 19 insertions(+)

diff --git a/drivers/video/imx25lcdc.c b/drivers/video/imx25lcdc.c
index 3b45472..94ef033 100644
--- a/drivers/video/imx25lcdc.c
+++ b/drivers/video/imx25lcdc.c
@@ -23,6 +23,19 @@
 #define FB_SYNC_CLK_INV(116) /* pixel clock inverted */
 
 /*
+ * We do not enforce board code to provide empty/unused
+ * functions for this driver and define weak default
+ * functions here.
+ */
+unsigned int __board_video_init (void)
+{
+   return 0;
+}
+
+unsigned int board_video_init (void)
+   __attribute__((weak, alias(__board_video_init)));
+
+/*
  * Graphic Device
  */
 static GraphicDevice imx25fb;
@@ -117,6 +130,12 @@ void *video_hw_init(void)
writel(readl(ccm-cgr1) | (129), ccm-cgr1);
}
 
+   /*
+* Initialization of the access to the graphic chipset Retreive base
+* address of the chipset (see board/RPXClassic/eccx.c)
+*/
+   board_video_init();
+
return pGD;
 }
 
-- 
1.7.9.5

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot