Re: [U-Boot] [PATCH 8/9] arch/arm/cpu/armv7/omap-common/clocks-common.c: Fix GCC 4.6 warnings

2011-12-05 Thread Tom Rini 
On 12/03/2011 09:46 AM, Anatolij Gustschin wrote:
 Fix:
 clocks-common.c: In function 'setup_dplls':
 clocks-common.c:256:6: warning: variable 'sysclk_ind' set but not used
 [-Wunused-but-set-variable]
 clocks-common.c: In function 'setup_non_essential_dplls':
 clocks-common.c:292:6: warning: variable 'sysclk_ind' set but not used
 [-Wunused-but-set-variable]
 
 Signed-off-by: Anatolij Gustschin ag...@denx.de
 Cc: sricharan r.sricha...@ti.com
 Cc: Tom Rini tr...@ti.com
 ---
  arch/arm/cpu/armv7/omap-common/clocks-common.c |8 +++-
  1 files changed, 3 insertions(+), 5 deletions(-)
 
 diff --git a/arch/arm/cpu/armv7/omap-common/clocks-common.c 
 b/arch/arm/cpu/armv7/omap-common/clocks-common.c
 index 1e7e20e..1da90a4 100644
 --- a/arch/arm/cpu/armv7/omap-common/clocks-common.c
 +++ b/arch/arm/cpu/armv7/omap-common/clocks-common.c
 @@ -253,11 +253,10 @@ void configure_mpu_dpll(void)
  
  static void setup_dplls(void)
  {
 - u32 sysclk_ind, temp;
 + u32 temp;
   const struct dpll_params *params;
 - debug(setup_dplls\n);
  
 - sysclk_ind = get_sys_clk_index();
 + debug(setup_dplls\n);
  
   /* CORE dpll */
   params = get_core_dpll_params();/* default - safest */

Hand-editing the diffs?  Not sure why the debug print looks like it
moved.  But regardless...

Acked-by: Tom Rini tr...@ti.com

And will be queued to u-boot-ti/master once Albert pulls /comments on my
current request.

-- 
Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 8/9] arch/arm/cpu/armv7/omap-common/clocks-common.c: Fix GCC 4.6 warnings

2011-12-05 Thread Anatolij Gustschin 
On Mon, 5 Dec 2011 08:02:53 -0700
Tom Rini tr...@ti.com wrote:

 On 12/03/2011 09:46 AM, Anatolij Gustschin wrote:
  Fix:
  clocks-common.c: In function 'setup_dplls':
  clocks-common.c:256:6: warning: variable 'sysclk_ind' set but not used
  [-Wunused-but-set-variable]
  clocks-common.c: In function 'setup_non_essential_dplls':
  clocks-common.c:292:6: warning: variable 'sysclk_ind' set but not used
  [-Wunused-but-set-variable]
  
  Signed-off-by: Anatolij Gustschin ag...@denx.de
  Cc: sricharan r.sricha...@ti.com
  Cc: Tom Rini tr...@ti.com
  ---
   arch/arm/cpu/armv7/omap-common/clocks-common.c |8 +++-
   1 files changed, 3 insertions(+), 5 deletions(-)
  
  diff --git a/arch/arm/cpu/armv7/omap-common/clocks-common.c 
  b/arch/arm/cpu/armv7/omap-common/clocks-common.c
  index 1e7e20e..1da90a4 100644
  --- a/arch/arm/cpu/armv7/omap-common/clocks-common.c
  +++ b/arch/arm/cpu/armv7/omap-common/clocks-common.c
  @@ -253,11 +253,10 @@ void configure_mpu_dpll(void)
   
   static void setup_dplls(void)
   {
  -   u32 sysclk_ind, temp;
  +   u32 temp;
  const struct dpll_params *params;
  -   debug(setup_dplls\n);
   
  -   sysclk_ind = get_sys_clk_index();
  +   debug(setup_dplls\n);
   
  /* CORE dpll */
  params = get_core_dpll_params();/* default - safest */
 
 Hand-editing the diffs?  Not sure why the debug print looks like it
 moved.  But regardless...

No, not this time. I moved the debug print intentionally to fix the
coding style, while at it. It doesn't make sense to send separate
patch for this coding style fix. I should have mentioned this in the
commit log, sorry.

Thanks for review!

Anatolij
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 8/9] arch/arm/cpu/armv7/omap-common/clocks-common.c: Fix GCC 4.6 warnings

2011-12-05 Thread Tom Rini 
On 12/05/2011 09:32 AM, Anatolij Gustschin wrote:
 On Mon, 5 Dec 2011 08:02:53 -0700
 Tom Rini tr...@ti.com wrote:
 
 On 12/03/2011 09:46 AM, Anatolij Gustschin wrote:
 Fix:
 clocks-common.c: In function 'setup_dplls':
 clocks-common.c:256:6: warning: variable 'sysclk_ind' set but not used
 [-Wunused-but-set-variable]
 clocks-common.c: In function 'setup_non_essential_dplls':
 clocks-common.c:292:6: warning: variable 'sysclk_ind' set but not used
 [-Wunused-but-set-variable]

 Signed-off-by: Anatolij Gustschin ag...@denx.de
 Cc: sricharan r.sricha...@ti.com
 Cc: Tom Rini tr...@ti.com
 ---
  arch/arm/cpu/armv7/omap-common/clocks-common.c |8 +++-
  1 files changed, 3 insertions(+), 5 deletions(-)

 diff --git a/arch/arm/cpu/armv7/omap-common/clocks-common.c 
 b/arch/arm/cpu/armv7/omap-common/clocks-common.c
 index 1e7e20e..1da90a4 100644
 --- a/arch/arm/cpu/armv7/omap-common/clocks-common.c
 +++ b/arch/arm/cpu/armv7/omap-common/clocks-common.c
 @@ -253,11 +253,10 @@ void configure_mpu_dpll(void)
  
  static void setup_dplls(void)
  {
 -   u32 sysclk_ind, temp;
 +   u32 temp;
 const struct dpll_params *params;
 -   debug(setup_dplls\n);
  
 -   sysclk_ind = get_sys_clk_index();
 +   debug(setup_dplls\n);
  
 /* CORE dpll */
 params = get_core_dpll_params();/* default - safest */

 Hand-editing the diffs?  Not sure why the debug print looks like it
 moved.  But regardless...
 
 No, not this time. I moved the debug print intentionally to fix the
 coding style, while at it. It doesn't make sense to send separate
 patch for this coding style fix. I should have mentioned this in the
 commit log, sorry.

Ah, OK, now I see it, thanks (and will still merge as-is).

-- 
Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 8/9] arch/arm/cpu/armv7/omap-common/clocks-common.c: Fix GCC 4.6 warnings

2011-12-04 Thread Marek Vasut 
 Fix:
 clocks-common.c: In function 'setup_dplls':
 clocks-common.c:256:6: warning: variable 'sysclk_ind' set but not used
 [-Wunused-but-set-variable]
 clocks-common.c: In function 'setup_non_essential_dplls':
 clocks-common.c:292:6: warning: variable 'sysclk_ind' set but not used
 [-Wunused-but-set-variable]
 
 Signed-off-by: Anatolij Gustschin ag...@denx.de
 Cc: sricharan r.sricha...@ti.com
 Cc: Tom Rini tr...@ti.com
 ---
  arch/arm/cpu/armv7/omap-common/clocks-common.c |8 +++-
  1 files changed, 3 insertions(+), 5 deletions(-)
 
 diff --git a/arch/arm/cpu/armv7/omap-common/clocks-common.c
 b/arch/arm/cpu/armv7/omap-common/clocks-common.c index 1e7e20e..1da90a4
 100644
 --- a/arch/arm/cpu/armv7/omap-common/clocks-common.c
 +++ b/arch/arm/cpu/armv7/omap-common/clocks-common.c
 @@ -253,11 +253,10 @@ void configure_mpu_dpll(void)
 
  static void setup_dplls(void)
  {
 - u32 sysclk_ind, temp;
 + u32 temp;
   const struct dpll_params *params;
 - debug(setup_dplls\n);
 
 - sysclk_ind = get_sys_clk_index();
 + debug(setup_dplls\n);
 
   /* CORE dpll */
   params = get_core_dpll_params();/* default - safest */
 @@ -289,10 +288,9 @@ static void setup_dplls(void)
  static void setup_non_essential_dplls(void)
  {
   u32 sys_clk_khz, abe_ref_clk;
 - u32 sysclk_ind, sd_div, num, den;
 + u32 sd_div, num, den;
   const struct dpll_params *params;
 
 - sysclk_ind = get_sys_clk_index();
   sys_clk_khz = get_sys_clk_freq() / 1000;
 
   /* IVA */

Acked-by: Marek Vasut marek.va...@gmail.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 8/9] arch/arm/cpu/armv7/omap-common/clocks-common.c: Fix GCC 4.6 warnings

2011-12-03 Thread Anatolij Gustschin 
Fix:
clocks-common.c: In function 'setup_dplls':
clocks-common.c:256:6: warning: variable 'sysclk_ind' set but not used
[-Wunused-but-set-variable]
clocks-common.c: In function 'setup_non_essential_dplls':
clocks-common.c:292:6: warning: variable 'sysclk_ind' set but not used
[-Wunused-but-set-variable]

Signed-off-by: Anatolij Gustschin ag...@denx.de
Cc: sricharan r.sricha...@ti.com
Cc: Tom Rini tr...@ti.com
---
 arch/arm/cpu/armv7/omap-common/clocks-common.c |8 +++-
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/arm/cpu/armv7/omap-common/clocks-common.c 
b/arch/arm/cpu/armv7/omap-common/clocks-common.c
index 1e7e20e..1da90a4 100644
--- a/arch/arm/cpu/armv7/omap-common/clocks-common.c
+++ b/arch/arm/cpu/armv7/omap-common/clocks-common.c
@@ -253,11 +253,10 @@ void configure_mpu_dpll(void)
 
 static void setup_dplls(void)
 {
-   u32 sysclk_ind, temp;
+   u32 temp;
const struct dpll_params *params;
-   debug(setup_dplls\n);
 
-   sysclk_ind = get_sys_clk_index();
+   debug(setup_dplls\n);
 
/* CORE dpll */
params = get_core_dpll_params();/* default - safest */
@@ -289,10 +288,9 @@ static void setup_dplls(void)
 static void setup_non_essential_dplls(void)
 {
u32 sys_clk_khz, abe_ref_clk;
-   u32 sysclk_ind, sd_div, num, den;
+   u32 sd_div, num, den;
const struct dpll_params *params;
 
-   sysclk_ind = get_sys_clk_index();
sys_clk_khz = get_sys_clk_freq() / 1000;
 
/* IVA */
-- 
1.7.6.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot