Re: [U-Boot] [PATCH 9/9] x86: ivybridge: Enable the MRC cache

[Simon Glass]

On 18 October 2015 at 20:23, Bin Meng  wrote:
> On Mon, Oct 19, 2015 at 5:55 AM, Simon Glass  wrote:
>> From: Bin Meng 
>>
>> This works correctly now, so enable it.
>>
>> Signed-off-by: Bin Meng 
>> Dropped malloc() and adjusted commit message:
>> Signed-off-by: Simon Glass 
>>
>> ---
>>
>>  arch/x86/cpu/ivybridge/sdram.c | 10 ++
>>  1 file changed, 2 insertions(+), 8 deletions(-)
>>

[snip]
>
> Reviewed-by: Bin Meng 

Applied to u-boot-x86.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 9/9] x86: ivybridge: Enable the MRC cache

[Bin Meng]

On Mon, Oct 19, 2015 at 5:55 AM, Simon Glass  wrote:
> From: Bin Meng 
>
> This works correctly now, so enable it.
>
> Signed-off-by: Bin Meng 
> Dropped malloc() and adjusted commit message:
> Signed-off-by: Simon Glass 
>
> ---
>
>  arch/x86/cpu/ivybridge/sdram.c | 10 ++
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/arch/x86/cpu/ivybridge/sdram.c b/arch/x86/cpu/ivybridge/sdram.c
> index d9b3dfc..4372a5c 100644
> --- a/arch/x86/cpu/ivybridge/sdram.c
> +++ b/arch/x86/cpu/ivybridge/sdram.c
> @@ -158,14 +158,8 @@ static int prepare_mrc_cache(struct pei_data *pei_data)
> if (!mrc_cache)
> return -ENOENT;
>
> -   /*
> -* TODO(s...@chromium.org): Skip this for now as it causes boot
> -* problems
> -*/
> -   if (0) {
> -   pei_data->mrc_input = mrc_cache->data;
> -   pei_data->mrc_input_len = mrc_cache->data_size;
> -   }
> +   pei_data->mrc_input = mrc_cache->data;
> +   pei_data->mrc_input_len = mrc_cache->data_size;
> debug("%s: at %p, size %x checksum %04x\n", __func__,
>   pei_data->mrc_input, pei_data->mrc_input_len,
>   mrc_cache->checksum);
> --

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH 9/9] x86: ivybridge: Enable the MRC cache

[Simon Glass]

From: Bin Meng 

This works correctly now, so enable it.

Signed-off-by: Bin Meng 
Dropped malloc() and adjusted commit message:
Signed-off-by: Simon Glass 

---

 arch/x86/cpu/ivybridge/sdram.c | 10 ++
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/arch/x86/cpu/ivybridge/sdram.c b/arch/x86/cpu/ivybridge/sdram.c
index d9b3dfc..4372a5c 100644
--- a/arch/x86/cpu/ivybridge/sdram.c
+++ b/arch/x86/cpu/ivybridge/sdram.c
@@ -158,14 +158,8 @@ static int prepare_mrc_cache(struct pei_data *pei_data)
if (!mrc_cache)
return -ENOENT;
 
-   /*
-* TODO(s...@chromium.org): Skip this for now as it causes boot
-* problems
-*/
-   if (0) {
-   pei_data->mrc_input = mrc_cache->data;
-   pei_data->mrc_input_len = mrc_cache->data_size;
-   }
+   pei_data->mrc_input = mrc_cache->data;
+   pei_data->mrc_input_len = mrc_cache->data_size;
debug("%s: at %p, size %x checksum %04x\n", __func__,
  pei_data->mrc_input, pei_data->mrc_input_len,
  mrc_cache->checksum);
-- 
2.6.0.rc2.230.g3dd15c0

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot