Re: [U-Boot] [PATCH REPOST] usb: create common header virtual root hub descriptors
Hello Stephen, Sorry for the delay, I wasn't connected during 2 weeks. I can't comment your patch because I no longer have an MPC5200-based board. Best regards Le 21/02/2014 05:19, Stephen Warren a écrit : On 02/13/2014 09:15 PM, Stephen Warren wrote: Many USB host controller drivers contain almost identical copies of the same virtual root hub descriptors. Put these into a common file to avoid duplication. Note that there were some very minor differences between the descriptors in the various files, such as: - USB 1.0 vs. USB 1.1 - Manufacturer/Device ID - Max packet size - String content I assume these aren't relevant. Marek, how long do you think we should wait for acks/naks from the CC'd people? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH REPOST] usb: create common header virtual root hub descriptors
On Friday, February 21, 2014 at 05:19:12 AM, Stephen Warren wrote: On 02/13/2014 09:15 PM, Stephen Warren wrote: Many USB host controller drivers contain almost identical copies of the same virtual root hub descriptors. Put these into a common file to avoid duplication. Note that there were some very minor differences between the descriptors in the various files, such as: - USB 1.0 vs. USB 1.1 - Manufacturer/Device ID - Max packet size - String content I assume these aren't relevant. Marek, how long do you think we should wait for acks/naks from the CC'd people? Well, I'm picking this up now. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH REPOST] usb: create common header virtual root hub descriptors
On Thu, Feb 20, 2014 at 8:19 PM, Stephen Warren swar...@wwwdotorg.org wrote: On 02/13/2014 09:15 PM, Stephen Warren wrote: Many USB host controller drivers contain almost identical copies of the same virtual root hub descriptors. Put these into a common file to avoid duplication. Note that there were some very minor differences between the descriptors in the various files, such as: - USB 1.0 vs. USB 1.1 - Manufacturer/Device ID - Max packet size - String content I assume these aren't relevant. Marek, how long do you think we should wait for acks/naks from the CC'd people? Stephen, I guess I'm not the right person to Ack/Nak this patch now, since I haven't played this for a long time. Also it's the same for Cliff Cai and his email is dead. Thanks, -Bryan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH REPOST] usb: create common header virtual root hub descriptors
On 02/13/2014 09:15 PM, Stephen Warren wrote: Many USB host controller drivers contain almost identical copies of the same virtual root hub descriptors. Put these into a common file to avoid duplication. Note that there were some very minor differences between the descriptors in the various files, such as: - USB 1.0 vs. USB 1.1 - Manufacturer/Device ID - Max packet size - String content I assume these aren't relevant. Marek, how long do you think we should wait for acks/naks from the CC'd people? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH REPOST] usb: create common header virtual root hub descriptors
On 14.02.2014 05:15, Stephen Warren wrote: Many USB host controller drivers contain almost identical copies of the same virtual root hub descriptors. Put these into a common file to avoid duplication. Note that there were some very minor differences between the descriptors in the various files, such as: - USB 1.0 vs. USB 1.1 - Manufacturer/Device ID - Max packet size - String content I assume these aren't relevant. Cc: Thomas Lange tho...@corelatus.se Cc: Shinya Kuribayashi skuri...@pobox.com Cc: Gary Jennejohn ga...@denx.de Cc: Wolfgang Denk w...@denx.de Cc: Eric Millbrandt emillbra...@coldhaus.com Cc: Pierre Aubert p.aub...@staubli.com Cc: Stefan Roese s...@denx.de Cc: Daniel Hellstrom dan...@gaisler.com Cc: Denis Peter d.pe...@mpl.ch Cc: Rodolfo Giometti giome...@linux.it Cc: Zhang Wei wei.zh...@freescale.com Cc: Mateusz Zalega m.zal...@samsung.com Cc: Remy Bohmer li...@bohmer.net Cc: Markus Klotzbuecher m...@denx.de Cc: Minkyu Kang mk7.k...@samsung.com Cc: Gary Jennejohn ga...@denx.de Cc: C Nauman cnau...@diagraph.com Cc: David Müller d.muel...@elsoft.ch Cc: Yoshihiro Shimoda shimoda.yoshih...@renesas.com Cc: Nobuhiro Iwamatsu iwama...@nigauri.org Cc: Thomas Abraham t-abra...@ti.com Cc: Tom Rini tr...@ti.com Cc: Andrew Murray amur...@embedded-bits.co.uk Cc: Matej Frančeškin matej.frances...@comtrade.com Cc: Cliff Cai cliff@analog.com Cc: Bryan Wu coolo...@gmail.com Signed-off-by: Stephen Warren swar...@wwwdotorg.org --- Repost: Marek asked me to resend this Cc to the maintainers of the various edited files. If you're CC'd, could you please check that the minor differences in the descriptor content between the new header and your driver isn't going to be an issue. It's pretty unclear who the maintainer is for many of the files, so I've had to cast a fairly wide net... Looks good for ppc4xx, so: Acked-by: Stefan Roese s...@denx.de Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
