Re: [U-Boot] [PATCH V2] arm: Tegra: Fix Harmony and Ventana builds in u-boot-tegra/master

2011-12-21 Thread Wolfgang Denk
Dear Tom Warren,

In message 1324414465-7999-1-git-send-email-twar...@nvidia.com you wrote:
 Seaboard changes have removed the need for common/board.o in the
 Makefile. Propagate this change to the other Tegra2 builds.
 
 Signed-off-by: Tom Warren twar...@nvidia.com
 ---
 V2: Add more info to commit msg about use/source of change
 
  board/nvidia/harmony/Makefile |1 -
  board/nvidia/ventana/Makefile |3 +--
  include/configs/ventana.h |3 +++
  3 files changed, 4 insertions(+), 3 deletions(-)

This patch breaks building for the harmony board:

Configuring for harmony board...
arch/arm/cpu/armv7/tegra2/libtegra2.o: In function `checkboard':
/home/wd/git/u-boot/work/arch/arm/cpu/armv7/tegra2/board.c:70: undefined 
reference to `sysinfo'
arch/arm/lib/libarm.o: In function `board_init_r':
/home/wd/git/u-boot/work/arch/arm/lib/board.c:465: undefined reference to 
`board_init'
arch/arm/lib/libarm.o:(.data+0x4): undefined reference to `board_early_init_f'
arch/arm/lib/libarm.o:(.data+0x8): undefined reference to `timer_init'


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Zero is an enigmatic value. It can mean success (fclose)  or  failure
(scanf).  It  can  mean  black  or  white. It can mean no permissions
(chmod) or all permissions (umask). It can mean now (setjmp) or later
(atexit). It can mean the beginning (lseek) or the end (read). It can
mean myself (getpgrp) or child (fork). It can mean  all  (kill's  1st
argument)  or  nothing  (kill's  2nd argument). It can mean `default'
(SIG_IGN) or `I don't care' (waitpid) or  `try  to  guess'  (strtol).
Indeed 0 lets you talk to God (setuid).
Verily is 0 all things to all people.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH V2] arm: Tegra: Fix Harmony and Ventana builds in u-boot-tegra/master

2011-12-20 Thread Tom Warren
Seaboard changes have removed the need for common/board.o in the
Makefile. Propagate this change to the other Tegra2 builds.

Signed-off-by: Tom Warren twar...@nvidia.com
---
V2: Add more info to commit msg about use/source of change

 board/nvidia/harmony/Makefile |1 -
 board/nvidia/ventana/Makefile |3 +--
 include/configs/ventana.h |3 +++
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/board/nvidia/harmony/Makefile b/board/nvidia/harmony/Makefile
index f6599de..b6efa1c 100644
--- a/board/nvidia/harmony/Makefile
+++ b/board/nvidia/harmony/Makefile
@@ -31,7 +31,6 @@ endif
 LIB= $(obj)lib$(BOARD).o
 
 COBJS  := $(BOARD).o
-COBJS  += ../common/board.o
 
 SRCS   := $(COBJS:.o=.c)
 OBJS   := $(addprefix $(obj),$(COBJS))
diff --git a/board/nvidia/ventana/Makefile b/board/nvidia/ventana/Makefile
index 9e5a87f..b4ab79a 100644
--- a/board/nvidia/ventana/Makefile
+++ b/board/nvidia/ventana/Makefile
@@ -30,8 +30,7 @@ endif
 
 LIB= $(obj)lib$(BOARD).o
 
-COBJS  += ../seaboard/seaboard.o
-COBJS  += ../common/board.o
+COBJS  = ../seaboard/seaboard.o
 
 SRCS   := $(COBJS:.o=.c)
 OBJS   := $(addprefix $(obj),$(COBJS))
diff --git a/include/configs/ventana.h b/include/configs/ventana.h
index afd6ff6..acc9b43 100644
--- a/include/configs/ventana.h
+++ b/include/configs/ventana.h
@@ -52,4 +52,7 @@
 #define CONFIG_EFI_PARTITION
 #define CONFIG_CMD_EXT2
 #define CONFIG_CMD_FAT
+
+/* Environment not stored */
+#define CONFIG_ENV_IS_NOWHERE
 #endif /* __CONFIG_H */
-- 
1.7.7.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH V2] arm: Tegra: Fix Harmony and Ventana builds in u-boot-tegra/master

2011-12-20 Thread Stephen Warren
Tom Warren wrote at Tuesday, December 20, 2011 1:54 PM:
 Seaboard changes have removed the need for common/board.o in the
 Makefile. Propagate this change to the other Tegra2 builds.
 
 Signed-off-by: Tom Warren twar...@nvidia.com

Acked-by: Stephen Warren swar...@nvidia.com
Tested-by: Stephen Warren swar...@nvidia.com

-- 
nvpublic

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot