Re: [U-Boot] [PATCH V5 1/2] GPIO: Tegra2: add GPIO driver for Tegra2

2011-06-26 Thread Albert ARIBAUD
Hi Tom,

Le 24/06/2011 19:58, Tom Warren a écrit :
> On Fri, Jun 17, 2011 at 9:27 AM, Tom Warren  wrote:
>> Signed-off-by: Tom Warren
>> ---
>> Changes in V2:
>> - use 'gpio_pin' enum in gpio.h (Simon Glass review request)
>> - change 'GPIO_PORT8' to 'GPIO_FULLPORT' (Simon Glass request)
>> - change 'offset' to 'pin' globally
>> Changes in V3:
>> - use common cmd_gpio; remove redundant cmd processing code
>> - add gpio_request, gpio_free and gpio_toggle
>> - alias 'gpio_status' to 'gpio_info' for use in cmd_gpio
>> Changes in V4:
>> - update code as per Mike Frysinger's review comments
>> - rewrite gpio_info, aka gpio_status
>> Changes in V5:
>> - NUL-terminate the name string in gpio_request
>>
>>   arch/arm/include/asm/arch-tegra2/gpio.h |  250 
>> +--
>>   arch/arm/include/asm/gpio.h |   38 +
>>   drivers/gpio/Makefile   |1 +
>>   drivers/gpio/tegra2_gpio.c  |  255 
>> +++
>>   4 files changed, 534 insertions(+), 10 deletions(-)
>>   create mode 100644 arch/arm/include/asm/gpio.h
>>   create mode 100644 drivers/gpio/tegra2_gpio.c
>>
> 
> Has this patch been accepted? or is there anymore feedback?
>
> Mike gave it an 'otherwise, looks fine' prior to the ASCIIZ fix in V5.

Seems like no other comments have been made, so:

Applied to u-boot-arm/next, to be moved to master after 2011-06 release.

> Thanks,
>
> Tom

Amicalement,
-- 
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH V5 1/2] GPIO: Tegra2: add GPIO driver for Tegra2

2011-06-24 Thread Tom Warren
On Fri, Jun 17, 2011 at 9:27 AM, Tom Warren  wrote:
> Signed-off-by: Tom Warren 
> ---
> Changes in V2:
>        - use 'gpio_pin' enum in gpio.h (Simon Glass review request)
>        - change 'GPIO_PORT8' to 'GPIO_FULLPORT' (Simon Glass request)
>        - change 'offset' to 'pin' globally
> Changes in V3:
>        - use common cmd_gpio; remove redundant cmd processing code
>        - add gpio_request, gpio_free and gpio_toggle
>        - alias 'gpio_status' to 'gpio_info' for use in cmd_gpio
> Changes in V4:
>        - update code as per Mike Frysinger's review comments
>        - rewrite gpio_info, aka gpio_status
> Changes in V5:
>        - NUL-terminate the name string in gpio_request
>
>  arch/arm/include/asm/arch-tegra2/gpio.h |  250 
> +--
>  arch/arm/include/asm/gpio.h             |   38 +
>  drivers/gpio/Makefile                   |    1 +
>  drivers/gpio/tegra2_gpio.c              |  255 
> +++
>  4 files changed, 534 insertions(+), 10 deletions(-)
>  create mode 100644 arch/arm/include/asm/gpio.h
>  create mode 100644 drivers/gpio/tegra2_gpio.c
>

Has this patch been accepted? or is there anymore feedback?

Mike gave it an 'otherwise, looks fine' prior to the ASCIIZ fix in V5.

Thanks,

Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH V5 1/2] GPIO: Tegra2: add GPIO driver for Tegra2

2011-06-17 Thread Tom Warren
Signed-off-by: Tom Warren 
---
Changes in V2:
- use 'gpio_pin' enum in gpio.h (Simon Glass review request)
- change 'GPIO_PORT8' to 'GPIO_FULLPORT' (Simon Glass request)
- change 'offset' to 'pin' globally
Changes in V3:
- use common cmd_gpio; remove redundant cmd processing code
- add gpio_request, gpio_free and gpio_toggle
- alias 'gpio_status' to 'gpio_info' for use in cmd_gpio
Changes in V4:
- update code as per Mike Frysinger's review comments
- rewrite gpio_info, aka gpio_status
Changes in V5:
- NUL-terminate the name string in gpio_request

 arch/arm/include/asm/arch-tegra2/gpio.h |  250 +--
 arch/arm/include/asm/gpio.h |   38 +
 drivers/gpio/Makefile   |1 +
 drivers/gpio/tegra2_gpio.c  |  255 +++
 4 files changed, 534 insertions(+), 10 deletions(-)
 create mode 100644 arch/arm/include/asm/gpio.h
 create mode 100644 drivers/gpio/tegra2_gpio.c

diff --git a/arch/arm/include/asm/arch-tegra2/gpio.h 
b/arch/arm/include/asm/arch-tegra2/gpio.h
index 0fb8f0d..41e66fe 100644
--- a/arch/arm/include/asm/arch-tegra2/gpio.h
+++ b/arch/arm/include/asm/arch-tegra2/gpio.h
@@ -23,11 +23,13 @@
 #define _TEGRA2_GPIO_H_
 
 /*
- * The Tegra 2x GPIO controller has 222 GPIOs arranged in 8 banks of 4 ports,
+ * The Tegra 2x GPIO controller has 224 GPIOs arranged in 7 banks of 4 ports,
  * each with 8 GPIOs.
  */
-#define TEGRA_GPIO_PORTS 4   /* The number of ports per bank */
-#define TEGRA_GPIO_BANKS 8   /* The number of banks */
+#define TEGRA_GPIO_PORTS   4   /* number of ports per bank */
+#define TEGRA_GPIO_BANKS   7   /* number of banks */
+#define MAX_NUM_GPIOS  (TEGRA_GPIO_PORTS * TEGRA_GPIO_BANKS * 8)
+#define GPIO_NAME_SIZE 20  /* gpio_request max label len */
 
 /* GPIO Controller registers for a single bank */
 struct gpio_ctlr_bank {
@@ -45,15 +47,243 @@ struct gpio_ctlr {
struct gpio_ctlr_bank gpio_bank[TEGRA_GPIO_BANKS];
 };
 
-#define GPIO_BANK(x)   ((x) >> 5)
-#define GPIO_PORT(x)   (((x) >> 3) & 0x3)
-#define GPIO_BIT(x)((x) & 0x7)
+#define GPIO_BANK(x)   ((x) >> 5)
+#define GPIO_PORT(x)   (((x) >> 3) & 0x3)
+#define GPIO_FULLPORT(x)   ((x) >> 3)
+#define GPIO_BIT(x)((x) & 0x7)
+
+enum gpio_pin {
+   GPIO_PA0 = 0,   /* pin 0 */
+   GPIO_PA1,
+   GPIO_PA2,
+   GPIO_PA3,
+   GPIO_PA4,
+   GPIO_PA5,
+   GPIO_PA6,
+   GPIO_PA7,
+   GPIO_PB0,   /* pin 8 */
+   GPIO_PB1,
+   GPIO_PB2,
+   GPIO_PB3,
+   GPIO_PB4,
+   GPIO_PB5,
+   GPIO_PB6,
+   GPIO_PB7,
+   GPIO_PC0,   /* pin 16 */
+   GPIO_PC1,
+   GPIO_PC2,
+   GPIO_PC3,
+   GPIO_PC4,
+   GPIO_PC5,
+   GPIO_PC6,
+   GPIO_PC7,
+   GPIO_PD0,   /* pin 24 */
+   GPIO_PD1,
+   GPIO_PD2,
+   GPIO_PD3,
+   GPIO_PD4,
+   GPIO_PD5,
+   GPIO_PD6,
+   GPIO_PD7,
+   GPIO_PE0,   /* pin 32 */
+   GPIO_PE1,
+   GPIO_PE2,
+   GPIO_PE3,
+   GPIO_PE4,
+   GPIO_PE5,
+   GPIO_PE6,
+   GPIO_PE7,
+   GPIO_PF0,   /* pin 40 */
+   GPIO_PF1,
+   GPIO_PF2,
+   GPIO_PF3,
+   GPIO_PF4,
+   GPIO_PF5,
+   GPIO_PF6,
+   GPIO_PF7,
+   GPIO_PG0,   /* pin 48 */
+   GPIO_PG1,
+   GPIO_PG2,
+   GPIO_PG3,
+   GPIO_PG4,
+   GPIO_PG5,
+   GPIO_PG6,
+   GPIO_PG7,
+   GPIO_PH0,   /* pin 56 */
+   GPIO_PH1,
+   GPIO_PH2,
+   GPIO_PH3,
+   GPIO_PH4,
+   GPIO_PH5,
+   GPIO_PH6,
+   GPIO_PH7,
+   GPIO_PI0,   /* pin 64 */
+   GPIO_PI1,
+   GPIO_PI2,
+   GPIO_PI3,
+   GPIO_PI4,
+   GPIO_PI5,
+   GPIO_PI6,
+   GPIO_PI7,
+   GPIO_PJ0,   /* pin 72 */
+   GPIO_PJ1,
+   GPIO_PJ2,
+   GPIO_PJ3,
+   GPIO_PJ4,
+   GPIO_PJ5,
+   GPIO_PJ6,
+   GPIO_PJ7,
+   GPIO_PK0,   /* pin 80 */
+   GPIO_PK1,
+   GPIO_PK2,
+   GPIO_PK3,
+   GPIO_PK4,
+   GPIO_PK5,
+   GPIO_PK6,
+   GPIO_PK7,
+   GPIO_PL0,   /* pin 88 */
+   GPIO_PL1,
+   GPIO_PL2,
+   GPIO_PL3,
+   GPIO_PL4,
+   GPIO_PL5,
+   GPIO_PL6,
+   GPIO_PL7,
+   GPIO_PM0,   /* pin 96 */
+   GPIO_PM1,
+   GPIO_PM2,
+   GPIO_PM3,
+   GPIO_PM4,
+   GPIO_PM5,
+   GPIO_PM6,
+   GPIO_PM7,
+   GPIO_PN0,   /* pin 104 */
+   GPIO_PN1,
+   GPIO_PN2,
+   GPIO_PN3,
+   GPIO_PN4,
+   GPIO_PN5,
+   GPIO_PN6,
+   GPIO_PN7,
+   GPIO_PO0,   /* pin 112 */
+   GPIO_PO1,
+   GPIO_PO2,
+   GPIO_PO3,
+   GPIO_PO4,
+   GPIO_PO5,
+   GPIO_PO6,
+   GPIO_PO7,
+   GPIO_PP0,   /* pin 120 */
+   GPIO_PP1,
+   GPIO_PP2,
+   GPIO_PP3,
+   GPIO_PP4,
+   GPIO_PP5,
+   GPIO_PP6,
+   GPIO_PP7