Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
On Thu, Sep 13, 2012 at 07:29:08AM -0700, Tom Rini wrote: On 09/13/2012 02:20 AM, Marek Vasut wrote: Dear Tom Rini, On 09/12/2012 03:57 PM, Rob Herring wrote: On 09/12/2012 05:49 PM, Tom Rini wrote: On Mon, Aug 13, 2012 at 01:28:19PM -0500, Rob Herring wrote: On 08/13/2012 06:52 AM, Wolfgang Denk wrote: Dear Rob Herring, In message 50244d5a.3080...@gmail.com you wrote: I reported already that the prior version that ext4 has issues with sub-directories. I don't think that has been addressed in V5. Some directories show up fine and some don't. So it's kind of random whether u-boot can read a /boot directory. This was after full ubuntu installs. I'd guess a simple test with a couple of files and directories will not show the problem. We really need a test case here. In my (certainly not very extensive) tests I didn't see such a problem. Can you please describe what failed for you? I do an ubuntu install to a single ext4 fs and then ext2ls gives this: [snip] The problem is in the directories with sizes of 0. It does seem to be directories with higher blkno's. Perhaps the lack of support for hash table directory entries is a problem. Just guessing here as I don't know much about ext4 structure. I haven't been able to produce a simple example just creating a bunch of files and directories, so only the disk after an ubuntu install has the problem. I took an Ubuntu install I had (for x86) that was on a USB drive, had been pretty extensively used, and was is ext4. I couldn't find any size 0 directories. Are you able to reproduce this problem on other hardware? Is the image in question NOT remountable as ext3 (extents is set, generated) ? My biggest concern is breakage among ext2/3 filesystems. Thanks! What size partition? It is also fine for me with a small 1.2GB partition. I only see the problem with larger partitions (most of a 250GB drive). This is a 240G partition. I was under the impression that ext4 is not mountable as ext3. You can go ext3-ext4-ext3, it's only when you have fsck rebuild and make use of extents, iirc, that it's no longer mountable as ext3. Maybe you can pick that loop block driver from Pavel [1] and try it on sandbox target? That might ease testing etc. Only if Rob's image (which iirc is hooked up to a qemu target) still fails once attached that way. Rob, am I (a) remembering right that you see this on a qemu target and (b) if so does compressing the crap out of it yield a small enough file to put on dropbox or some other free cloud storage? Thanks! Folks? Thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
Dear Tom Rini, On 09/12/2012 03:57 PM, Rob Herring wrote: On 09/12/2012 05:49 PM, Tom Rini wrote: On Mon, Aug 13, 2012 at 01:28:19PM -0500, Rob Herring wrote: On 08/13/2012 06:52 AM, Wolfgang Denk wrote: Dear Rob Herring, In message 50244d5a.3080...@gmail.com you wrote: I reported already that the prior version that ext4 has issues with sub-directories. I don't think that has been addressed in V5. Some directories show up fine and some don't. So it's kind of random whether u-boot can read a /boot directory. This was after full ubuntu installs. I'd guess a simple test with a couple of files and directories will not show the problem. We really need a test case here. In my (certainly not very extensive) tests I didn't see such a problem. Can you please describe what failed for you? I do an ubuntu install to a single ext4 fs and then ext2ls gives this: [snip] The problem is in the directories with sizes of 0. It does seem to be directories with higher blkno's. Perhaps the lack of support for hash table directory entries is a problem. Just guessing here as I don't know much about ext4 structure. I haven't been able to produce a simple example just creating a bunch of files and directories, so only the disk after an ubuntu install has the problem. I took an Ubuntu install I had (for x86) that was on a USB drive, had been pretty extensively used, and was is ext4. I couldn't find any size 0 directories. Are you able to reproduce this problem on other hardware? Is the image in question NOT remountable as ext3 (extents is set, generated) ? My biggest concern is breakage among ext2/3 filesystems. Thanks! What size partition? It is also fine for me with a small 1.2GB partition. I only see the problem with larger partitions (most of a 250GB drive). This is a 240G partition. I was under the impression that ext4 is not mountable as ext3. You can go ext3-ext4-ext3, it's only when you have fsck rebuild and make use of extents, iirc, that it's no longer mountable as ext3. Maybe you can pick that loop block driver from Pavel [1] and try it on sandbox target? That might ease testing etc. [1] http://patchwork.ozlabs.org/patch/182160/ Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
On 09/13/2012 02:20 AM, Marek Vasut wrote: Dear Tom Rini, On 09/12/2012 03:57 PM, Rob Herring wrote: On 09/12/2012 05:49 PM, Tom Rini wrote: On Mon, Aug 13, 2012 at 01:28:19PM -0500, Rob Herring wrote: On 08/13/2012 06:52 AM, Wolfgang Denk wrote: Dear Rob Herring, In message 50244d5a.3080...@gmail.com you wrote: I reported already that the prior version that ext4 has issues with sub-directories. I don't think that has been addressed in V5. Some directories show up fine and some don't. So it's kind of random whether u-boot can read a /boot directory. This was after full ubuntu installs. I'd guess a simple test with a couple of files and directories will not show the problem. We really need a test case here. In my (certainly not very extensive) tests I didn't see such a problem. Can you please describe what failed for you? I do an ubuntu install to a single ext4 fs and then ext2ls gives this: [snip] The problem is in the directories with sizes of 0. It does seem to be directories with higher blkno's. Perhaps the lack of support for hash table directory entries is a problem. Just guessing here as I don't know much about ext4 structure. I haven't been able to produce a simple example just creating a bunch of files and directories, so only the disk after an ubuntu install has the problem. I took an Ubuntu install I had (for x86) that was on a USB drive, had been pretty extensively used, and was is ext4. I couldn't find any size 0 directories. Are you able to reproduce this problem on other hardware? Is the image in question NOT remountable as ext3 (extents is set, generated) ? My biggest concern is breakage among ext2/3 filesystems. Thanks! What size partition? It is also fine for me with a small 1.2GB partition. I only see the problem with larger partitions (most of a 250GB drive). This is a 240G partition. I was under the impression that ext4 is not mountable as ext3. You can go ext3-ext4-ext3, it's only when you have fsck rebuild and make use of extents, iirc, that it's no longer mountable as ext3. Maybe you can pick that loop block driver from Pavel [1] and try it on sandbox target? That might ease testing etc. Only if Rob's image (which iirc is hooked up to a qemu target) still fails once attached that way. Rob, am I (a) remembering right that you see this on a qemu target and (b) if so does compressing the crap out of it yield a small enough file to put on dropbox or some other free cloud storage? Thanks! -- Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
On Mon, Aug 13, 2012 at 01:28:19PM -0500, Rob Herring wrote: On 08/13/2012 06:52 AM, Wolfgang Denk wrote: Dear Rob Herring, In message 50244d5a.3080...@gmail.com you wrote: I reported already that the prior version that ext4 has issues with sub-directories. I don't think that has been addressed in V5. Some directories show up fine and some don't. So it's kind of random whether u-boot can read a /boot directory. This was after full ubuntu installs. I'd guess a simple test with a couple of files and directories will not show the problem. We really need a test case here. In my (certainly not very extensive) tests I didn't see such a problem. Can you please describe what failed for you? I do an ubuntu install to a single ext4 fs and then ext2ls gives this: [snip] The problem is in the directories with sizes of 0. It does seem to be directories with higher blkno's. Perhaps the lack of support for hash table directory entries is a problem. Just guessing here as I don't know much about ext4 structure. I haven't been able to produce a simple example just creating a bunch of files and directories, so only the disk after an ubuntu install has the problem. I took an Ubuntu install I had (for x86) that was on a USB drive, had been pretty extensively used, and was is ext4. I couldn't find any size 0 directories. Are you able to reproduce this problem on other hardware? Is the image in question NOT remountable as ext3 (extents is set, generated) ? My biggest concern is breakage among ext2/3 filesystems. Thanks! -- Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
On 09/12/2012 05:49 PM, Tom Rini wrote: On Mon, Aug 13, 2012 at 01:28:19PM -0500, Rob Herring wrote: On 08/13/2012 06:52 AM, Wolfgang Denk wrote: Dear Rob Herring, In message 50244d5a.3080...@gmail.com you wrote: I reported already that the prior version that ext4 has issues with sub-directories. I don't think that has been addressed in V5. Some directories show up fine and some don't. So it's kind of random whether u-boot can read a /boot directory. This was after full ubuntu installs. I'd guess a simple test with a couple of files and directories will not show the problem. We really need a test case here. In my (certainly not very extensive) tests I didn't see such a problem. Can you please describe what failed for you? I do an ubuntu install to a single ext4 fs and then ext2ls gives this: [snip] The problem is in the directories with sizes of 0. It does seem to be directories with higher blkno's. Perhaps the lack of support for hash table directory entries is a problem. Just guessing here as I don't know much about ext4 structure. I haven't been able to produce a simple example just creating a bunch of files and directories, so only the disk after an ubuntu install has the problem. I took an Ubuntu install I had (for x86) that was on a USB drive, had been pretty extensively used, and was is ext4. I couldn't find any size 0 directories. Are you able to reproduce this problem on other hardware? Is the image in question NOT remountable as ext3 (extents is set, generated) ? My biggest concern is breakage among ext2/3 filesystems. Thanks! What size partition? It is also fine for me with a small 1.2GB partition. I only see the problem with larger partitions (most of a 250GB drive). I was under the impression that ext4 is not mountable as ext3. Rob ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
On 09/12/2012 03:57 PM, Rob Herring wrote: On 09/12/2012 05:49 PM, Tom Rini wrote: On Mon, Aug 13, 2012 at 01:28:19PM -0500, Rob Herring wrote: On 08/13/2012 06:52 AM, Wolfgang Denk wrote: Dear Rob Herring, In message 50244d5a.3080...@gmail.com you wrote: I reported already that the prior version that ext4 has issues with sub-directories. I don't think that has been addressed in V5. Some directories show up fine and some don't. So it's kind of random whether u-boot can read a /boot directory. This was after full ubuntu installs. I'd guess a simple test with a couple of files and directories will not show the problem. We really need a test case here. In my (certainly not very extensive) tests I didn't see such a problem. Can you please describe what failed for you? I do an ubuntu install to a single ext4 fs and then ext2ls gives this: [snip] The problem is in the directories with sizes of 0. It does seem to be directories with higher blkno's. Perhaps the lack of support for hash table directory entries is a problem. Just guessing here as I don't know much about ext4 structure. I haven't been able to produce a simple example just creating a bunch of files and directories, so only the disk after an ubuntu install has the problem. I took an Ubuntu install I had (for x86) that was on a USB drive, had been pretty extensively used, and was is ext4. I couldn't find any size 0 directories. Are you able to reproduce this problem on other hardware? Is the image in question NOT remountable as ext3 (extents is set, generated) ? My biggest concern is breakage among ext2/3 filesystems. Thanks! What size partition? It is also fine for me with a small 1.2GB partition. I only see the problem with larger partitions (most of a 250GB drive). This is a 240G partition. I was under the impression that ext4 is not mountable as ext3. You can go ext3-ext4-ext3, it's only when you have fsck rebuild and make use of extents, iirc, that it's no longer mountable as ext3. -- Tom ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
Dear Rob Herring, In message 502963fc.70...@gmail.com you wrote: Can you upload the image somewhere? And indicate which exact problems we should look for? Yes, I'll have to recreate one with a reasonable size. Did you manage to find time to create an image that couldbe used for testing this issue? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de How much net work could a network work, if a network could net work? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
Dear Wolfgang Denk, Dear Rob Herring, In message 502963fc.70...@gmail.com you wrote: Can you upload the image somewhere? And indicate which exact problems we should look for? Yes, I'll have to recreate one with a reasonable size. Did you manage to find time to create an image that couldbe used for testing this issue? Pavel is implementing block device support for sandbox ... I hope we can eventually use that to test. Best regards, Wolfgang Denk Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
On 09/02/2012 06:36 AM, Wolfgang Denk wrote: Dear Rob Herring, In message 502963fc.70...@gmail.com you wrote: Can you upload the image somewhere? And indicate which exact problems we should look for? Yes, I'll have to recreate one with a reasonable size. Did you manage to find time to create an image that couldbe used for testing this issue? I tried, but unfortunately with a smaller partition it all works fine. So a 1.2GB partition was fine and a ~250GB partition was not. I'm not sure where the breaking point is. Perhaps just taking a hard disk with an x86 install to ext4 fs would be enough to test this. Doing this using highbank qemu model and the disk image being my laptop's drive, I don't see 0 length directories, but I do see other issues reading some directories: Highbank #ext2ls scsi 0:1 /usr/ DIR 4096 . DIR 4096 .. DIR 69632 bin DIR 4096 games DIR 20480 include DIR 36864 lib DIR 4096 local DIR 12288 sbin DIR 12288 share DIR 4096 src DIR 4096 x86_64-linux-gnu DIR 4096 arm-linux-gnueabihf DIR 4096 arm-linux-gnueabi Highbank #ext2ls scsi 0:1 /usr/bin invalid extent block I would say go ahead and merge this. It's at least usable for smaller /boot type partitions and may not show up on SD and MMC cards. Rob ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
Dear Rob Herring, In message 50244d5a.3080...@gmail.com you wrote: I reported already that the prior version that ext4 has issues with sub-directories. I don't think that has been addressed in V5. Some directories show up fine and some don't. So it's kind of random whether u-boot can read a /boot directory. This was after full ubuntu installs. I'd guess a simple test with a couple of files and directories will not show the problem. We really need a test case here. In my (certainly not very extensive) tests I didn't see such a problem. Can you please describe what failed for you? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Either one of us, by himself, is expendable. Both of us are not. -- Kirk, The Devil in the Dark, stardate 3196.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
On 08/13/2012 06:52 AM, Wolfgang Denk wrote: Dear Rob Herring, In message 50244d5a.3080...@gmail.com you wrote: I reported already that the prior version that ext4 has issues with sub-directories. I don't think that has been addressed in V5. Some directories show up fine and some don't. So it's kind of random whether u-boot can read a /boot directory. This was after full ubuntu installs. I'd guess a simple test with a couple of files and directories will not show the problem. We really need a test case here. In my (certainly not very extensive) tests I didn't see such a problem. Can you please describe what failed for you? I do an ubuntu install to a single ext4 fs and then ext2ls gives this: EXT2 rev 1, inode_size 256 ext4fs read 0 group descriptor (blkno 1 blkoff 0) iterate . ext4fs read 0 group descriptor (blkno 1 blkoff 0) DIR 4096 . iterate .. ext4fs read 0 group descriptor (blkno 1 blkoff 0) DIR 4096 .. iterate lost+found ext4fs read 0 group descriptor (blkno 1 blkoff 0) DIR 16384 lost+found iterate etc ext4fs read 832 group descriptor (blkno 7 blkoff 2048) DIR 4096 etc iterate media ext4fs read 416 group descriptor (blkno 4 blkoff 1024) DIR 4096 media iterate var ext4fs read 848 group descriptor (blkno 7 blkoff 2560) DIR 4096 var iterate usr ext4fs read 1760 group descriptor (blkno 14 blkoff 3072) DIR 0 usr iterate mnt ext4fs read 80 group descriptor (blkno 1 blkoff 2560) DIR 4096 mnt iterate dev ext4fs read 1152 group descriptor (blkno 10 blkoff 0) DIR 0 dev iterate home ext4fs read 1472 group descriptor (blkno 12 blkoff 2048) DIR 0 home iterate run ext4fs read 864 group descriptor (blkno 7 blkoff 3072) DIR 4096 run iterate boot ext4fs read 224 group descriptor (blkno 2 blkoff 3072) DIR 4096 boot iterate tmp ext4fs read 1184 group descriptor (blkno 10 blkoff 1024) DIR 0 tmp iterate sbin ext4fs read 576 group descriptor (blkno 5 blkoff 2048) DIR 4096 sbin iterate proc ext4fs read 1632 group descriptor (blkno 13 blkoff 3072) DIR 0 proc iterate bin ext4fs read 1216 group descriptor (blkno 10 blkoff 2048) DIR 0 bin The problem is in the directories with sizes of 0. It does seem to be directories with higher blkno's. Perhaps the lack of support for hash table directory entries is a problem. Just guessing here as I don't know much about ext4 structure. I haven't been able to produce a simple example just creating a bunch of files and directories, so only the disk after an ubuntu install has the problem. Rob ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
Dear Rob Herring, In message 50294743.5010...@gmail.com you wrote: I do an ubuntu install to a single ext4 fs and then ext2ls gives this: ... The problem is in the directories with sizes of 0. It does seem to be What exactly is the problem? The listing appears pretty normal to me? It seems you enabled some debug feature? Which exactly? And you get the same results without debug, don't you? I haven't been able to produce a simple example just creating a bunch of files and directories, so only the disk after an ubuntu install has the problem. Can you upload the image somewhere? And indicate which exact problems we should look for? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Defaults are wonderful, just like fire. - Larry Wall in 1996mar6.004121.27...@netlabs.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
On 08/13/2012 02:17 PM, Wolfgang Denk wrote: Dear Rob Herring, In message 50294743.5010...@gmail.com you wrote: I do an ubuntu install to a single ext4 fs and then ext2ls gives this: ... The problem is in the directories with sizes of 0. It does seem to be What exactly is the problem? The listing appears pretty normal to me? The size for the directories are 0 instead of 4096 and those directories have no contents. An ext2ls on /usr in this example: EXT2 rev 1, inode_size 256 ext4fs read 0 group descriptor (blkno 1 blkoff 0) Iterate dir usr iterate . iterate .. iterate lost+found iterate etc iterate media iterate var iterate usr ext4fs read 1760 group descriptor (blkno 14 blkoff 3072) Note only debug messages are printed. Not even '.' or '..' entries. It's only a problem when it is the /boot directory which seems to be random from install to install. It seems you enabled some debug feature? Which exactly? And you get the same results without debug, don't you? Just defined DEBUG on ext_common.c and ext4fs.c. It happens either way. I haven't been able to produce a simple example just creating a bunch of files and directories, so only the disk after an ubuntu install has the problem. Can you upload the image somewhere? And indicate which exact problems we should look for? Yes, I'll have to recreate one with a reasonable size. Rob Best regards, Wolfgang Denk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
Dear Rob Herring, In message 50244d5a.3080...@gmail.com you wrote: I reported already that the prior version that ext4 has issues with sub-directories. I don't think that has been addressed in V5. Some directories show up fine and some don't. So it's kind of random whether u-boot can read a /boot directory. This was after full ubuntu installs. I'd guess a simple test with a couple of files and directories will not show the problem. Do you have a specific test case that shows this behaviuour? I. e. either some script to create a directory hierarchy that triggers this bug, and/or a (small!) file system image or tarball we could use for testing? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Neckties strangle clear thinking. -- Lin Yutang ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
Dear Uma Shankar,
In message 1337961104-21198-1-git-send-email-uma.shan...@samsung.com you
wrote:
Signed-off-by: Uma Shankar uma.shan...@samsung.com
Signed-off-by: Manjunatha C Achar a.manjuna...@samsung.com
Signed-off-by: Iqbal Shareef iqbal@samsung.com
Signed-off-by: Hakgoo Lee goodguy@samsung.com
---
Changes for v4:
- Redesigned ext2, ext4 command interface
- Removed ext2 folder from fs/
- Memory Leak issue handled
Changes for v3:
- Copyright has been updated in respective files
- ext4fs has been made independant of ext2fs.c
- Fixed API namespace
- Removed endianness conversion API, used uboot defined API
for the same
- Fixed coding style issues
- Moved README.ext4 file into doc folder
Changes for v2:
- Code cleanup, changed comment style
- camel case removed, resolved code alignment issues
- memory allocation logic changed, removed busybox logic
- Modified ext4 load to remove grub dependency (GPLv3)
- Introduced new Config for ext4 write
Changes for v1:
- Removed checkpatch warnings and errors
- Moved common API's of ext2 and ext4 to one generic header file
---
Makefile |2 +-
common/Makefile|6 +
common/cmd_ext2.c | 219 +--
common/cmd_ext4.c | 96 +
common/cmd_ext_common.c| 259 +
fs/Makefile|5 +-
fs/ext2/dev.c | 131 ---
fs/ext2/ext2fs.c | 897
fs/{ext2 = ext4}/Makefile |8 +-
fs/ext4/dev.c | 145 +++
fs/ext4/ext4_common.c | 875 ++
fs/ext4/ext4_common.h | 63 +++
fs/ext4/ext4fs.c | 228 +++
include/ext2fs.h | 81
include/ext4fs.h | 132 +++
include/ext_common.h | 197 ++
16 files changed, 2028 insertions(+), 1316 deletions(-)
create mode 100644 common/cmd_ext4.c
create mode 100644 common/cmd_ext_common.c
delete mode 100644 fs/ext2/dev.c
delete mode 100644 fs/ext2/ext2fs.c
rename fs/{ext2 = ext4}/Makefile (89%)
create mode 100644 fs/ext4/dev.c
create mode 100644 fs/ext4/ext4_common.c
create mode 100644 fs/ext4/ext4_common.h
create mode 100644 fs/ext4/ext4fs.c
delete mode 100644 include/ext2fs.h
create mode 100644 include/ext4fs.h
create mode 100644 include/ext_common.h
As this is all untested code which replaces ext2 which is in active
use by a large number of boards I decided to put this into a separate
branch ext4 for now so people can easiy test it. If there are no
problems, or the problems have been fixed in time, we can merge this
branch around when -rc1 comes out.
Hope this is OK with you.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
That said, there may be good reasons for what you did beyond obsequi-
ous sycophantic parody. Perhaps you might be so kind as to elucidate.
-- Tom Christiansen in 5ldjbm$jtk$1...@csnews.cs.colorado.edu
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
On 08/09/2012 04:50 PM, Wolfgang Denk wrote:
Dear Uma Shankar,
In message 1337961104-21198-1-git-send-email-uma.shan...@samsung.com you
wrote:
Signed-off-by: Uma Shankar uma.shan...@samsung.com
Signed-off-by: Manjunatha C Achar a.manjuna...@samsung.com
Signed-off-by: Iqbal Shareef iqbal@samsung.com
Signed-off-by: Hakgoo Lee goodguy@samsung.com
---
Changes for v4:
- Redesigned ext2, ext4 command interface
- Removed ext2 folder from fs/
- Memory Leak issue handled
Changes for v3:
- Copyright has been updated in respective files
- ext4fs has been made independant of ext2fs.c
- Fixed API namespace
- Removed endianness conversion API, used uboot defined API
for the same
- Fixed coding style issues
- Moved README.ext4 file into doc folder
Changes for v2:
- Code cleanup, changed comment style
- camel case removed, resolved code alignment issues
- memory allocation logic changed, removed busybox logic
- Modified ext4 load to remove grub dependency (GPLv3)
- Introduced new Config for ext4 write
Changes for v1:
- Removed checkpatch warnings and errors
- Moved common API's of ext2 and ext4 to one generic header file
---
Makefile |2 +-
common/Makefile|6 +
common/cmd_ext2.c | 219 +--
common/cmd_ext4.c | 96 +
common/cmd_ext_common.c| 259 +
fs/Makefile|5 +-
fs/ext2/dev.c | 131 ---
fs/ext2/ext2fs.c | 897
fs/{ext2 = ext4}/Makefile |8 +-
fs/ext4/dev.c | 145 +++
fs/ext4/ext4_common.c | 875 ++
fs/ext4/ext4_common.h | 63 +++
fs/ext4/ext4fs.c | 228 +++
include/ext2fs.h | 81
include/ext4fs.h | 132 +++
include/ext_common.h | 197 ++
16 files changed, 2028 insertions(+), 1316 deletions(-)
create mode 100644 common/cmd_ext4.c
create mode 100644 common/cmd_ext_common.c
delete mode 100644 fs/ext2/dev.c
delete mode 100644 fs/ext2/ext2fs.c
rename fs/{ext2 = ext4}/Makefile (89%)
create mode 100644 fs/ext4/dev.c
create mode 100644 fs/ext4/ext4_common.c
create mode 100644 fs/ext4/ext4_common.h
create mode 100644 fs/ext4/ext4fs.c
delete mode 100644 include/ext2fs.h
create mode 100644 include/ext4fs.h
create mode 100644 include/ext_common.h
As this is all untested code which replaces ext2 which is in active
use by a large number of boards I decided to put this into a separate
branch ext4 for now so people can easiy test it. If there are no
problems, or the problems have been fixed in time, we can merge this
branch around when -rc1 comes out.
I reported already that the prior version that ext4 has issues with
sub-directories. I don't think that has been addressed in V5. Some
directories show up fine and some don't. So it's kind of random whether
u-boot can read a /boot directory. This was after full ubuntu installs.
I'd guess a simple test with a couple of files and directories will not
show the problem.
Rob
Hope this is OK with you.
Best regards,
Wolfgang Denk
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V5 1/2] ext4fs ls load support
Dear Rob Herring,
On 08/09/2012 04:50 PM, Wolfgang Denk wrote:
Dear Uma Shankar,
In message 1337961104-21198-1-git-send-email-uma.shan...@samsung.com you
wrote:
Signed-off-by: Uma Shankar uma.shan...@samsung.com
Signed-off-by: Manjunatha C Achar a.manjuna...@samsung.com
Signed-off-by: Iqbal Shareef iqbal@samsung.com
Signed-off-by: Hakgoo Lee goodguy@samsung.com
---
Changes for v4:
- Redesigned ext2, ext4 command interface
- Removed ext2 folder from fs/
- Memory Leak issue handled
Changes for v3:
- Copyright has been updated in respective files
- ext4fs has been made independant of ext2fs.c
- Fixed API namespace
- Removed endianness conversion API, used uboot defined API
for the same
- Fixed coding style issues
- Moved README.ext4 file into doc folder
Changes for v2:
- Code cleanup, changed comment style
- camel case removed, resolved code alignment issues
- memory allocation logic changed, removed busybox logic
- Modified ext4 load to remove grub dependency (GPLv3)
- Introduced new Config for ext4 write
Changes for v1:
- Removed checkpatch warnings and errors
- Moved common API's of ext2 and ext4 to one generic header file
---
Makefile |2 +-
common/Makefile|6 +
common/cmd_ext2.c | 219 +--
common/cmd_ext4.c | 96 +
common/cmd_ext_common.c| 259 +
fs/Makefile|5 +-
fs/ext2/dev.c | 131 ---
fs/ext2/ext2fs.c | 897
fs/{ext2 =
ext4}/Makefile |8 +-
fs/ext4/dev.c | 145 +++
fs/ext4/ext4_common.c | 875
++ fs/ext4/ext4_common.h
| 63 +++
fs/ext4/ext4fs.c | 228 +++
include/ext2fs.h | 81
include/ext4fs.h | 132 +++
include/ext_common.h | 197 ++
16 files changed, 2028 insertions(+), 1316 deletions(-)
create mode 100644 common/cmd_ext4.c
create mode 100644 common/cmd_ext_common.c
delete mode 100644 fs/ext2/dev.c
delete mode 100644 fs/ext2/ext2fs.c
rename fs/{ext2 = ext4}/Makefile (89%)
create mode 100644 fs/ext4/dev.c
create mode 100644 fs/ext4/ext4_common.c
create mode 100644 fs/ext4/ext4_common.h
create mode 100644 fs/ext4/ext4fs.c
delete mode 100644 include/ext2fs.h
create mode 100644 include/ext4fs.h
create mode 100644 include/ext_common.h
As this is all untested code which replaces ext2 which is in active
use by a large number of boards I decided to put this into a separate
branch ext4 for now so people can easiy test it. If there are no
problems, or the problems have been fixed in time, we can merge this
branch around when -rc1 comes out.
I reported already that the prior version that ext4 has issues with
sub-directories. I don't think that has been addressed in V5. Some
directories show up fine and some don't. So it's kind of random whether
u-boot can read a /boot directory. This was after full ubuntu installs.
I'd guess a simple test with a couple of files and directories will not
show the problem.
It was crashing on ext2 for me ... maybe further tests are in place. Anyone
willing to debug this btw ?
Hope this is OK with you.
Best regards,
Wolfgang Denk
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
