Re: [U-Boot] [PATCH cosmetic] x86: fsp_support: Correct high mem comment typo
On 23 May 2015 at 10:37, Simon Glass s...@chromium.org wrote: On 23 May 2015 at 09:44, Bin Meng bmeng...@gmail.com wrote: +Simon. On Sat, May 23, 2015 at 3:11 AM, and...@bradfordembedded.com wrote: From: Andrew Bradford andrew.bradf...@kodakalaris.com High mem starts at 4 GiB. Signed-off-by: Andrew Bradford andrew.bradf...@kodakalaris.com --- arch/x86/lib/fsp/fsp_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/fsp/fsp_support.c b/arch/x86/lib/fsp/fsp_support.c index 5f96da1..5809235 100644 --- a/arch/x86/lib/fsp/fsp_support.c +++ b/arch/x86/lib/fsp/fsp_support.c @@ -279,7 +279,7 @@ u64 fsp_get_usable_highmem_top(const void *hob_list) res_desc = (struct hob_res_desc *)hdr; if (res_desc-type == RES_SYS_MEM) { phys_start = res_desc-phys_start; - /* Need memory above 1MB to be collected here */ + /* Need memory above 4GB to be collected here */ if (phys_start = (phys_addr_t)FSP_HIGHMEM_BASE) top += (u32)(res_desc-len); } -- Reviewed-by: Bin Meng bmeng...@gmail.com Acked-by: Simon Glass s...@chromium.org Applied to u-boot-x86, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH cosmetic] x86: fsp_support: Correct high mem comment typo
+Simon. On Sat, May 23, 2015 at 3:11 AM, and...@bradfordembedded.com wrote: From: Andrew Bradford andrew.bradf...@kodakalaris.com High mem starts at 4 GiB. Signed-off-by: Andrew Bradford andrew.bradf...@kodakalaris.com --- arch/x86/lib/fsp/fsp_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/fsp/fsp_support.c b/arch/x86/lib/fsp/fsp_support.c index 5f96da1..5809235 100644 --- a/arch/x86/lib/fsp/fsp_support.c +++ b/arch/x86/lib/fsp/fsp_support.c @@ -279,7 +279,7 @@ u64 fsp_get_usable_highmem_top(const void *hob_list) res_desc = (struct hob_res_desc *)hdr; if (res_desc-type == RES_SYS_MEM) { phys_start = res_desc-phys_start; - /* Need memory above 1MB to be collected here */ + /* Need memory above 4GB to be collected here */ if (phys_start = (phys_addr_t)FSP_HIGHMEM_BASE) top += (u32)(res_desc-len); } -- Reviewed-by: Bin Meng bmeng...@gmail.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH cosmetic] x86: fsp_support: Correct high mem comment typo
On 23 May 2015 at 09:44, Bin Meng bmeng...@gmail.com wrote: +Simon. On Sat, May 23, 2015 at 3:11 AM, and...@bradfordembedded.com wrote: From: Andrew Bradford andrew.bradf...@kodakalaris.com High mem starts at 4 GiB. Signed-off-by: Andrew Bradford andrew.bradf...@kodakalaris.com --- arch/x86/lib/fsp/fsp_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/fsp/fsp_support.c b/arch/x86/lib/fsp/fsp_support.c index 5f96da1..5809235 100644 --- a/arch/x86/lib/fsp/fsp_support.c +++ b/arch/x86/lib/fsp/fsp_support.c @@ -279,7 +279,7 @@ u64 fsp_get_usable_highmem_top(const void *hob_list) res_desc = (struct hob_res_desc *)hdr; if (res_desc-type == RES_SYS_MEM) { phys_start = res_desc-phys_start; - /* Need memory above 1MB to be collected here */ + /* Need memory above 4GB to be collected here */ if (phys_start = (phys_addr_t)FSP_HIGHMEM_BASE) top += (u32)(res_desc-len); } -- Reviewed-by: Bin Meng bmeng...@gmail.com Acked-by: Simon Glass s...@chromium.org ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH cosmetic] x86: fsp_support: Correct high mem comment typo
From: Andrew Bradford andrew.bradf...@kodakalaris.com High mem starts at 4 GiB. Signed-off-by: Andrew Bradford andrew.bradf...@kodakalaris.com --- arch/x86/lib/fsp/fsp_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/lib/fsp/fsp_support.c b/arch/x86/lib/fsp/fsp_support.c index 5f96da1..5809235 100644 --- a/arch/x86/lib/fsp/fsp_support.c +++ b/arch/x86/lib/fsp/fsp_support.c @@ -279,7 +279,7 @@ u64 fsp_get_usable_highmem_top(const void *hob_list) res_desc = (struct hob_res_desc *)hdr; if (res_desc-type == RES_SYS_MEM) { phys_start = res_desc-phys_start; - /* Need memory above 1MB to be collected here */ + /* Need memory above 4GB to be collected here */ if (phys_start = (phys_addr_t)FSP_HIGHMEM_BASE) top += (u32)(res_desc-len); } -- 1.9.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot