Re: [U-Boot] [PATCH v1 04/18] board: gdsys: Configure DP501 SPDIF input

[Heiko Schocher]

Hello Dirk,

Am 28.10.2015 um 11:46 schrieb dirk.eib...@gdsys.cc:

From: Dirk Eibach 

Signed-off-by: Dirk Eibach 
---

  board/gdsys/common/dp501.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/board/gdsys/common/dp501.c b/board/gdsys/common/dp501.c
index 7eb15ed..baace38 100644
--- a/board/gdsys/common/dp501.c
+++ b/board/gdsys/common/dp501.c
@@ -77,6 +77,8 @@ void dp501_powerup(u8 addr)
i2c_reg_write(addr + 2, 0x24, 0x02); /* clock input single ended */
  #endif

+   i2c_reg_write(addr + 2, 0x1a, 0x04); /* SPDIF input method TTL */
+
i2c_reg_write(addr + 2, 0x00, 0x18); /* driving strength */
i2c_reg_write(addr + 2, 0x03, 0x06); /* driving strength */
i2c_reg_write(addr, 0x2c, 0x00); /* configure N value */


Hmm... a lot of magical values ... some defines would be nice here.

Beside of this:

Reviewed-by: Heiko Schocher 

bye,
Heiko
--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v1 04/18] board: gdsys: Configure DP501 SPDIF input

[Dirk Eibach]

Hello Heiko,

2015-10-28 12:25 GMT+01:00 Heiko Schocher :
> Hmm... a lot of magical values ... some defines would be nice here.

Agreed. Documenting all the ugly mess Parade Technologies calls an
interface would result in a list of enums, that would be as long as
(at  least) the driver itself. So I decided to comment line by line
what happens. Since this is (at least as far I as know) the only open
source code for DP501, I hope one day I will find some time to invest
some more effort here.

Cheers
Dirk
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v1 04/18] board: gdsys: Configure DP501 SPDIF input

[dirk . eibach]

From: Dirk Eibach 

Signed-off-by: Dirk Eibach 
---

 board/gdsys/common/dp501.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/board/gdsys/common/dp501.c b/board/gdsys/common/dp501.c
index 7eb15ed..baace38 100644
--- a/board/gdsys/common/dp501.c
+++ b/board/gdsys/common/dp501.c
@@ -77,6 +77,8 @@ void dp501_powerup(u8 addr)
i2c_reg_write(addr + 2, 0x24, 0x02); /* clock input single ended */
 #endif
 
+   i2c_reg_write(addr + 2, 0x1a, 0x04); /* SPDIF input method TTL */
+
i2c_reg_write(addr + 2, 0x00, 0x18); /* driving strength */
i2c_reg_write(addr + 2, 0x03, 0x06); /* driving strength */
i2c_reg_write(addr, 0x2c, 0x00); /* configure N value */
-- 
2.1.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot