Re: [U-Boot] [PATCH v1 05/18] board: gdsys: Increase DP501 I2C retry interval

[Heiko Schocher]

Hello Dirk,

Am 28.10.2015 um 11:46 schrieb dirk.eib...@gdsys.cc:

From: Dirk Eibach 

With Club 3D dual link adapter there are AUX-channel timeouts
when EDID is read. Increasing retry interval time to max (400us)
fixes this.

Signed-off-by: Dirk Eibach 
---

  board/gdsys/common/dp501.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)


Reviewed-by: Heiko Schocher 

except the same comment as patch before ... this file uses
a lot of magic values ... maybe this should be fixed?

Hmm... and converting the hole board support to DM would be nice ;-)

bye,
Heiko

diff --git a/board/gdsys/common/dp501.c b/board/gdsys/common/dp501.c
index baace38..0389fd1 100644
--- a/board/gdsys/common/dp501.c
+++ b/board/gdsys/common/dp501.c
@@ -88,7 +88,8 @@ void dp501_powerup(u8 addr)
dp501_setbits(addr, 0x78, 0x03); /* clear all interrupt */
i2c_reg_write(addr, 0x75, 0xf8); /* aux channel reset */
i2c_reg_write(addr, 0x75, 0x00); /* clear aux channel reset */
-   i2c_reg_write(addr, 0x87, 0x70); /* set retry counter as 7 */
+   i2c_reg_write(addr, 0x87, 0x7f); /* set retry counter as 7
+   retry interval 400us */

if (dp501_detect_cable_adapter(addr)) {
printf("DVI/HDMI cable adapter detected\n");



--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v1 05/18] board: gdsys: Increase DP501 I2C retry interval

[dirk . eibach]

From: Dirk Eibach 

With Club 3D dual link adapter there are AUX-channel timeouts
when EDID is read. Increasing retry interval time to max (400us)
fixes this.

Signed-off-by: Dirk Eibach 
---

 board/gdsys/common/dp501.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/board/gdsys/common/dp501.c b/board/gdsys/common/dp501.c
index baace38..0389fd1 100644
--- a/board/gdsys/common/dp501.c
+++ b/board/gdsys/common/dp501.c
@@ -88,7 +88,8 @@ void dp501_powerup(u8 addr)
dp501_setbits(addr, 0x78, 0x03); /* clear all interrupt */
i2c_reg_write(addr, 0x75, 0xf8); /* aux channel reset */
i2c_reg_write(addr, 0x75, 0x00); /* clear aux channel reset */
-   i2c_reg_write(addr, 0x87, 0x70); /* set retry counter as 7 */
+   i2c_reg_write(addr, 0x87, 0x7f); /* set retry counter as 7
+   retry interval 400us */
 
if (dp501_detect_cable_adapter(addr)) {
printf("DVI/HDMI cable adapter detected\n");
-- 
2.1.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot