Re: [U-Boot] [PATCH v1 19/19] net: mvneta: Fix fault when wrong device tree
On Wed, Mar 21, 2018 at 4:44 AM, Stefan Roese wrote: > On 21.03.2018 10:42, Stefan Roese wrote: >> >> On 07.03.2018 22:52, Marek Behún wrote: >>> >>> The driver does not check id phy_connect failed (for example on wrong >>> property name in device tree). In such a case a fault occurs and the >>> CPU is restarted. >>> >>> Signed-off-by: Marek Behun >>> --- >>> drivers/net/mvneta.c | 4 >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c >>> index 83e3153768..7403ccbd3c 100644 >>> --- a/drivers/net/mvneta.c >>> +++ b/drivers/net/mvneta.c >>> @@ -1554,6 +1554,10 @@ static int mvneta_start(struct udevice *dev) >>> phydev = phy_connect(pp->bus, pp->phyaddr, dev, >>>pp->phy_interface); >>> +if (!phydev) { >>> +printf("phy_connect failed\n"); >>> +return -1; >>> +} >> >> >> Yes. But please add a more meaningful error number here, like -ENODEV. >> >> Other that this: >> >> Reviewed-by: Stefan Roese > > > And please add Joe Hershberger on network related patches. Thanks,Stefan. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v1 19/19] net: mvneta: Fix fault when wrong device tree
On 21.03.2018 10:42, Stefan Roese wrote: On 07.03.2018 22:52, Marek Behún wrote: The driver does not check id phy_connect failed (for example on wrong property name in device tree). In such a case a fault occurs and the CPU is restarted. Signed-off-by: Marek Behun --- drivers/net/mvneta.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c index 83e3153768..7403ccbd3c 100644 --- a/drivers/net/mvneta.c +++ b/drivers/net/mvneta.c @@ -1554,6 +1554,10 @@ static int mvneta_start(struct udevice *dev) phydev = phy_connect(pp->bus, pp->phyaddr, dev, pp->phy_interface); + if (!phydev) { + printf("phy_connect failed\n"); + return -1; + } Yes. But please add a more meaningful error number here, like -ENODEV. Other that this: Reviewed-by: Stefan Roese And please add Joe Hershberger on network related patches. Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v1 19/19] net: mvneta: Fix fault when wrong device tree
On 07.03.2018 22:52, Marek Behún wrote: The driver does not check id phy_connect failed (for example on wrong property name in device tree). In such a case a fault occurs and the CPU is restarted. Signed-off-by: Marek Behun --- drivers/net/mvneta.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c index 83e3153768..7403ccbd3c 100644 --- a/drivers/net/mvneta.c +++ b/drivers/net/mvneta.c @@ -1554,6 +1554,10 @@ static int mvneta_start(struct udevice *dev) phydev = phy_connect(pp->bus, pp->phyaddr, dev, pp->phy_interface); + if (!phydev) { + printf("phy_connect failed\n"); + return -1; + } Yes. But please add a more meaningful error number here, like -ENODEV. Other that this: Reviewed-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v1 19/19] net: mvneta: Fix fault when wrong device tree
The driver does not check id phy_connect failed (for example on wrong property name in device tree). In such a case a fault occurs and the CPU is restarted. Signed-off-by: Marek Behun --- drivers/net/mvneta.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c index 83e3153768..7403ccbd3c 100644 --- a/drivers/net/mvneta.c +++ b/drivers/net/mvneta.c @@ -1554,6 +1554,10 @@ static int mvneta_start(struct udevice *dev) phydev = phy_connect(pp->bus, pp->phyaddr, dev, pp->phy_interface); + if (!phydev) { + printf("phy_connect failed\n"); + return -1; + } pp->phydev = phydev; phy_config(phydev); -- 2.16.1 ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot