Re: [U-Boot] [PATCH v2] arm: add support for PDU001
On Mon, Jan 22, 2018 at 05:33:59PM +0100, Felix Brack wrote: > Hi Tom, > > On 22.01.2018 16:15, Tom Rini wrote: > > On Mon, Jan 22, 2018 at 12:07:49PM +0100, Felix Brack wrote: > > > >> This patch adds support for the PDU001 board. > >> > >> Signed-off-by: Felix Brack > > [snip] > >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > >> index f6d57f5..15349b3 100644 > >> --- a/arch/arm/Kconfig > >> +++ b/arch/arm/Kconfig > >> @@ -1339,6 +1339,7 @@ source "board/vscom/baltos/Kconfig" > >> source "board/woodburn/Kconfig" > >> source "board/work-microwave/work_92105/Kconfig" > >> source "board/zipitz2/Kconfig" > >> +source "board/eets/pdu001/Kconfig" > > > Sorry, missed that one. > > > This should stay alphabetized. > > > > [snip] > >> new file mode 100644 > >> index 000..0967e82 > >> --- /dev/null > >> +++ b/arch/arm/dts/am335x-pdu001.dts > > > > So, have you pushed this platform upstream to Linux? > > > Not yet. I would like to follow the same procedure for Linux as I did > for U-Boot, i.e. first finish the work on all drivers required by the board. OK. Please just make sure to keep it in sync with feedback you get from upstream there, thanks! > >> @@ -0,0 +1,612 @@ > >> +/* > >> + * pdu001.dts > >> + * > >> + * EETS GmbH PDU001 board device tree file > >> + * > >> + * Copyright (C) 2018 EETS GmbH - http://www.eets.ch/ > >> + * > >> + * Copyright (C) 2011, Texas Instruments, Incorporated - > >> http://www.ti.com/ > >> + * > >> + * SPDX-License-Identifier: GPL-2.0-or-later > > > > This is not a free-form tag. Here and elsewhere you want "GPL-2.0+". > > > Well, I followed the advice on https://spdx.org/licenses/ when using > this tag. According to SPDX "GPL-2.0+" is deprecated as of V2.0rc2 and > the use of "GPL-2.0-or-later" is suggested instead. However I'm fine > using "GPL-2.0+", just let me know. Ugh. For now, please do GPL-2.0+ and I'll take an action to do a treewide update to match what's preferred as of 3.0. -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2] arm: add support for PDU001
Hi Tom,
On 22.01.2018 16:15, Tom Rini wrote:
> On Mon, Jan 22, 2018 at 12:07:49PM +0100, Felix Brack wrote:
>
>> This patch adds support for the PDU001 board.
>>
>> Signed-off-by: Felix Brack
> [snip]
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index f6d57f5..15349b3 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1339,6 +1339,7 @@ source "board/vscom/baltos/Kconfig"
>> source "board/woodburn/Kconfig"
>> source "board/work-microwave/work_92105/Kconfig"
>> source "board/zipitz2/Kconfig"
>> +source "board/eets/pdu001/Kconfig"
>
Sorry, missed that one.
> This should stay alphabetized.
>
> [snip]
>> new file mode 100644
>> index 000..0967e82
>> --- /dev/null
>> +++ b/arch/arm/dts/am335x-pdu001.dts
>
> So, have you pushed this platform upstream to Linux?
>
Not yet. I would like to follow the same procedure for Linux as I did
for U-Boot, i.e. first finish the work on all drivers required by the board.
>> @@ -0,0 +1,612 @@
>> +/*
>> + * pdu001.dts
>> + *
>> + * EETS GmbH PDU001 board device tree file
>> + *
>> + * Copyright (C) 2018 EETS GmbH - http://www.eets.ch/
>> + *
>> + * Copyright (C) 2011, Texas Instruments, Incorporated - http://www.ti.com/
>> + *
>> + * SPDX-License-Identifier: GPL-2.0-or-later
>
> This is not a free-form tag. Here and elsewhere you want "GPL-2.0+".
>
Well, I followed the advice on https://spdx.org/licenses/ when using
this tag. According to SPDX "GPL-2.0+" is deprecated as of V2.0rc2 and
the use of "GPL-2.0-or-later" is suggested instead. However I'm fine
using "GPL-2.0+", just let me know.
> [snip]
>> +ocp {
>> +u-boot,dm-pre-reloc;
>> +};
>> +};
>> +
>> +&l4_wkup {
>> +u-boot,dm-pre-reloc;
>> +};
>> +
>> +&scm {
>> +u-boot,dm-pre-reloc;
>> +};
>> +
>
> For long term maintenance you'll want to move these U-Boot specific
> parts to a am335x-pdu001-u-boot.dtsi file so that you can re-sync the
> main DTS file with Linux and not have any important U-Boot changes be
> dropped.
>
Thanks for the hint!
regards, Felix
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2] arm: add support for PDU001
On Mon, Jan 22, 2018 at 12:07:49PM +0100, Felix Brack wrote:
> This patch adds support for the PDU001 board.
>
> Signed-off-by: Felix Brack
[snip]
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index f6d57f5..15349b3 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1339,6 +1339,7 @@ source "board/vscom/baltos/Kconfig"
> source "board/woodburn/Kconfig"
> source "board/work-microwave/work_92105/Kconfig"
> source "board/zipitz2/Kconfig"
> +source "board/eets/pdu001/Kconfig"
This should stay alphabetized.
[snip]
> new file mode 100644
> index 000..0967e82
> --- /dev/null
> +++ b/arch/arm/dts/am335x-pdu001.dts
So, have you pushed this platform upstream to Linux?
> @@ -0,0 +1,612 @@
> +/*
> + * pdu001.dts
> + *
> + * EETS GmbH PDU001 board device tree file
> + *
> + * Copyright (C) 2018 EETS GmbH - http://www.eets.ch/
> + *
> + * Copyright (C) 2011, Texas Instruments, Incorporated - http://www.ti.com/
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
This is not a free-form tag. Here and elsewhere you want "GPL-2.0+".
[snip]
> + ocp {
> + u-boot,dm-pre-reloc;
> + };
> +};
> +
> +&l4_wkup {
> + u-boot,dm-pre-reloc;
> +};
> +
> +&scm {
> + u-boot,dm-pre-reloc;
> +};
> +
For long term maintenance you'll want to move these U-Boot specific
parts to a am335x-pdu001-u-boot.dtsi file so that you can re-sync the
main DTS file with Linux and not have any important U-Boot changes be
dropped.
Thanks!
--
Tom
signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
[U-Boot] [PATCH v2] arm: add support for PDU001
This patch adds support for the PDU001 board.
Signed-off-by: Felix Brack
---
Changes in v2:
- use DT to configure the board
- use new single-register pin controller
- use new TPS65910 PMIC driver
- eliminate the need of CONFIG_DM_I2C_COMPAT, i.e. use DM for i2c
- clarify the function of the 'Run LED'
- fix ordering of include files
- replace deprecated SPDX license identifiers
arch/arm/Kconfig | 1 +
arch/arm/dts/Makefile | 3 +-
arch/arm/dts/am335x-pdu001.dts | 612 +
arch/arm/mach-omap2/am33xx/Kconfig | 9 +
board/eets/pdu001/Kconfig | 66
board/eets/pdu001/MAINTAINERS | 6 +
board/eets/pdu001/Makefile | 13 +
board/eets/pdu001/README | 35 +++
board/eets/pdu001/board.c | 276 +
board/eets/pdu001/board.h | 38 +++
board/eets/pdu001/mux.c| 120
configs/am335x_pdu001_defconfig| 55
include/configs/pdu001.h | 87 ++
13 files changed, 1320 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/dts/am335x-pdu001.dts
create mode 100644 board/eets/pdu001/Kconfig
create mode 100644 board/eets/pdu001/MAINTAINERS
create mode 100644 board/eets/pdu001/Makefile
create mode 100644 board/eets/pdu001/README
create mode 100644 board/eets/pdu001/board.c
create mode 100644 board/eets/pdu001/board.h
create mode 100644 board/eets/pdu001/mux.c
create mode 100644 configs/am335x_pdu001_defconfig
create mode 100644 include/configs/pdu001.h
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index f6d57f5..15349b3 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1339,6 +1339,7 @@ source "board/vscom/baltos/Kconfig"
source "board/woodburn/Kconfig"
source "board/work-microwave/work_92105/Kconfig"
source "board/zipitz2/Kconfig"
+source "board/eets/pdu001/Kconfig"
source "arch/arm/Kconfig.debug"
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 9540ba4..02b3c36 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -161,7 +161,8 @@ dtb-$(CONFIG_AM33XX) += am335x-boneblack.dtb
am335x-bone.dtb \
am335x-bonegreen.dtb \
am335x-icev2.dtb \
am335x-pxm50.dtb \
- am335x-rut.dtb
+ am335x-rut.dtb \
+ am335x-pdu001.dtb
dtb-$(CONFIG_AM43XX) += am437x-gp-evm.dtb am437x-sk-evm.dtb\
am43x-epos-evm.dtb \
am437x-idk-evm.dtb
diff --git a/arch/arm/dts/am335x-pdu001.dts b/arch/arm/dts/am335x-pdu001.dts
new file mode 100644
index 000..0967e82
--- /dev/null
+++ b/arch/arm/dts/am335x-pdu001.dts
@@ -0,0 +1,612 @@
+/*
+ * pdu001.dts
+ *
+ * EETS GmbH PDU001 board device tree file
+ *
+ * Copyright (C) 2018 EETS GmbH - http://www.eets.ch/
+ *
+ * Copyright (C) 2011, Texas Instruments, Incorporated - http://www.ti.com/
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+/dts-v1/;
+
+#include "am33xx.dtsi"
+#include
+#include
+
+/ {
+ model = "EETS,PDU001";
+ compatible = "eets,pdu001", "ti,am33xx";
+
+ chosen {
+ stdout-path = &uart3;
+ };
+
+ cpus {
+ cpu@0 {
+ cpu0-supply = <&vdd1_reg>;
+ };
+ };
+
+ memory {
+ device_type = "memory";
+ reg = <0x8000 0x1000>; /* 256 MB */
+ };
+
+ vbat: fixedregulator@0 {
+ compatible = "regulator-fixed";
+ regulator-name = "vbat";
+ regulator-min-microvolt = <360>;
+ regulator-max-microvolt = <360>;
+ regulator-boot-on;
+ };
+
+ lis3_reg: fixedregulator@1 {
+ compatible = "regulator-fixed";
+ regulator-name = "lis3_reg";
+ regulator-boot-on;
+ };
+
+ panel {
+ compatible = "ti,tilcdc,panel";
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcd_pins_s0>;
+ panel-info {
+ ac-bias = <255>;
+ ac-bias-intrpt= <0>;
+ dma-burst-sz = <16>;
+ bpp = <16>;
+ fdd = <0x80>;
+ sync-edge = <0>;
+ sync-ctrl = <1>;
+ raster-order = <0>;
+ fifo-th = <0>;
+ };
+
+ display-timings {
+ 240x320p16 {
+ clock-frequency = <650>;
+ hactive = <240>;
+ vactive = <320>;
+ hfront-porch = <6>;
+ hback-porch = <6>;
+ hsync-len = <1>;
+ vback-porch = <6>;
+ vfront-porch = <6>;
+
