Re: [U-Boot] [PATCH v2] arm: get_sp() should always be compiled
Le 18/02/2011 06:42, Po-Yu Chuang a écrit : > Hi Albert, > > On Fri, Feb 18, 2011 at 1:23 AM, Albert ARIBAUD > wrote: >> Le 17/02/2011 13:54, Macpaul Lin a écrit : >>> 2011/2/17 Albert ARIBAUD: Le 16/02/2011 09:54, Po-Yu Chuang a écrit : > From: Po-Yu Chuang > > get_sp() was incorrectly excluded if none of > CONFIG_SETUP_MEMORY_TAGS > CONFIG_CMDLINE_TAG > CONFIG_INITRD_TAG > CONFIG_SERIAL_TAG > CONFIG_REVISION_TAG > were defined. Which board exactly requires this patch? >>> >>> I think it is a320evb. >> >> Ok. This patch indeed removes the 'get_sp' error on this board's build, but >> as an FYI, it does not build anyway. > > The following patches fix all the build errors of a320evb: > (Although it still won't work, its timer still need some fix.) > > [PATCH v2 1/2] power: ftpmu010: move drivers/power/ftpmu010.h to > include/faraday > [PATCH v2 2/2] arm: a320: use new ftpmu010 API Thanks. If these receive review soon, I'll include them in my next pull along with the ARM machine type update. > best regards, > Po-Yu Chuang Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] arm: get_sp() should always be compiled
Hi Albert, On Fri, Feb 18, 2011 at 1:23 AM, Albert ARIBAUD wrote: > Le 17/02/2011 13:54, Macpaul Lin a écrit : >> 2011/2/17 Albert ARIBAUD: >>> Le 16/02/2011 09:54, Po-Yu Chuang a écrit : From: Po-Yu Chuang get_sp() was incorrectly excluded if none of CONFIG_SETUP_MEMORY_TAGS CONFIG_CMDLINE_TAG CONFIG_INITRD_TAG CONFIG_SERIAL_TAG CONFIG_REVISION_TAG were defined. >>> >>> Which board exactly requires this patch? >> >> I think it is a320evb. > > Ok. This patch indeed removes the 'get_sp' error on this board's build, but > as an FYI, it does not build anyway. The following patches fix all the build errors of a320evb: (Although it still won't work, its timer still need some fix.) [PATCH v2 1/2] power: ftpmu010: move drivers/power/ftpmu010.h to include/faraday [PATCH v2 2/2] arm: a320: use new ftpmu010 API best regards, Po-Yu Chuang ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] arm: get_sp() should always be compiled
Hi Po-Yu Chang, Le 16/02/2011 09:54, Po-Yu Chuang a écrit : > From: Po-Yu Chuang > > get_sp() was incorrectly excluded if none of >CONFIG_SETUP_MEMORY_TAGS >CONFIG_CMDLINE_TAG >CONFIG_INITRD_TAG >CONFIG_SERIAL_TAG >CONFIG_REVISION_TAG > were defined. > > Signed-off-by: Po-Yu Chuang > --- > v2: > rebase Applied, to u-boot-arm/master as it is actually an old patch submission and a bugfix. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] arm: get_sp() should always be compiled
Le 17/02/2011 13:54, Macpaul Lin a écrit : > Hi, > > 2011/2/17 Albert ARIBAUD: >> Hi, >> >> Le 16/02/2011 09:54, Po-Yu Chuang a écrit : >>> From: Po-Yu Chuang >>> >>> get_sp() was incorrectly excluded if none of >>> CONFIG_SETUP_MEMORY_TAGS >>> CONFIG_CMDLINE_TAG >>> CONFIG_INITRD_TAG >>> CONFIG_SERIAL_TAG >>> CONFIG_REVISION_TAG >>> were defined. >> >> >> Which board exactly requires this patch? >> > > I think it is a320evb. Ok. This patch indeed removes the 'get_sp' error on this board's build, but as an FYI, it does not build anyway. Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] arm: get_sp() should always be compiled
Hi, 2011/2/17 Albert ARIBAUD : > Hi, > > Le 16/02/2011 09:54, Po-Yu Chuang a écrit : >> From: Po-Yu Chuang >> >> get_sp() was incorrectly excluded if none of >> CONFIG_SETUP_MEMORY_TAGS >> CONFIG_CMDLINE_TAG >> CONFIG_INITRD_TAG >> CONFIG_SERIAL_TAG >> CONFIG_REVISION_TAG >> were defined. > > > Which board exactly requires this patch? > I think it is a320evb. -- Best regards, Macpaul Lin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] arm: get_sp() should always be compiled
Hi, Le 16/02/2011 09:54, Po-Yu Chuang a écrit : > From: Po-Yu Chuang > > get_sp() was incorrectly excluded if none of >CONFIG_SETUP_MEMORY_TAGS >CONFIG_CMDLINE_TAG >CONFIG_INITRD_TAG >CONFIG_SERIAL_TAG >CONFIG_REVISION_TAG > were defined. Which board exactly requires this patch? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] arm: get_sp() should always be compiled
From: Po-Yu Chuang get_sp() was incorrectly excluded if none of CONFIG_SETUP_MEMORY_TAGS CONFIG_CMDLINE_TAG CONFIG_INITRD_TAG CONFIG_SERIAL_TAG CONFIG_REVISION_TAG were defined. Signed-off-by: Po-Yu Chuang --- v2: rebase arch/arm/lib/bootm.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c index a1649ee..7734953 100644 --- a/arch/arm/lib/bootm.c +++ b/arch/arm/lib/bootm.c @@ -327,12 +327,12 @@ void setup_revision_tag(struct tag **in_params) } #endif /* CONFIG_REVISION_TAG */ - static void setup_end_tag (bd_t *bd) { params->hdr.tag = ATAG_NONE; params->hdr.size = 0; } +#endif /* CONFIG_SETUP_MEMORY_TAGS || CONFIG_CMDLINE_TAG || CONFIG_INITRD_TAG */ static ulong get_sp(void) { @@ -341,5 +341,3 @@ static ulong get_sp(void) asm("mov %0, sp" : "=r"(ret) : ); return ret; } - -#endif /* CONFIG_SETUP_MEMORY_TAGS || CONFIG_CMDLINE_TAG || CONFIG_INITRD_TAG */ -- 1.6.3.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot