Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Wolfgang, [...] >> This change of the subject was the reason why I did not require you >> changing it as I know that Wolfgang currently matches patch versions by >> subject strings. > > This is not quite correct. I refer to the Subject: only if no other > thread information is present, i. e. if we have working In-reply-to: > and/or References: hewaders this works fine for me, too. Ah ok. Sorry for misremembering and thanks for the correction. Cheers Detlev -- Cyberwar is certainly not a myth. But you haven't seen it yet, despite the attacks on Estonia. Cyberwar is warfare in cyberspace. And warfare involves massive death and destruction. When you see it, you'll know it. -- Bruce Schneier, Nov. 2007 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Macpaul, >> "Correct" threading however uses "References:" mail headers and can cope >> with changing subjects. Somehow you seem to know this, as v3 indeed >> _has_ such a correct header and thus the threading in my mail reader >> works just fine ;) >> > > Yes. I did fix the References and In-reply-to headers. > However v3 it doesn't goes to the correct threadning in gmail. :p Gmail cannot handle "references:" headers? That is news to me. I find it always interesting that basic century old things seem to be forgotten by "modern all bells and whistles software" Cheers Detlev -- Windows Vista? And what a vista! All you see as you look around your garden is a 60foot high brick wall -- Crosbie Fitch. -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Dear Detlev Zundel, In message you wrote: > > > Since I've correct the subject of this patch v3 according to the > > "cosmetic" rule, > > it seems patch v3 is out of this mailing thread. > > This change of the subject was the reason why I did not require you > changing it as I know that Wolfgang currently matches patch versions by > subject strings. This is not quite correct. I refer to the Subject: only if no other thread information is present, i. e. if we have working In-reply-to: and/or References: hewaders this works fine for me, too. The problem is that only very few people provide correct thread references with updated patches. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Who is the oldest inhabitant of this village?" "We haven't got one; we had one, but he died three weeks ago." ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Detlev, > "Correct" threading however uses "References:" mail headers and can cope > with changing subjects. Somehow you seem to know this, as v3 indeed > _has_ such a correct header and thus the threading in my mail reader > works just fine ;) > Yes. I did fix the References and In-reply-to headers. However v3 it doesn't goes to the correct threadning in gmail. :p Anyway. Thanks for your reply. :D -- Best regards, Macpaul Lin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Macpaul, > Hi Detlev, > > 2011/4/27 Detlev Zundel : >> Hi Macpaul, >> >>> clean up with 2.6.38 checkpatch.pl >> >> There is indeed only one non-whitespace hunk in there: >> It's ok that you do the line wrapping, but actually with such lists we >> require alphabetical sorting of the clauses, so can you please juggle >> the list so that the "XILINX_405" gets to the end? > > Since I've correct the subject of this patch v3 according to the > "cosmetic" rule, > it seems patch v3 is out of this mailing thread. This change of the subject was the reason why I did not require you changing it as I know that Wolfgang currently matches patch versions by subject strings. "Correct" threading however uses "References:" mail headers and can cope with changing subjects. Somehow you seem to know this, as v3 indeed _has_ such a correct header and thus the threading in my mail reader works just fine ;) Cheers Detlev -- 0x2B | ~0x2B -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Detlev, 2011/4/27 Detlev Zundel : > Hi Macpaul, > >> clean up with 2.6.38 checkpatch.pl > > There is indeed only one non-whitespace hunk in there: > It's ok that you do the line wrapping, but actually with such lists we > require alphabetical sorting of the clauses, so can you please juggle > the list so that the "XILINX_405" gets to the end? Since I've correct the subject of this patch v3 according to the "cosmetic" rule, it seems patch v3 is out of this mailing thread. So I remind you the patch v3 is here. http://patchwork.ozlabs.org/patch/93169/ Thanks! -- Best regards, Macpaul Lin ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Hi Macpaul,
> clean up with 2.6.38 checkpatch.pl
There is indeed only one non-whitespace hunk in there:
@@ -69,8 +69,9 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char *
const argv[])
defined(CONFIG_440SP) || defined(CONFIG_440SPE)
print_str ("procfreq", strmhz(buf, bd->bi_procfreq));
print_str ("plb_busfreq", strmhz(buf, bd->bi_plb_busfreq));
-#if defined(CONFIG_405GP) || defined(CONFIG_405EP) ||
defined(CONFIG_XILINX_405) || \
-defined(CONFIG_440EP) || defined(CONFIG_440GR) || defined(CONFIG_440SPE)
|| \
+#ifdefined(CONFIG_405GP) || defined(CONFIG_405EP) || \
+ defined(CONFIG_XILINX_405) || defined(CONFIG_440EP) || \
+ defined(CONFIG_440GR) || defined(CONFIG_440SPE) || \
defined(CONFIG_440EPX) || defined(CONFIG_440GRX)
print_str ("pci_busfreq", strmhz(buf, bd->bi_pci_busfreq));
#endif
It's ok that you do the line wrapping, but actually with such lists we
require alphabetical sorting of the clauses, so can you please juggle
the list so that the "XILINX_405" gets to the end?
Thanks!
Detlev
--
The continental people think life is a game. The English think
cricket is a game.
-- George Mikes
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
clean up with 2.6.38 checkpatch.pl
Signed-off-by: Macpaul Lin
---
Changes for v2:
- Correct the subject field to single patch.
common/cmd_bdinfo.c | 295 ++-
1 files changed, 148 insertions(+), 147 deletions(-)
diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
index 1d76ffa..6215e7c 100644
--- a/common/cmd_bdinfo.c
+++ b/common/cmd_bdinfo.c
@@ -42,56 +42,57 @@ static void print_lnum(const char *, u64);
#if defined(CONFIG_PPC)
static void print_str(const char *, const char *);
-int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
bd_t *bd = gd->bd;
char buf[32];
#ifdef DEBUG
- print_num ("bd address",(ulong)bd );
-#endif
- print_num ("memstart", bd->bi_memstart );
- print_lnum ("memsize", bd->bi_memsize );
- print_num ("flashstart",bd->bi_flashstart );
- print_num ("flashsize", bd->bi_flashsize);
- print_num ("flashoffset", bd->bi_flashoffset );
- print_num ("sramstart", bd->bi_sramstart);
- print_num ("sramsize", bd->bi_sramsize );
-#if defined(CONFIG_5xx) || defined(CONFIG_8xx) || \
-defined(CONFIG_8260) || defined(CONFIG_E500)
- print_num ("immr_base", bd->bi_immr_base);
-#endif
- print_num ("bootflags", bd->bi_bootflags);
-#if defined(CONFIG_405GP) || defined(CONFIG_405CR) || \
-defined(CONFIG_405EP) || defined(CONFIG_XILINX_405) || \
-defined(CONFIG_440EP) || defined(CONFIG_440GR) || \
-defined(CONFIG_440EPX) || defined(CONFIG_440GRX) ||\
-defined(CONFIG_440SP) || defined(CONFIG_440SPE)
- print_str ("procfreq", strmhz(buf, bd->bi_procfreq));
- print_str ("plb_busfreq", strmhz(buf, bd->bi_plb_busfreq));
-#if defined(CONFIG_405GP) || defined(CONFIG_405EP) ||
defined(CONFIG_XILINX_405) || \
-defined(CONFIG_440EP) || defined(CONFIG_440GR) || defined(CONFIG_440SPE)
|| \
-defined(CONFIG_440EPX) || defined(CONFIG_440GRX)
- print_str ("pci_busfreq", strmhz(buf, bd->bi_pci_busfreq));
+ print_num("bd address", (ulong)bd);
+#endif
+ print_num("memstart", bd->bi_memstart);
+ print_lnum("memsize", bd->bi_memsize);
+ print_num("flashstart", bd->bi_flashstart);
+ print_num("flashsize", bd->bi_flashsize);
+ print_num("flashoffset",bd->bi_flashoffset);
+ print_num("sramstart", bd->bi_sramstart);
+ print_num("sramsize", bd->bi_sramsize);
+#ifdefined(CONFIG_5xx) || defined(CONFIG_8xx) || \
+ defined(CONFIG_8260) || defined(CONFIG_E500)
+ print_num("immr_base", bd->bi_immr_base);
+#endif
+ print_num("bootflags", bd->bi_bootflags);
+#ifdefined(CONFIG_405GP) || defined(CONFIG_405CR) || \
+ defined(CONFIG_405EP) || defined(CONFIG_XILINX_405) || \
+ defined(CONFIG_440EP) || defined(CONFIG_440GR) || \
+ defined(CONFIG_440EPX) || defined(CONFIG_440GRX) || \
+ defined(CONFIG_440SP) || defined(CONFIG_440SPE)
+ print_str("procfreq", strmhz(buf, bd->bi_procfreq));
+ print_str("plb_busfreq",strmhz(buf, bd->bi_plb_busfreq));
+#ifdefined(CONFIG_405GP) || defined(CONFIG_405EP) || \
+ defined(CONFIG_XILINX_405) || defined(CONFIG_440EP) || \
+ defined(CONFIG_440GR) || defined(CONFIG_440SPE) || \
+ defined(CONFIG_440EPX) || defined(CONFIG_440GRX)
+ print_str("pci_busfreq",strmhz(buf, bd->bi_pci_busfreq));
#endif
#else /* ! CONFIG_405GP, CONFIG_405CR, CONFIG_405EP, CONFIG_XILINX_405,
CONFIG_440EP CONFIG_440GR */
#if defined(CONFIG_CPM2)
- print_str ("vco", strmhz(buf, bd->bi_vco));
- print_str ("sccfreq", strmhz(buf, bd->bi_sccfreq));
- print_str ("brgfreq", strmhz(buf, bd->bi_brgfreq));
+ print_str("vco",strmhz(buf, bd->bi_vco));
+ print_str("sccfreq",strmhz(buf, bd->bi_sccfreq));
+ print_str("brgfreq",strmhz(buf, bd->bi_brgfreq));
#endif
- print_str ("intfreq", strmhz(buf, bd->bi_intfreq));
+ print_str("intfreq",strmhz(buf, bd->bi_intfreq));
#if defined(CONFIG_CPM2)
- print_str ("cpmfreq", strmhz(buf, bd->bi_cpmfreq));
+ print_str("cpmfreq",strmhz(buf, bd->bi_cpmfreq));
#endif
- print_str ("busfreq", strmhz(buf, bd->bi_busfreq));
+ print_str("busfreq",strmhz(buf, bd->bi_busfreq));
#endif /* CONFIG_405GP, CONFIG_405CR, CONFIG_405EP, CONFIG_XILINX_405,
CONFIG_440EP CONFIG_440GR */
#if defined(CONFIG_MPC8220)
- print_str ("inpfreq", strmhz(buf, bd->bi_inpfreq));
- print_str ("flbfreq", strmhz(buf, bd->bi_flbfreq));
- print_str ("pcifreq", strmhz(buf, bd->bi_pcifreq));
-
