[U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type

2016-07-19 Thread Ziyuan Xu 
From: Xu Ziyuan 

It's nicer to see this:

=> mmc list
dwmmc@ff0c: 0
dwmmc@ff0f: 1 (eMMC)

than this:

=> mmc list
dwmmc@ff0c: 0dwmmc@ff0f: 1 (eMMC)

With the latter, it's much clearer which mmc devices are on.

Signed-off-by: Ziyuan Xu 

Serise-changes: 2
- Update commit from Jaehoon

Signed-off-by: Ziyuan Xu 
---

 drivers/mmc/mmc-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
index 38ced41..beebc70 100644
--- a/drivers/mmc/mmc-uclass.c
+++ b/drivers/mmc/mmc-uclass.c
@@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
 
for (uclass_first_device(UCLASS_MMC, &dev);
 dev;
-uclass_next_device(&dev)) {
+uclass_next_device(&dev), first = false) {
struct mmc *m = mmc_get_mmc_dev(dev);
 
if (!first) {
-- 
1.9.1


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type

2016-07-20 Thread Jaehoon Chung 
Hi Ziyuan,

On 07/19/2016 11:21 PM, Ziyuan Xu wrote:
> From: Xu Ziyuan 
> 
> It's nicer to see this:
> 
> => mmc list
> dwmmc@ff0c: 0
> dwmmc@ff0f: 1 (eMMC)
> 
> than this:
> 
> => mmc list
> dwmmc@ff0c: 0dwmmc@ff0f: 1 (eMMC)
> 
> With the latter, it's much clearer which mmc devices are on.

Right? "With latter"?

> 
> Signed-off-by: Ziyuan Xu 
> 
> Serise-changes: 2
> - Update commit from Jaehoon

Could you add the Changelog to the below line?

> 
> Signed-off-by: Ziyuan Xu 
> ---

Locate the Changelog at here.

Best Regards,
Jaehoon Chung

> 
>  drivers/mmc/mmc-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
> index 38ced41..beebc70 100644
> --- a/drivers/mmc/mmc-uclass.c
> +++ b/drivers/mmc/mmc-uclass.c
> @@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
>  
>   for (uclass_first_device(UCLASS_MMC, &dev);
>dev;
> -  uclass_next_device(&dev)) {
> +  uclass_next_device(&dev), first = false) {
>   struct mmc *m = mmc_get_mmc_dev(dev);
>  
>   if (!first) {
> 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type

2016-07-21 Thread Simon Glass 
On 19 July 2016 at 08:21, Ziyuan Xu  wrote:
> From: Xu Ziyuan 
>
> It's nicer to see this:
>
> => mmc list
> dwmmc@ff0c: 0
> dwmmc@ff0f: 1 (eMMC)
>
> than this:
>
> => mmc list
> dwmmc@ff0c: 0dwmmc@ff0f: 1 (eMMC)
>
> With the latter, it's much clearer which mmc devices are on.
>
> Signed-off-by: Ziyuan Xu 
>
> Serise-changes: 2
> - Update commit from Jaehoon
>
> Signed-off-by: Ziyuan Xu 
> ---
>
>  drivers/mmc/mmc-uclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the bug fix.

Acked-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type

2016-07-22 Thread Simon Glass 
Hi,

On 21 July 2016 at 21:21, Simon Glass  wrote:
> On 19 July 2016 at 08:21, Ziyuan Xu  wrote:
>> From: Xu Ziyuan 
>>
>> It's nicer to see this:
>>
>> => mmc list
>> dwmmc@ff0c: 0
>> dwmmc@ff0f: 1 (eMMC)
>>
>> than this:
>>
>> => mmc list
>> dwmmc@ff0c: 0dwmmc@ff0f: 1 (eMMC)
>>
>> With the latter, it's much clearer which mmc devices are on.
>>
>> Signed-off-by: Ziyuan Xu 
>>
>> Serise-changes: 2
>> - Update commit from Jaehoon
>>
>> Signed-off-by: Ziyuan Xu 
>> ---
>>
>>  drivers/mmc/mmc-uclass.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks for the bug fix.
>
> Acked-by: Simon Glass 

Please can you send a v2 with the nits fixed?

- Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type

2016-07-22 Thread Ziyuan Xu 

Hi Jaehoon,

Thanks for your catch, fix it in v3.

On 2016年07月21日 10:11, Jaehoon Chung wrote:

Hi Ziyuan,

On 07/19/2016 11:21 PM, Ziyuan Xu wrote:

From: Xu Ziyuan 

It's nicer to see this:

=> mmc list
dwmmc@ff0c: 0
dwmmc@ff0f: 1 (eMMC)

than this:

=> mmc list
dwmmc@ff0c: 0dwmmc@ff0f: 1 (eMMC)

With the latter, it's much clearer which mmc devices are on.

Right? "With latter"?


Signed-off-by: Ziyuan Xu 

Serise-changes: 2
- Update commit from Jaehoon

Could you add the Changelog to the below line?


Signed-off-by: Ziyuan Xu 
---

Locate the Changelog at here.

Best Regards,
Jaehoon Chung


  drivers/mmc/mmc-uclass.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c
index 38ced41..beebc70 100644
--- a/drivers/mmc/mmc-uclass.c
+++ b/drivers/mmc/mmc-uclass.c
@@ -169,7 +169,7 @@ void print_mmc_devices(char separator)
  
  	for (uclass_first_device(UCLASS_MMC, &dev);

 dev;
-uclass_next_device(&dev)) {
+uclass_next_device(&dev), first = false) {
struct mmc *m = mmc_get_mmc_dev(dev);
  
  		if (!first) {









___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2] mmc: display mmc list information like mmc_legacy type

2016-07-22 Thread Ziyuan Xu 

Hi Simon,


On 2016年07月23日 10:57, Simon Glass wrote:

Hi,

On 21 July 2016 at 21:21, Simon Glass  wrote:

On 19 July 2016 at 08:21, Ziyuan Xu  wrote:

From: Xu Ziyuan 

It's nicer to see this:

=> mmc list
dwmmc@ff0c: 0
dwmmc@ff0f: 1 (eMMC)

than this:

=> mmc list
dwmmc@ff0c: 0dwmmc@ff0f: 1 (eMMC)

With the latter, it's much clearer which mmc devices are on.

Signed-off-by: Ziyuan Xu 

Serise-changes: 2
- Update commit from Jaehoon

Signed-off-by: Ziyuan Xu 
---

  drivers/mmc/mmc-uclass.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the bug fix.

Acked-by: Simon Glass 

Please can you send a v2 with the nits fixed?

Fixed, see v3.


- Simon






___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot