Re: [U-Boot] [PATCH v2 0/5] arm, am33xx: update for the am33xx based siemens boards
Hi Heiko, On Mon, Nov 4, 2013 at 10:30 PM, Heiko Schocher h...@denx.de wrote: Hello Vaibhav Bedia, Am 04.11.2013 20:45, schrieb Vaibhav Bedia: Hi Marek, On Mon, Nov 4, 2013 at 12:34 PM, Marek Vasutma...@denx.de wrote: Dear Vaibhav Bedia, On Mon, Nov 4, 2013 at 8:15 AM, Heiko Schocherh...@denx.de wrote: [...] Hups, missed this EMail ... :-( No problem. Happens all the time :) Hmm.. some boards from siemens do not use the RTC, so this approach is not possible here ... By unused do you mean it's not powered up or is it simply not programmed? Even if the RTC is not programmed the register would still be there. I don't have a board with me to check the behavior but i am guessing the RTC functionality doesn't need to be used to make use of the scratchpad registers. If your hardware's IP block's clock are not ungated, the register access to that IP block will usually not work. Yes, i understand that. However, in this case AFAICT the interface clock is always present and hence it should be possible to use the RTC registers. Moreover, i just noticed Tom applied a bootcount patch for AM335x [1] which does use the scratchpad register that i am pointing to. So unless there's some other board level difference that i am missing it should work. We see for example on the dxr2 board, that we cannot access the RTC registers ... also, they use it on other boards without RTC and all siemens boards should have the same manner. There is also a possibility to disable the RTC on am335x based boards, see: http://processors.wiki.ti.com/index.php/AM335x_Schematic_Checklist#RTC Yeah, if the RTC is completely disabled as documented above then the registers can't be accessed. In other cases i would expect the register access to still work. I just wanted to make sure that the usage of RTC for the bootcount has been considered. With the recent changes by Tom at least the other AM335x platforms use it so that's good. If it's about keeping the approaches consistent on the Siemens boards then i am fine with this. Regards, Vaibhav ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/5] arm, am33xx: update for the am33xx based siemens boards
Hi Heiko, On Mon, Nov 4, 2013 at 2:02 AM, Heiko Schocher h...@denx.de wrote: Patch 1 introduces bootcount support for the 3 siemens boards. As there is no other possibility on this boards, the bootcounter is stored in the environment. To prevent a saveenv on all reboots, a upgrade_available U-Boot Environment variable is introduced. I must be missing something here but as commented on v1 [1], could you clarify why the scratchpad register in RTC that should be persistent is not used? Regards, Vaibhav [1] http://www.mail-archive.com/u-boot@lists.denx.de/msg124429.html ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/5] arm, am33xx: update for the am33xx based siemens boards
Hello Bedia, Am 04.11.2013 13:45, schrieb Vaibhav Bedia: Hi Heiko, On Mon, Nov 4, 2013 at 2:02 AM, Heiko Schocherh...@denx.de wrote: Patch 1 introduces bootcount support for the 3 siemens boards. As there is no other possibility on this boards, the bootcounter is stored in the environment. To prevent a saveenv on all reboots, a upgrade_available U-Boot Environment variable is introduced. I must be missing something here but as commented on v1 [1], could you clarify why the scratchpad register in RTC that should be persistent is not used? Regards, Vaibhav [1] http://www.mail-archive.com/u-boot@lists.denx.de/msg124429.html Hups, missed this EMail ... :-( Hmm.. some boards from siemens do not use the RTC, so this approach is not possible here ... bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/5] arm, am33xx: update for the am33xx based siemens boards
On Mon, Nov 4, 2013 at 8:15 AM, Heiko Schocher h...@denx.de wrote: [...] Hups, missed this EMail ... :-( No problem. Happens all the time :) Hmm.. some boards from siemens do not use the RTC, so this approach is not possible here ... By unused do you mean it's not powered up or is it simply not programmed? Even if the RTC is not programmed the register would still be there. I don't have a board with me to check the behavior but i am guessing the RTC functionality doesn't need to be used to make use of the scratchpad registers. Regards, Vaibhav ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/5] arm, am33xx: update for the am33xx based siemens boards
Dear Vaibhav Bedia, On Mon, Nov 4, 2013 at 8:15 AM, Heiko Schocher h...@denx.de wrote: [...] Hups, missed this EMail ... :-( No problem. Happens all the time :) Hmm.. some boards from siemens do not use the RTC, so this approach is not possible here ... By unused do you mean it's not powered up or is it simply not programmed? Even if the RTC is not programmed the register would still be there. I don't have a board with me to check the behavior but i am guessing the RTC functionality doesn't need to be used to make use of the scratchpad registers. If your hardware's IP block's clock are not ungated, the register access to that IP block will usually not work. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/5] arm, am33xx: update for the am33xx based siemens boards
Hi Marek, On Mon, Nov 4, 2013 at 12:34 PM, Marek Vasut ma...@denx.de wrote: Dear Vaibhav Bedia, On Mon, Nov 4, 2013 at 8:15 AM, Heiko Schocher h...@denx.de wrote: [...] Hups, missed this EMail ... :-( No problem. Happens all the time :) Hmm.. some boards from siemens do not use the RTC, so this approach is not possible here ... By unused do you mean it's not powered up or is it simply not programmed? Even if the RTC is not programmed the register would still be there. I don't have a board with me to check the behavior but i am guessing the RTC functionality doesn't need to be used to make use of the scratchpad registers. If your hardware's IP block's clock are not ungated, the register access to that IP block will usually not work. Yes, i understand that. However, in this case AFAICT the interface clock is always present and hence it should be possible to use the RTC registers. Moreover, i just noticed Tom applied a bootcount patch for AM335x [1] which does use the scratchpad register that i am pointing to. So unless there's some other board level difference that i am missing it should work. Regards, Vaibhav [1] http://lists.denx.de/pipermail/u-boot/2013-August/161593.html ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 0/5] arm, am33xx: update for the am33xx based siemens boards
Hello Vaibhav Bedia, Am 04.11.2013 20:45, schrieb Vaibhav Bedia: Hi Marek, On Mon, Nov 4, 2013 at 12:34 PM, Marek Vasutma...@denx.de wrote: Dear Vaibhav Bedia, On Mon, Nov 4, 2013 at 8:15 AM, Heiko Schocherh...@denx.de wrote: [...] Hups, missed this EMail ... :-( No problem. Happens all the time :) Hmm.. some boards from siemens do not use the RTC, so this approach is not possible here ... By unused do you mean it's not powered up or is it simply not programmed? Even if the RTC is not programmed the register would still be there. I don't have a board with me to check the behavior but i am guessing the RTC functionality doesn't need to be used to make use of the scratchpad registers. If your hardware's IP block's clock are not ungated, the register access to that IP block will usually not work. Yes, i understand that. However, in this case AFAICT the interface clock is always present and hence it should be possible to use the RTC registers. Moreover, i just noticed Tom applied a bootcount patch for AM335x [1] which does use the scratchpad register that i am pointing to. So unless there's some other board level difference that i am missing it should work. We see for example on the dxr2 board, that we cannot access the RTC registers ... also, they use it on other boards without RTC and all siemens boards should have the same manner. There is also a possibility to disable the RTC on am335x based boards, see: http://processors.wiki.ti.com/index.php/AM335x_Schematic_Checklist#RTC bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 0/5] arm, am33xx: update for the am33xx based siemens boards
Patch 1 introduces bootcount support for the 3 siemens boards. As there is no other possibility on this boards, the bootcounter is stored in the environment. To prevent a saveenv on all reboots, a upgrade_available U-Boot Environment variable is introduced. Patch 2 makes the enabling of the RTC32K OSC configurable, as on the dxr2 board it is not used, and http://www.denx.de/wiki/view/U-Boot/DesignPrinciples#2_Keep_it_Fast says not enable things not used ... Patch 3 adds an option to set the iSerialNumber board specific, which is used on the 3 siemens boards. Patch 4 adds an option to set the bcdDevice number board specific, which is used on the 3 siemens boards. Patch 5 contains a lot of updates for the siemens boards, see commit message for detailed information. already posted patches on which this patchserie is based: [U-Boot,v4] i2c, omap24xx: convert driver to new mutlibus/mutliadapter framework http://patchwork.ozlabs.org/patch/285390/ [U-Boot] video, cfb_console: make background and foreground color configurable http://patchwork.ozlabs.org/patch/285385/ [U-Boot] video, formike: change tag/val write http://patchwork.ozlabs.org/patch/285386/ [U-Boot] net, phy: fix AR8031 phy_mask http://patchwork.ozlabs.org/patch/276944/ [U-Boot,2/3] net, phy: fix NULL pointer deference http://patchwork.ozlabs.org/patch/272797/ changes for v2: - added comments from Lukasz Majewski for the USB DFU related parts Heiko Schocher (4): bootcount: store bootcount var in environment arm, am33x: make RTC32K OSC enable configurable usb, g_dnl: make iSerialNumber board configurable usb, g_dnl: make bcdDevice value configurable Samuel Egli (1): arm, am335x: update for the siemens boards README | 19 arch/arm/cpu/armv7/am33xx/board.c | 4 + board/siemens/common/factoryset.c | 24 - board/siemens/common/factoryset.h | 2 + board/siemens/dxr2/board.c | 11 +-- board/siemens/dxr2/board.h | 9 +- board/siemens/dxr2/mux.c | 158 + board/siemens/pxm2/board.c | 3 +- board/siemens/rut/board.c | 51 +-- drivers/bootcount/Makefile | 1 + drivers/bootcount/bootcount_env.c | 29 ++ drivers/usb/gadget/g_dnl.c | 43 - include/configs/dxr2.h | 13 ++- include/configs/pxm2.h | 7 +- include/configs/rut.h | 10 ++- include/configs/siemens-am33x-common.h | 69 ++ include/configs/ti_am335x_common.h | 1 + include/g_dnl.h| 1 + 18 files changed, 399 insertions(+), 56 deletions(-) create mode 100644 drivers/bootcount/bootcount_env.c Cc: Tom Rini tr...@ti.com Cc: Marek Vasut marek.va...@gmail.com Cc: Lukasz Majewski l.majew...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Samuel Egli samuel.e...@siemens.com Cc: Pascal Bach pascal.b...@siemens.com Cc: Roger Meier r.me...@siemens.com Cc: Matthias Michel matthias.mic...@siemens.com -- 1.8.3.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
