Re: [U-Boot] [PATCH v2 00/18] autoboot: Tidy up autoboot code

2019-08-02 Thread Tom Rini
On Sat, Jul 20, 2019 at 08:51:10PM -0600, Simon Glass wrote:

> This series cleans up autoboot.c a bit to:
> 
> - Convert options to Kconfig
> - Use C code instead of C preprocessor where possible
> - Add a few comments
> 
> Changes in v2:
> - Rebase to master
> 
> Simon Glass (18):
>   main: Use conditional run_preboot_environment_command()
>   Convert CONFIG_SHOW_BOOT_PROGRESS to Kconfig
>   Add CONFIG_USE_PREBOOT to boards that use CONFIG_PREBOOT
>   Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to Kconfig
>   autoboot: Use CONFIG_AUTOBOOT_STOP_STR_SHA256 indirectly
>   autoboot: Drop #ifdef for CONFIG_AUTOBOOT_ENCRYPTION
>   autoboot: Improve docs for CONFIG_AUTOBOOT_ENCRYPTION
>   autoboot: Use if() for CONFIG_SILENT_CONSOLE
>   autoboot: Drop #ifdef CONFIG_AUTOBOOT_KEYED
>   autoboot: Drop unused CONFIG_MENUPROMPT
>   autoboot: Rename CONFIG_MENUKEY to CONFIG_AUTOBOOT_MENUKEY
>   snow: Define CONFIG_AUTOBOOT_MENUKEY
>   autoboot: Tidy up use of menukey
>   autoboot: Rename CONFIG_MENU_SHOW to include AUTOBOOT
>   Convert CONFIG_AUTOBOOT_MENU_SHOW to Kconfig
>   autoboot: Add comments for menu_show()
>   autoboot: Move a few more options from #ifdef to if()
>   autoboot: Adjust the implementation in autoboot_command()

For the series, applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH v2 00/18] autoboot: Tidy up autoboot code

2019-07-23 Thread Lukasz Majewski
Hi Simon,

> This series cleans up autoboot.c a bit to:
> 
> - Convert options to Kconfig
> - Use C code instead of C preprocessor where possible
> - Add a few comments
> 

Thanks Simon for this clean up series.

Reviewed-by: Lukasz Majewski 

> Changes in v2:
> - Rebase to master
> 
> Simon Glass (18):
>   main: Use conditional run_preboot_environment_command()
>   Convert CONFIG_SHOW_BOOT_PROGRESS to Kconfig
>   Add CONFIG_USE_PREBOOT to boards that use CONFIG_PREBOOT
>   Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to Kconfig
>   autoboot: Use CONFIG_AUTOBOOT_STOP_STR_SHA256 indirectly
>   autoboot: Drop #ifdef for CONFIG_AUTOBOOT_ENCRYPTION
>   autoboot: Improve docs for CONFIG_AUTOBOOT_ENCRYPTION
>   autoboot: Use if() for CONFIG_SILENT_CONSOLE
>   autoboot: Drop #ifdef CONFIG_AUTOBOOT_KEYED
>   autoboot: Drop unused CONFIG_MENUPROMPT
>   autoboot: Rename CONFIG_MENUKEY to CONFIG_AUTOBOOT_MENUKEY
>   snow: Define CONFIG_AUTOBOOT_MENUKEY
>   autoboot: Tidy up use of menukey
>   autoboot: Rename CONFIG_MENU_SHOW to include AUTOBOOT
>   Convert CONFIG_AUTOBOOT_MENU_SHOW to Kconfig
>   autoboot: Add comments for menu_show()
>   autoboot: Move a few more options from #ifdef to if()
>   autoboot: Adjust the implementation in autoboot_command()
> 
>  README| 167
> +- cmd/Kconfig   |
> 34 +++- cmd/bootmenu.c|   2 +-
>  common/Kconfig| 162 +
>  common/autoboot.c | 121 +++--
>  common/main.c |   5 +-
>  configs/A10-OLinuXino-Lime_defconfig  |   1 +
>  configs/A10s-OLinuXino-M_defconfig|   1 +
>  configs/A13-OLinuXinoM_defconfig  |   1 +
>  configs/A13-OLinuXino_defconfig   |   1 +
>  configs/A20-OLinuXino-Lime2-eMMC_defconfig|   1 +
>  configs/A20-OLinuXino-Lime2_defconfig |   1 +
>  configs/A20-OLinuXino-Lime_defconfig  |   1 +
>  configs/A20-OLinuXino_MICRO-eMMC_defconfig|   1 +
>  configs/A20-OLinuXino_MICRO_defconfig |   1 +
>  configs/A20-Olimex-SOM-EVB_defconfig  |   1 +
>  configs/A20-Olimex-SOM204-EVB-eMMC_defconfig  |   1 +
>  configs/A20-Olimex-SOM204-EVB_defconfig   |   1 +
>  configs/A33-OLinuXino_defconfig   |   1 +
>  configs/Ainol_AW1_defconfig   |   1 +
>  configs/Ampe_A76_defconfig|   1 +
>  configs/Auxtek-T003_defconfig |   1 +
>  configs/Auxtek-T004_defconfig |   1 +
>  configs/Bananapi_M2_Ultra_defconfig   |   1 +
>  configs/Bananapi_defconfig|   1 +
>  configs/Bananapi_m2m_defconfig|   1 +
>  configs/Bananapro_defconfig   |   1 +
>  configs/CHIP_defconfig|   1 +
>  configs/CHIP_pro_defconfig|   1 +
>  configs/CSQ_CS908_defconfig   |   1 +
>  configs/Chuwi_V7_CW0825_defconfig |   1 +
>  configs/Colombus_defconfig|   1 +
>  configs/Cubieboard2_defconfig |   1 +
>  configs/Cubieboard4_defconfig |   1 +
>  configs/Cubieboard_defconfig  |   1 +
>  configs/Cubietruck_defconfig  |   1 +
>  configs/Cubietruck_plus_defconfig |   1 +
>  configs/Empire_electronix_d709_defconfig  |   1 +
>  configs/Empire_electronix_m712_defconfig  |   1 +
>  configs/Hummingbird_A31_defconfig |   1 +
>  configs/Hyundai_A7HD_defconfig|   1 +
>  configs/Itead_Ibox_A20_defconfig  |   1 +
>  configs/Lamobo_R1_defconfig   |   1 +
>  configs/LicheePi_Zero_defconfig   |   1 +
>  configs/Linksprite_pcDuino3_Nano_defconfig|   1 +
>  configs/Linksprite_pcDuino3_defconfig |   1 +
>  configs/Linksprite_pcDuino_defconfig  |   1 +
>  configs/MK808C_defconfig  |   1 +
>  configs/MPC8349EMDS_PCI64_defconfig   |   2 +
>  configs/MPC8349EMDS_SLAVE_defconfig   |   2 +
>  configs/MPC8349EMDS_defconfig |   2 +
>  configs/MSI_Primo73_defconfig |   1 +
>  configs/MSI_Primo81_defconfig |   1 +
>  configs/Marsboard_A10_defconfig   |   1 +
>  configs/Mele_A1000G_quad_defconfig|   1 +
>  configs/Mele_A1000_defconfig  |   1 +
>  configs/Mele_I7_defconfig |   1 +
>  configs/Mele_M3_defconfig |   1 +
>  configs/Mele_M5_defconfig |   1 +
>  configs/Mele_M9_defconfig |   1 +
>  configs/Merrii_A80_Optimus_defconfig  |   1 +
>  configs/Mini-X_defconfig  |   1 +
>  .../Nintendo_NES_Classic_Edition_defconfig|   1 +
>  configs/Orangepi_defconfig|   1 +
>  configs/Orangepi_mini_defconfig   

[U-Boot] [PATCH v2 00/18] autoboot: Tidy up autoboot code

2019-07-20 Thread Simon Glass
This series cleans up autoboot.c a bit to:

- Convert options to Kconfig
- Use C code instead of C preprocessor where possible
- Add a few comments

Changes in v2:
- Rebase to master

Simon Glass (18):
  main: Use conditional run_preboot_environment_command()
  Convert CONFIG_SHOW_BOOT_PROGRESS to Kconfig
  Add CONFIG_USE_PREBOOT to boards that use CONFIG_PREBOOT
  Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to Kconfig
  autoboot: Use CONFIG_AUTOBOOT_STOP_STR_SHA256 indirectly
  autoboot: Drop #ifdef for CONFIG_AUTOBOOT_ENCRYPTION
  autoboot: Improve docs for CONFIG_AUTOBOOT_ENCRYPTION
  autoboot: Use if() for CONFIG_SILENT_CONSOLE
  autoboot: Drop #ifdef CONFIG_AUTOBOOT_KEYED
  autoboot: Drop unused CONFIG_MENUPROMPT
  autoboot: Rename CONFIG_MENUKEY to CONFIG_AUTOBOOT_MENUKEY
  snow: Define CONFIG_AUTOBOOT_MENUKEY
  autoboot: Tidy up use of menukey
  autoboot: Rename CONFIG_MENU_SHOW to include AUTOBOOT
  Convert CONFIG_AUTOBOOT_MENU_SHOW to Kconfig
  autoboot: Add comments for menu_show()
  autoboot: Move a few more options from #ifdef to if()
  autoboot: Adjust the implementation in autoboot_command()

 README| 167 +-
 cmd/Kconfig   |  34 +++-
 cmd/bootmenu.c|   2 +-
 common/Kconfig| 162 +
 common/autoboot.c | 121 +++--
 common/main.c |   5 +-
 configs/A10-OLinuXino-Lime_defconfig  |   1 +
 configs/A10s-OLinuXino-M_defconfig|   1 +
 configs/A13-OLinuXinoM_defconfig  |   1 +
 configs/A13-OLinuXino_defconfig   |   1 +
 configs/A20-OLinuXino-Lime2-eMMC_defconfig|   1 +
 configs/A20-OLinuXino-Lime2_defconfig |   1 +
 configs/A20-OLinuXino-Lime_defconfig  |   1 +
 configs/A20-OLinuXino_MICRO-eMMC_defconfig|   1 +
 configs/A20-OLinuXino_MICRO_defconfig |   1 +
 configs/A20-Olimex-SOM-EVB_defconfig  |   1 +
 configs/A20-Olimex-SOM204-EVB-eMMC_defconfig  |   1 +
 configs/A20-Olimex-SOM204-EVB_defconfig   |   1 +
 configs/A33-OLinuXino_defconfig   |   1 +
 configs/Ainol_AW1_defconfig   |   1 +
 configs/Ampe_A76_defconfig|   1 +
 configs/Auxtek-T003_defconfig |   1 +
 configs/Auxtek-T004_defconfig |   1 +
 configs/Bananapi_M2_Ultra_defconfig   |   1 +
 configs/Bananapi_defconfig|   1 +
 configs/Bananapi_m2m_defconfig|   1 +
 configs/Bananapro_defconfig   |   1 +
 configs/CHIP_defconfig|   1 +
 configs/CHIP_pro_defconfig|   1 +
 configs/CSQ_CS908_defconfig   |   1 +
 configs/Chuwi_V7_CW0825_defconfig |   1 +
 configs/Colombus_defconfig|   1 +
 configs/Cubieboard2_defconfig |   1 +
 configs/Cubieboard4_defconfig |   1 +
 configs/Cubieboard_defconfig  |   1 +
 configs/Cubietruck_defconfig  |   1 +
 configs/Cubietruck_plus_defconfig |   1 +
 configs/Empire_electronix_d709_defconfig  |   1 +
 configs/Empire_electronix_m712_defconfig  |   1 +
 configs/Hummingbird_A31_defconfig |   1 +
 configs/Hyundai_A7HD_defconfig|   1 +
 configs/Itead_Ibox_A20_defconfig  |   1 +
 configs/Lamobo_R1_defconfig   |   1 +
 configs/LicheePi_Zero_defconfig   |   1 +
 configs/Linksprite_pcDuino3_Nano_defconfig|   1 +
 configs/Linksprite_pcDuino3_defconfig |   1 +
 configs/Linksprite_pcDuino_defconfig  |   1 +
 configs/MK808C_defconfig  |   1 +
 configs/MPC8349EMDS_PCI64_defconfig   |   2 +
 configs/MPC8349EMDS_SLAVE_defconfig   |   2 +
 configs/MPC8349EMDS_defconfig |   2 +
 configs/MSI_Primo73_defconfig |   1 +
 configs/MSI_Primo81_defconfig |   1 +
 configs/Marsboard_A10_defconfig   |   1 +
 configs/Mele_A1000G_quad_defconfig|   1 +
 configs/Mele_A1000_defconfig  |   1 +
 configs/Mele_I7_defconfig |   1 +
 configs/Mele_M3_defconfig |   1 +
 configs/Mele_M5_defconfig |   1 +
 configs/Mele_M9_defconfig |   1 +
 configs/Merrii_A80_Optimus_defconfig  |   1 +
 configs/Mini-X_defconfig  |   1 +
 .../Nintendo_NES_Classic_Edition_defconfig|   1 +
 configs/Orangepi_defconfig|   1 +
 configs/Orangepi_mini_defconfig   |   1 +
 configs/Sinlinx_SinA31s_defconfig |   1 +
 configs/Sinlinx_SinA33_defconfig  |   1 +
 configs/Sinovoip_BPI_M2_defconfig |   1 +
 configs/Sinovoip_BPI_M3_defconfig |   1 +