Re: [U-Boot] [PATCH v2 01/18] dm: ns16550: Support CONFIG_SYS_NS16550_MEM32 with driver model

2015-06-11 Thread Simon Glass
On 12 May 2015 at 14:55, Simon Glass s...@chromium.org wrote:
 This option is used by some boards, so support it with driver model. This
 is really ugly - we should rewrite this driver once all users are moved to
 driver model.

 Signed-off-by: Simon Glass s...@chromium.org
 ---

 Changes in v2:
 - Simplify the support for CONFIG_SYS_NS16550_MEM32

  drivers/serial/ns16550.c | 4 
  include/ns16550.h| 2 +-
  2 files changed, 5 insertions(+), 1 deletion(-)

Applied to u-boot-dm.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v2 01/18] dm: ns16550: Support CONFIG_SYS_NS16550_MEM32 with driver model

2015-05-12 Thread Simon Glass
This option is used by some boards, so support it with driver model. This
is really ugly - we should rewrite this driver once all users are moved to
driver model.

Signed-off-by: Simon Glass s...@chromium.org
---

Changes in v2:
- Simplify the support for CONFIG_SYS_NS16550_MEM32

 drivers/serial/ns16550.c | 4 
 include/ns16550.h| 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 3d376d7..9b044a3 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -65,6 +65,8 @@ static inline void serial_out_shift(void *addr, int shift, 
int value)
out_le32(addr, value);
 #elif defined(CONFIG_SYS_NS16550_MEM32)  defined(CONFIG_SYS_BIG_ENDIAN)
out_be32(addr, value);
+#elif defined(CONFIG_SYS_NS16550_MEM32)
+   writel(value, addr);
 #elif defined(CONFIG_SYS_BIG_ENDIAN)
writeb(value, addr + (1  shift) - 1);
 #else
@@ -80,6 +82,8 @@ static inline int serial_in_shift(void *addr, int shift)
return in_le32(addr);
 #elif defined(CONFIG_SYS_NS16550_MEM32)  defined(CONFIG_SYS_BIG_ENDIAN)
return in_be32(addr);
+#elif defined(CONFIG_SYS_NS16550_MEM32)
+   return readl(addr);
 #elif defined(CONFIG_SYS_BIG_ENDIAN)
return readb(addr + (1  shift) - 1);
 #else
diff --git a/include/ns16550.h b/include/ns16550.h
index 0607379..4e62067 100644
--- a/include/ns16550.h
+++ b/include/ns16550.h
@@ -33,7 +33,7 @@
 
 #if !defined(CONFIG_SYS_NS16550_REG_SIZE) || (CONFIG_SYS_NS16550_REG_SIZE == 0)
 #error Please define NS16550 registers size.
-#elif defined(CONFIG_SYS_NS16550_MEM32)
+#elif defined(CONFIG_SYS_NS16550_MEM32)  !defined(CONFIG_DM_SERIAL)
 #define UART_REG(x) u32 x
 #elif (CONFIG_SYS_NS16550_REG_SIZE  0)
 #define UART_REG(x)   \
-- 
2.2.0.rc0.207.ga3a616c

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot