Re: [U-Boot] [PATCH v2 1/2] regulator: bd71837: copy the bd71837 pmic driver from NXP imx u-boot

2019-04-24 Thread Simon Glass
On Wed, 24 Apr 2019 at 06:35, Matti Vaittinen
 wrote:
>
> https://source.codeaurora.org/external/imx/uboot-imx
>
> cherry picked, styled and merged commits:
> - MLK-18387 pmic: Add pmic driver for BD71837: e9a3bec2e95a
> - MLK-18590 pmic: bd71837: Change to use new fdt API: acdc5c297a96
>
> Signed-off-by: Ye Li 
> Signed-off-by: Matti Vaittinen 
> ---
>
> Changelog v1 => v2:
> - Drop drivers/power/pmic/pmic_bd71837.c (the old PMIC interface)
> - Fix characters in hex numbers to lowercase
>
>  drivers/power/pmic/Kconfig   |  7 +++
>  drivers/power/pmic/Makefile  |  1 +
>  drivers/power/pmic/bd71837.c | 90 
>  include/power/bd71837.h  | 62 +
>  4 files changed, 160 insertions(+)
>  create mode 100644 drivers/power/pmic/bd71837.c
>  create mode 100644 include/power/bd71837.h

Reviewed-by: Simon Glass 

Can you drop fdtdec.h?
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH v2 1/2] regulator: bd71837: copy the bd71837 pmic driver from NXP imx u-boot

2019-04-24 Thread Matti Vaittinen
https://source.codeaurora.org/external/imx/uboot-imx

cherry picked, styled and merged commits:
- MLK-18387 pmic: Add pmic driver for BD71837: e9a3bec2e95a
- MLK-18590 pmic: bd71837: Change to use new fdt API: acdc5c297a96

Signed-off-by: Ye Li 
Signed-off-by: Matti Vaittinen 
---

Changelog v1 => v2:
- Drop drivers/power/pmic/pmic_bd71837.c (the old PMIC interface)
- Fix characters in hex numbers to lowercase

 drivers/power/pmic/Kconfig   |  7 +++
 drivers/power/pmic/Makefile  |  1 +
 drivers/power/pmic/bd71837.c | 90 
 include/power/bd71837.h  | 62 +
 4 files changed, 160 insertions(+)
 create mode 100644 drivers/power/pmic/bd71837.c
 create mode 100644 include/power/bd71837.h

diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig
index 8cf60ebcf3..e154d0a57b 100644
--- a/drivers/power/pmic/Kconfig
+++ b/drivers/power/pmic/Kconfig
@@ -48,6 +48,13 @@ config PMIC_AS3722
  interface and is designs to cover most of the power managementment
  required for a tablets or laptop.
 
+config DM_PMIC_BD71837
+   bool "Enable Driver Model for PMIC BD71837"
+   depends on DM_PMIC
+   help
+ This config enables implementation of driver-model pmic uclass 
features
+ for PMIC BD71837. The driver implements read/write operations.
+
 config DM_PMIC_FAN53555
bool "Enable support for OnSemi FAN53555"
depends on DM_PMIC && DM_REGULATOR && DM_I2C
diff --git a/drivers/power/pmic/Makefile b/drivers/power/pmic/Makefile
index 637352ab2b..e605a88196 100644
--- a/drivers/power/pmic/Makefile
+++ b/drivers/power/pmic/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_DM_PMIC_FAN53555) += fan53555.o
 obj-$(CONFIG_DM_PMIC_MAX77686) += max77686.o
 obj-$(CONFIG_DM_PMIC_MAX8998) += max8998.o
 obj-$(CONFIG_DM_PMIC_MC34708) += mc34708.o
+obj-$(CONFIG_$(SPL_)DM_PMIC_BD71837) += bd71837.o
 obj-$(CONFIG_$(SPL_)DM_PMIC_PFUZE100) += pfuze100.o
 obj-$(CONFIG_PMIC_S2MPS11) += s2mps11.o
 obj-$(CONFIG_DM_PMIC_SANDBOX) += sandbox.o i2c_pmic_emul.o
diff --git a/drivers/power/pmic/bd71837.c b/drivers/power/pmic/bd71837.c
new file mode 100644
index 00..b749f9430a
--- /dev/null
+++ b/drivers/power/pmic/bd71837.c
@@ -0,0 +1,90 @@
+// SPDX-License-Identifier:  GPL-2.0+
+/*
+ * Copyright 2018 NXP
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+DECLARE_GLOBAL_DATA_PTR;
+
+static const struct pmic_child_info pmic_children_info[] = {
+   /* buck */
+   { .prefix = "b", .driver = BD71837_REGULATOR_DRIVER},
+   /* ldo */
+   { .prefix = "l", .driver = BD71837_REGULATOR_DRIVER},
+   { },
+};
+
+static int bd71837_reg_count(struct udevice *dev)
+{
+   return BD71837_REG_NUM;
+}
+
+static int bd71837_write(struct udevice *dev, uint reg, const uint8_t *buff,
+int len)
+{
+   if (dm_i2c_write(dev, reg, buff, len)) {
+   pr_err("write error to device: %p register: %#x!", dev, reg);
+   return -EIO;
+   }
+
+   return 0;
+}
+
+static int bd71837_read(struct udevice *dev, uint reg, uint8_t *buff, int len)
+{
+   if (dm_i2c_read(dev, reg, buff, len)) {
+   pr_err("read error from device: %p register: %#x!", dev, reg);
+   return -EIO;
+   }
+
+   return 0;
+}
+
+static int bd71837_bind(struct udevice *dev)
+{
+   int children;
+   ofnode regulators_node;
+
+   regulators_node = dev_read_subnode(dev, "regulators");
+   if (!ofnode_valid(regulators_node)) {
+   debug("%s: %s regulators subnode not found!", __func__,
+ dev->name);
+   return -ENXIO;
+   }
+
+   debug("%s: '%s' - found regulators subnode\n", __func__, dev->name);
+
+   children = pmic_bind_children(dev, regulators_node, pmic_children_info);
+   if (!children)
+   debug("%s: %s - no child found\n", __func__, dev->name);
+
+   /* Always return success for this device */
+   return 0;
+}
+
+static struct dm_pmic_ops bd71837_ops = {
+   .reg_count = bd71837_reg_count,
+   .read = bd71837_read,
+   .write = bd71837_write,
+};
+
+static const struct udevice_id bd71837_ids[] = {
+   { .compatible = "rohm,bd71837", .data = 0x4b, },
+   { }
+};
+
+U_BOOT_DRIVER(pmic_bd71837) = {
+   .name = "bd71837 pmic",
+   .id = UCLASS_PMIC,
+   .of_match = bd71837_ids,
+   .bind = bd71837_bind,
+   .ops = _ops,
+};
diff --git a/include/power/bd71837.h b/include/power/bd71837.h
new file mode 100644
index 00..38c69b2b90
--- /dev/null
+++ b/include/power/bd71837.h
@@ -0,0 +1,62 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* Copyright (C) 2018 ROHM Semiconductors */
+
+#ifndef BD71837_H_
+#define BD71837_H_
+
+#define BD71837_REGULATOR_DRIVER "bd71837_regulator"
+
+enum {
+   BD71837_REV = 0x00,
+   BD71837_SWRESET = 0x01,
+   BD71837_I2C_DEV