Re: [U-Boot] [PATCH v2 1/3] cmd_sf.c: fix printf() length modifier

[Wolfgang Denk]

Dear =?UTF-8?q?Andreas=20Bie=C3=9Fmann?=,

In message 1323939415-21743-2-git-send-email-andreas.de...@googlemail.com you 
wrote:
 From: Andreas Bießmann biessm...@corscience.de
 
 size_t is not always 'unsigned int', use corret length modifer.
 
 This patch fixes following warning:
 
 ---8---
 cmd_sf.c: In function 'spi_flash_update_block':
 cmd_sf.c:130: warning: format '%#x' expects type 'unsigend int', but argument 
 4 has type 'size_t'
 cmd_sf.c:135: warning: format '%x' expects type 'unsigned int', but argument 
 3 has type 'size_t'
 ---8---
 
 Signed-off-by: Andreas Bießmann biessm...@corscience.de
 cc: Mike Frysinger vap...@gentoo.org
 cc: Thomas Chou tho...@wytron.com.tw
 ---
 changes since v1: split off into single patches
 
 total: 0 errors, 0 warnings, 14 lines checked
 
 NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX 
 MULTISTATEMENT_MACRO_USE_DO_WHILE
 
 0001-cmd_sf.c-fix-printf-length-modifier.patch has no obvious style problems 
 and is ready for submission.
 
  common/cmd_sf.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

Applied to next branch, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Anything that is worth doing at all is worth doing well.
   -- Philip Earl of Chesterfield
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 1/3] cmd_sf.c: fix printf() length modifier

[Andreas Bießmann]

From: Andreas Bießmann biessm...@corscience.de

size_t is not always 'unsigned int', use corret length modifer.

This patch fixes following warning:

---8---
cmd_sf.c: In function 'spi_flash_update_block':
cmd_sf.c:130: warning: format '%#x' expects type 'unsigend int', but argument 4 
has type 'size_t'
cmd_sf.c:135: warning: format '%x' expects type 'unsigned int', but argument 3 
has type 'size_t'
---8---

Signed-off-by: Andreas Bießmann biessm...@corscience.de
cc: Mike Frysinger vap...@gentoo.org
cc: Thomas Chou tho...@wytron.com.tw
---
changes since v1: split off into single patches

total: 0 errors, 0 warnings, 14 lines checked

NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX 
MULTISTATEMENT_MACRO_USE_DO_WHILE

0001-cmd_sf.c-fix-printf-length-modifier.patch has no obvious style problems 
and is ready for submission.

 common/cmd_sf.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/cmd_sf.c b/common/cmd_sf.c
index 7225656..612fd18 100644
--- a/common/cmd_sf.c
+++ b/common/cmd_sf.c
@@ -127,12 +127,12 @@ static int do_spi_flash_probe(int argc, char * const 
argv[])
 static const char *spi_flash_update_block(struct spi_flash *flash, u32 offset,
size_t len, const char *buf, char *cmp_buf, size_t *skipped)
 {
-   debug(offset=%#x, sector_size=%#x, len=%#x\n,
+   debug(offset=%#x, sector_size=%#x, len=%#zx\n,
offset, flash-sector_size, len);
if (spi_flash_read(flash, offset, len, cmp_buf))
return read;
if (memcmp(cmp_buf, buf, len) == 0) {
-   debug(Skip region %x size %x: no change\n,
+   debug(Skip region %x size %zx: no change\n,
offset, len);
*skipped += len;
return NULL;
-- 
1.7.7.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/3] cmd_sf.c: fix printf() length modifier

[Mike Frysinger]

Acked-by: Mike Frysinger vap...@gentoo.org

if it doesn't get picked up by someone else, i'll push via my sf branch
-mike


signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot