Re: [U-Boot] [PATCH v2 1/5] Migrate CONFIG_DRIVER_TI_CPSW to Kconfig

[Felix Brack]

On 02.04.2018 17:43, Alex Kiernan wrote:
> On Mon, Apr 2, 2018 at 12:13 PM, Felix Brack  wrote:
>> Hi Alex,
>>
>> On 01.04.2018 11:22, Alex Kiernan wrote:
>>> This converts CONFIG_DRIVER_TI_CPSW to Kconfig
>>>
>>> Signed-off-by: Alex Kiernan 
>>> Acked-by: Joe Hershberger 
>>> ---
>>>
>>> Changes in v2:
>>> - Move DRIVER_TI_CPSW outside of the NETDEVICES guard
>>> - Don't mark DRIVER_TI_CPSW default if ARCH_OMAP2PLUS to fix mistranslations
>>>   by moveconfig
>>>
>>
>> [..]
>>
>>> diff --git a/configs/am335x_pdu001_defconfig 
>>> b/configs/am335x_pdu001_defconfig
>>> index cb75ec0..87ae88c 100644
>>> --- a/configs/am335x_pdu001_defconfig
>>> +++ b/configs/am335x_pdu001_defconfig
>>> @@ -9,13 +9,13 @@ CONFIG_SPL_SERIAL_SUPPORT=y
>>>  CONFIG_SPL_LIBDISK_SUPPORT=y
>>>  # CONFIG_SPL_NAND_SUPPORT is not set
>>>  CONFIG_SPL_WATCHDOG_SUPPORT=y
>>> +CONFIG_SPL=y
>>>  CONFIG_SPL_FAT_SUPPORT=y
>>>  CONFIG_DEFAULT_DEVICE_TREE="am335x-pdu001"
>>>  CONFIG_LOCALVERSION="-EETS-1.0.0"
>>>  CONFIG_DISTRO_DEFAULTS=y
>>>  CONFIG_BOOTDELAY=1
>>>  # CONFIG_USE_BOOTCOMMAND is not set
>>> -CONFIG_SPL=y
>>>  # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set
>>>  CONFIG_SPL_I2C_SUPPORT=y
>>>  CONFIG_SPL_YMODEM_SUPPORT=y
>>> @@ -39,6 +39,7 @@ CONFIG_DM_GPIO=y
>>>  CONFIG_DM_I2C=y
>>>  CONFIG_MMC_OMAP_HS=y
>>>  CONFIG_MMC_SDHCI=y
>>> +CONFIG_DRIVER_TI_CPSW=y
>>
>> Applying this patch series generates the following warning while
>> creating the default configuration for board PDU001:
>>
>> warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS &&
>> BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS && DRIVER_TI_CPSW &&
>> AG7XXX && ALTERA_TSE && BCM_SF2_ETH && DWC_ETH_QOS && ETH_DESIGNWARE &&
>> MVNETA && MVPP2 && MACB && PCH_GBE && SUN4I_EMAC && SUN8I_EMAC &&
>> SH_ETHER && XILINX_AXIEMAC && XILINX_EMACLITE && ZYNQ_GEM && PIC32_ETH
>> && RENESAS_RAVB) selects PHYLIB which has unmet direct dependencies (NET)
>>
>> This is due to the patch enabling CONFIG_DRIVER_TI_CPSW while leaving
>> CONFIG_NET disabled.
>> This board does not require/have network support for U-Boot so there is
>> no need or benefit activating CONFIG_DRIVER_TI_CPSW here. Leaving the
>> file configs/am355x_pdu001_defconfig without any modifications will make
>> your patch work properly and result in a clean, warning and error free,
>> build for the PDU001 board.
>>
>>>  CONFIG_PINCTRL=y
>>>  CONFIG_PINCTRL_SINGLE=y
>>>  CONFIG_DM_PMIC=y
>>
> 
> Oh bother, thanks for trying it. I think in fixing the opposite
> problem from v1 I've missed a depends on NET. Is your board covered by
> the Travis tests as I did push v2 and got a green build?
> 

From what I can see it is not, but I'm not sure. Using buildman with
am335x would include it. I have verified that.

> Unfortunately my laptop decided to die overnight and I'm away from the
> office for a couple of weeks so I'll have to pick it up when I'm back.
> 
> Alex
> 

regards, Felix
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/5] Migrate CONFIG_DRIVER_TI_CPSW to Kconfig

[Alex Kiernan]

On Mon, Apr 2, 2018 at 4:11 PM, Felix Brack  wrote:
> On 02.04.2018 17:43, Alex Kiernan wrote:
>> On Mon, Apr 2, 2018 at 12:13 PM, Felix Brack  wrote:
>>> Hi Alex,
>>>
>>> On 01.04.2018 11:22, Alex Kiernan wrote:
 This converts CONFIG_DRIVER_TI_CPSW to Kconfig

 Signed-off-by: Alex Kiernan 
 Acked-by: Joe Hershberger 
 ---

 Changes in v2:
 - Move DRIVER_TI_CPSW outside of the NETDEVICES guard
 - Don't mark DRIVER_TI_CPSW default if ARCH_OMAP2PLUS to fix 
 mistranslations
   by moveconfig

>>>
>>> [..]
>>>
 diff --git a/configs/am335x_pdu001_defconfig 
 b/configs/am335x_pdu001_defconfig
 index cb75ec0..87ae88c 100644
 --- a/configs/am335x_pdu001_defconfig
 +++ b/configs/am335x_pdu001_defconfig
 @@ -9,13 +9,13 @@ CONFIG_SPL_SERIAL_SUPPORT=y
  CONFIG_SPL_LIBDISK_SUPPORT=y
  # CONFIG_SPL_NAND_SUPPORT is not set
  CONFIG_SPL_WATCHDOG_SUPPORT=y
 +CONFIG_SPL=y
  CONFIG_SPL_FAT_SUPPORT=y
  CONFIG_DEFAULT_DEVICE_TREE="am335x-pdu001"
  CONFIG_LOCALVERSION="-EETS-1.0.0"
  CONFIG_DISTRO_DEFAULTS=y
  CONFIG_BOOTDELAY=1
  # CONFIG_USE_BOOTCOMMAND is not set
 -CONFIG_SPL=y
  # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set
  CONFIG_SPL_I2C_SUPPORT=y
  CONFIG_SPL_YMODEM_SUPPORT=y
 @@ -39,6 +39,7 @@ CONFIG_DM_GPIO=y
  CONFIG_DM_I2C=y
  CONFIG_MMC_OMAP_HS=y
  CONFIG_MMC_SDHCI=y
 +CONFIG_DRIVER_TI_CPSW=y
>>>
>>> Applying this patch series generates the following warning while
>>> creating the default configuration for board PDU001:
>>>
>>> warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS &&
>>> BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS && DRIVER_TI_CPSW &&
>>> AG7XXX && ALTERA_TSE && BCM_SF2_ETH && DWC_ETH_QOS && ETH_DESIGNWARE &&
>>> MVNETA && MVPP2 && MACB && PCH_GBE && SUN4I_EMAC && SUN8I_EMAC &&
>>> SH_ETHER && XILINX_AXIEMAC && XILINX_EMACLITE && ZYNQ_GEM && PIC32_ETH
>>> && RENESAS_RAVB) selects PHYLIB which has unmet direct dependencies (NET)
>>>
>>> This is due to the patch enabling CONFIG_DRIVER_TI_CPSW while leaving
>>> CONFIG_NET disabled.
>>> This board does not require/have network support for U-Boot so there is
>>> no need or benefit activating CONFIG_DRIVER_TI_CPSW here. Leaving the
>>> file configs/am355x_pdu001_defconfig without any modifications will make
>>> your patch work properly and result in a clean, warning and error free,
>>> build for the PDU001 board.
>>>
  CONFIG_PINCTRL=y
  CONFIG_PINCTRL_SINGLE=y
  CONFIG_DM_PMIC=y
>>>
>>
>> Oh bother, thanks for trying it. I think in fixing the opposite
>> problem from v1 I've missed a depends on NET. Is your board covered by
>> the Travis tests as I did push v2 and got a green build?
>>
>
> From what I can see it is not, but I'm not sure. Using buildman with
> am335x would include it. I have verified that.
>
>> Unfortunately my laptop decided to die overnight and I'm away from the
>> office for a couple of weeks so I'll have to pick it up when I'm back.
>>
>> Alex
>>
>
> regards, Felix

It is included, just found it, but looks like it doesn't fail because
of that issue:

https://travis-ci.org/akiernan/u-boot/jobs/360830565#L962

I clearly need to go and understand the Travis build a whole lot better.

-- 
Alex Kiernan
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/5] Migrate CONFIG_DRIVER_TI_CPSW to Kconfig

[Alex Kiernan]

On Mon, Apr 2, 2018 at 12:13 PM, Felix Brack  wrote:
> Hi Alex,
>
> On 01.04.2018 11:22, Alex Kiernan wrote:
>> This converts CONFIG_DRIVER_TI_CPSW to Kconfig
>>
>> Signed-off-by: Alex Kiernan 
>> Acked-by: Joe Hershberger 
>> ---
>>
>> Changes in v2:
>> - Move DRIVER_TI_CPSW outside of the NETDEVICES guard
>> - Don't mark DRIVER_TI_CPSW default if ARCH_OMAP2PLUS to fix mistranslations
>>   by moveconfig
>>
>
> [..]
>
>> diff --git a/configs/am335x_pdu001_defconfig 
>> b/configs/am335x_pdu001_defconfig
>> index cb75ec0..87ae88c 100644
>> --- a/configs/am335x_pdu001_defconfig
>> +++ b/configs/am335x_pdu001_defconfig
>> @@ -9,13 +9,13 @@ CONFIG_SPL_SERIAL_SUPPORT=y
>>  CONFIG_SPL_LIBDISK_SUPPORT=y
>>  # CONFIG_SPL_NAND_SUPPORT is not set
>>  CONFIG_SPL_WATCHDOG_SUPPORT=y
>> +CONFIG_SPL=y
>>  CONFIG_SPL_FAT_SUPPORT=y
>>  CONFIG_DEFAULT_DEVICE_TREE="am335x-pdu001"
>>  CONFIG_LOCALVERSION="-EETS-1.0.0"
>>  CONFIG_DISTRO_DEFAULTS=y
>>  CONFIG_BOOTDELAY=1
>>  # CONFIG_USE_BOOTCOMMAND is not set
>> -CONFIG_SPL=y
>>  # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set
>>  CONFIG_SPL_I2C_SUPPORT=y
>>  CONFIG_SPL_YMODEM_SUPPORT=y
>> @@ -39,6 +39,7 @@ CONFIG_DM_GPIO=y
>>  CONFIG_DM_I2C=y
>>  CONFIG_MMC_OMAP_HS=y
>>  CONFIG_MMC_SDHCI=y
>> +CONFIG_DRIVER_TI_CPSW=y
>
> Applying this patch series generates the following warning while
> creating the default configuration for board PDU001:
>
> warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS &&
> BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS && DRIVER_TI_CPSW &&
> AG7XXX && ALTERA_TSE && BCM_SF2_ETH && DWC_ETH_QOS && ETH_DESIGNWARE &&
> MVNETA && MVPP2 && MACB && PCH_GBE && SUN4I_EMAC && SUN8I_EMAC &&
> SH_ETHER && XILINX_AXIEMAC && XILINX_EMACLITE && ZYNQ_GEM && PIC32_ETH
> && RENESAS_RAVB) selects PHYLIB which has unmet direct dependencies (NET)
>
> This is due to the patch enabling CONFIG_DRIVER_TI_CPSW while leaving
> CONFIG_NET disabled.
> This board does not require/have network support for U-Boot so there is
> no need or benefit activating CONFIG_DRIVER_TI_CPSW here. Leaving the
> file configs/am355x_pdu001_defconfig without any modifications will make
> your patch work properly and result in a clean, warning and error free,
> build for the PDU001 board.
>
>>  CONFIG_PINCTRL=y
>>  CONFIG_PINCTRL_SINGLE=y
>>  CONFIG_DM_PMIC=y
>

Oh bother, thanks for trying it. I think in fixing the opposite
problem from v1 I've missed a depends on NET. Is your board covered by
the Travis tests as I did push v2 and got a green build?

Unfortunately my laptop decided to die overnight and I'm away from the
office for a couple of weeks so I'll have to pick it up when I'm back.

Alex

-- 
Alex Kiernan
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/5] Migrate CONFIG_DRIVER_TI_CPSW to Kconfig

[Felix Brack]

Hi Alex,

On 01.04.2018 11:22, Alex Kiernan wrote:
> This converts CONFIG_DRIVER_TI_CPSW to Kconfig
> 
> Signed-off-by: Alex Kiernan 
> Acked-by: Joe Hershberger 
> ---
> 
> Changes in v2:
> - Move DRIVER_TI_CPSW outside of the NETDEVICES guard
> - Don't mark DRIVER_TI_CPSW default if ARCH_OMAP2PLUS to fix mistranslations
>   by moveconfig
> 

[..]

> diff --git a/configs/am335x_pdu001_defconfig b/configs/am335x_pdu001_defconfig
> index cb75ec0..87ae88c 100644
> --- a/configs/am335x_pdu001_defconfig
> +++ b/configs/am335x_pdu001_defconfig
> @@ -9,13 +9,13 @@ CONFIG_SPL_SERIAL_SUPPORT=y
>  CONFIG_SPL_LIBDISK_SUPPORT=y
>  # CONFIG_SPL_NAND_SUPPORT is not set
>  CONFIG_SPL_WATCHDOG_SUPPORT=y
> +CONFIG_SPL=y
>  CONFIG_SPL_FAT_SUPPORT=y
>  CONFIG_DEFAULT_DEVICE_TREE="am335x-pdu001"
>  CONFIG_LOCALVERSION="-EETS-1.0.0"
>  CONFIG_DISTRO_DEFAULTS=y
>  CONFIG_BOOTDELAY=1
>  # CONFIG_USE_BOOTCOMMAND is not set
> -CONFIG_SPL=y
>  # CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_SECTOR is not set
>  CONFIG_SPL_I2C_SUPPORT=y
>  CONFIG_SPL_YMODEM_SUPPORT=y
> @@ -39,6 +39,7 @@ CONFIG_DM_GPIO=y
>  CONFIG_DM_I2C=y
>  CONFIG_MMC_OMAP_HS=y
>  CONFIG_MMC_SDHCI=y
> +CONFIG_DRIVER_TI_CPSW=y

Applying this patch series generates the following warning while
creating the default configuration for board PDU001:

warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS &&
BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS && DRIVER_TI_CPSW &&
AG7XXX && ALTERA_TSE && BCM_SF2_ETH && DWC_ETH_QOS && ETH_DESIGNWARE &&
MVNETA && MVPP2 && MACB && PCH_GBE && SUN4I_EMAC && SUN8I_EMAC &&
SH_ETHER && XILINX_AXIEMAC && XILINX_EMACLITE && ZYNQ_GEM && PIC32_ETH
&& RENESAS_RAVB) selects PHYLIB which has unmet direct dependencies (NET)

This is due to the patch enabling CONFIG_DRIVER_TI_CPSW while leaving
CONFIG_NET disabled.
This board does not require/have network support for U-Boot so there is
no need or benefit activating CONFIG_DRIVER_TI_CPSW here. Leaving the
file configs/am355x_pdu001_defconfig without any modifications will make
your patch work properly and result in a clean, warning and error free,
build for the PDU001 board.

>  CONFIG_PINCTRL=y
>  CONFIG_PINCTRL_SINGLE=y
>  CONFIG_DM_PMIC=y

regards, Felix
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 1/5] Migrate CONFIG_DRIVER_TI_CPSW to Kconfig

[Alex Kiernan]

This converts CONFIG_DRIVER_TI_CPSW to Kconfig

Signed-off-by: Alex Kiernan 
Acked-by: Joe Hershberger 
---

Changes in v2:
- Move DRIVER_TI_CPSW outside of the NETDEVICES guard
- Don't mark DRIVER_TI_CPSW default if ARCH_OMAP2PLUS to fix mistranslations
  by moveconfig

 configs/am335x_baltos_defconfig| 4 ++--
 configs/am335x_boneblack_defconfig | 4 ++--
 configs/am335x_boneblack_vboot_defconfig   | 4 ++--
 configs/am335x_evm_defconfig   | 4 ++--
 configs/am335x_evm_nor_defconfig   | 4 ++--
 configs/am335x_evm_norboot_defconfig   | 2 +-
 configs/am335x_evm_spiboot_defconfig   | 4 ++--
 configs/am335x_evm_usbspl_defconfig| 4 ++--
 configs/am335x_hs_evm_defconfig| 4 ++--
 configs/am335x_hs_evm_uart_defconfig   | 4 ++--
 configs/am335x_igep003x_defconfig  | 6 ++
 configs/am335x_pdu001_defconfig| 3 ++-
 configs/am335x_shc_defconfig   | 4 ++--
 configs/am335x_shc_ict_defconfig   | 4 ++--
 configs/am335x_shc_netboot_defconfig   | 4 ++--
 configs/am335x_shc_prompt_defconfig| 4 ++--
 configs/am335x_shc_sdboot_defconfig| 4 ++--
 configs/am335x_shc_sdboot_prompt_defconfig | 4 ++--
 configs/am335x_sl50_defconfig  | 4 ++--
 configs/am43xx_evm_defconfig   | 4 ++--
 configs/am43xx_evm_ethboot_defconfig   | 4 ++--
 configs/am43xx_evm_qspiboot_defconfig  | 2 +-
 configs/am43xx_evm_usbhost_boot_defconfig  | 4 ++--
 configs/am43xx_hs_evm_defconfig| 4 ++--
 configs/am57xx_evm_defconfig   | 4 ++--
 configs/am57xx_hs_evm_defconfig| 4 ++--
 configs/birdland_bav335a_defconfig | 4 ++--
 configs/birdland_bav335b_defconfig | 4 ++--
 configs/brppt1_mmc_defconfig   | 4 ++--
 configs/brppt1_nand_defconfig  | 4 ++--
 configs/brppt1_spi_defconfig   | 4 ++--
 configs/brxre1_defconfig   | 4 ++--
 configs/chiliboard_defconfig   | 4 ++--
 configs/cl-som-am57x_defconfig | 4 ++--
 configs/cm_t335_defconfig  | 4 ++--
 configs/cm_t43_defconfig   | 4 ++--
 configs/dra7xx_evm_defconfig   | 4 ++--
 configs/dra7xx_hs_evm_defconfig| 4 ++--
 configs/draco_defconfig| 4 ++--
 configs/etamin_defconfig   | 4 ++--
 configs/pcm051_rev1_defconfig  | 4 ++--
 configs/pcm051_rev3_defconfig  | 4 ++--
 configs/pengwyn_defconfig  | 4 ++--
 configs/pepper_defconfig   | 4 ++--
 configs/pxm2_defconfig | 4 ++--
 configs/rastaban_defconfig | 4 ++--
 configs/rut_defconfig  | 4 ++--
 configs/thuban_defconfig   | 4 ++--
 configs/ti814x_evm_defconfig   | 4 ++--
 drivers/net/Kconfig| 7 +++
 include/configs/am335x_shc.h   | 1 -
 include/configs/am43xx_evm.h   | 1 -
 include/configs/am57xx_evm.h   | 1 -
 include/configs/bur_am335x_common.h| 1 -
 include/configs/cl-som-am57x.h | 1 -
 include/configs/cm_t43.h   | 1 -
 include/configs/dra7xx_evm.h   | 1 -
 include/configs/siemens-am33x-common.h | 1 -
 include/configs/ti814x_evm.h   | 1 -
 include/configs/ti_am335x_common.h | 1 -
 scripts/config_whitelist.txt   | 1 -
 61 files changed, 103 insertions(+), 108 deletions(-)

diff --git a/configs/am335x_baltos_defconfig b/configs/am335x_baltos_defconfig
index ab7d96d..7206601 100644
--- a/configs/am335x_baltos_defconfig
+++ b/configs/am335x_baltos_defconfig
@@ -9,6 +9,7 @@ CONFIG_SPL_MMC_SUPPORT=y
 CONFIG_SPL_SERIAL_SUPPORT=y
 CONFIG_SPL_LIBDISK_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
+CONFIG_SPL=y
 CONFIG_SPL_FAT_SUPPORT=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_FIT_VERBOSE=y
@@ -17,7 +18,6 @@ CONFIG_OF_BOARD_SETUP=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 CONFIG_VERSION_VARIABLE=y
 CONFIG_ARCH_MISC_INIT=y
-CONFIG_SPL=y
 CONFIG_SPL_EXT_SUPPORT=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_MTD_SUPPORT=y
@@ -42,7 +42,7 @@ CONFIG_BOOTCOUNT_LIMIT=y
 CONFIG_SYS_OMAP24_I2C_SPEED=1000
 CONFIG_MMC_OMAP_HS=y
 CONFIG_NAND=y
-CONFIG_PHYLIB=y
+CONFIG_DRIVER_TI_CPSW=y
 CONFIG_SYS_NS16550=y
 CONFIG_OMAP3_SPI=y
 CONFIG_USB=y
diff --git a/configs/am335x_boneblack_defconfig 
b/configs/am335x_boneblack_defconfig
index f45e409..7039c6b 100644
--- a/configs/am335x_boneblack_defconfig
+++ b/configs/am335x_boneblack_defconfig
@@ -3,13 +3,13 @@ CONFIG_ARCH_OMAP2PLUS=y
 CONFIG_TI_COMMON_CMD_OPTIONS=y
 CONFIG_AM33XX=y
 # CONFIG_SPL_NAND_SUPPORT is not set
+CONFIG_SPL=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_SYS_EXTRA_OPTIONS="EMMC_BOOT"
 CONFIG_BOOTCOMMAND="if test ${boot_fit} -eq 1; then run update_to_fit; fi; run 
findfdt; run init_console; run envboot; run distro_bootcmd"
 CONFIG_SYS_CONSOLE_INFO_QUIET=y