Re: [U-Boot] [PATCH v2 1/5] x86: coreboot: Fix cosmetic issues

[Simon Glass]

On 2 June 2015 at 19:20, Bin Meng  wrote:
> Clean up arch/x86/cpu/coreboot.c to fix several cosmetic issues.
>
> Signed-off-by: Bin Meng 
> Acked-by: Simon Glass 
>
> ---
>
> Changes in v2:
> - Drop v1 patches already applied
> - Add  inclusion back
>
>  arch/x86/cpu/coreboot/coreboot.c  | 27 +++
>  arch/x86/include/asm/u-boot-x86.h |  1 -
>  2 files changed, 3 insertions(+), 25 deletions(-)

Applied to u-boot-x86, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 1/5] x86: coreboot: Fix cosmetic issues

[Bin Meng]

Clean up arch/x86/cpu/coreboot.c to fix several cosmetic issues.

Signed-off-by: Bin Meng 
Acked-by: Simon Glass 

---

Changes in v2:
- Drop v1 patches already applied
- Add  inclusion back

 arch/x86/cpu/coreboot/coreboot.c  | 27 +++
 arch/x86/include/asm/u-boot-x86.h |  1 -
 2 files changed, 3 insertions(+), 25 deletions(-)

diff --git a/arch/x86/cpu/coreboot/coreboot.c b/arch/x86/cpu/coreboot/coreboot.c
index 4cdd0d4..c3dfd28 100644
--- a/arch/x86/cpu/coreboot/coreboot.c
+++ b/arch/x86/cpu/coreboot/coreboot.c
@@ -7,16 +7,10 @@
  */
 
 #include 
-#include 
-#include 
 #include 
-#include 
-#include 
-#include 
-#include 
 #include 
+#include 
 #include 
-#include 
 #include 
 #include 
 
@@ -53,13 +47,6 @@ int last_stage_init(void)
return 0;
 }
 
-#ifndef CONFIG_SYS_NO_FLASH
-ulong board_flash_get_legacy(ulong base, int banknum, flash_info_t *info)
-{
-   return 0;
-}
-#endif
-
 int board_eth_init(bd_t *bis)
 {
return pci_eth_init(bis);
@@ -67,7 +54,8 @@ int board_eth_init(bd_t *bis)
 
 void board_final_cleanup(void)
 {
-   /* Un-cache the ROM so the kernel has one
+   /*
+* Un-cache the ROM so the kernel has one
 * more MTRR available.
 *
 * Coreboot should have assigned this to the
@@ -91,15 +79,6 @@ void board_final_cleanup(void)
outb(0xcb, 0xb2);
 }
 
-void panic_puts(const char *str)
-{
-   NS16550_t port = (NS16550_t)0x3f8;
-
-   NS16550_init(port, 1);
-   while (*str)
-   NS16550_putc(port, *str++);
-}
-
 int misc_init_r(void)
 {
return 0;
diff --git a/arch/x86/include/asm/u-boot-x86.h 
b/arch/x86/include/asm/u-boot-x86.h
index be103c0..d1d21ed 100644
--- a/arch/x86/include/asm/u-boot-x86.h
+++ b/arch/x86/include/asm/u-boot-x86.h
@@ -16,7 +16,6 @@ void init_gd(gd_t *id, u64 *gdt_addr);
 void setup_gdt(gd_t *id, u64 *gdt_addr);
 int init_cache(void);
 int cleanup_before_linux(void);
-void panic_puts(const char *str);
 
 /* cpu/.../timer.c */
 void timer_isr(void *);
-- 
1.8.2.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot