Re: [U-Boot] [PATCH v2 1/8] imx: mx6 correct is_soc_rev usage

[Stefano Babic]

Hi Peng,

On 11/06/2015 12:30, Peng Fan wrote:
 is_soc_rev should return a bool value, so use ==, but not -,
 change (is_soc_rev(CHIP_REV_1_0)  0) to (soc_rev()  CHIP_REV_1_0).
 This patch also add space between  for cpu_type(rev) macro.
 
 Signed-off-by: Peng Fan peng@freescale.com
 ---
 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 1/8] imx: mx6 correct is_soc_rev usage

[Peng Fan]

is_soc_rev should return a bool value, so use ==, but not -,
change (is_soc_rev(CHIP_REV_1_0)  0) to (soc_rev()  CHIP_REV_1_0).
This patch also add space between  for cpu_type(rev) macro.

Signed-off-by: Peng Fan peng@freescale.com
---

Changes v2:
 new patch

 arch/arm/imx-common/timer.c   | 4 ++--
 arch/arm/include/asm/arch-mx6/sys_proto.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/imx-common/timer.c b/arch/arm/imx-common/timer.c
index e522990..c12556a 100644
--- a/arch/arm/imx-common/timer.c
+++ b/arch/arm/imx-common/timer.c
@@ -44,8 +44,8 @@ static inline int gpt_has_clk_source_osc(void)
 {
 #if defined(CONFIG_MX6)
if (((is_cpu_type(MXC_CPU_MX6Q) || is_cpu_type(MXC_CPU_MX6D)) 
-(is_soc_rev(CHIP_REV_1_0)  0)) || is_cpu_type(MXC_CPU_MX6DL) ||
- is_cpu_type(MXC_CPU_MX6SOLO) || is_cpu_type(MXC_CPU_MX6SX))
+   (soc_rev()  CHIP_REV_1_0)) || is_cpu_type(MXC_CPU_MX6DL) ||
+is_cpu_type(MXC_CPU_MX6SOLO) || is_cpu_type(MXC_CPU_MX6SX))
return 1;
 
return 0;
diff --git a/arch/arm/include/asm/arch-mx6/sys_proto.h 
b/arch/arm/include/asm/arch-mx6/sys_proto.h
index c583291..9756708 100644
--- a/arch/arm/include/asm/arch-mx6/sys_proto.h
+++ b/arch/arm/include/asm/arch-mx6/sys_proto.h
@@ -12,7 +12,7 @@
 #include ../arch-imx/cpu.h
 
 #define soc_rev() (get_cpu_rev()  0xFF)
-#define is_soc_rev(rev)(soc_rev() - rev)
+#define is_soc_rev(rev) (soc_rev() == rev)
 
 u32 get_nr_cpus(void);
 u32 get_cpu_rev(void);
@@ -20,7 +20,7 @@ u32 get_cpu_speed_grade_hz(void);
 u32 get_cpu_temp_grade(int *minc, int *maxc);
 
 /* returns MXC_CPU_ value */
-#define cpu_type(rev) (((rev)  12)0xff)
+#define cpu_type(rev) (((rev)  12)  0xff)
 
 /* both macros return/take MXC_CPU_ constants */
 #define get_cpu_type() (cpu_type(get_cpu_rev()))
-- 
1.8.4


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot