Re: [U-Boot] [PATCH v2 12/19] dm: at91: snapper: Move driver model CONFIGs to Kconfig

2015-02-09 Thread Simon Glass 
Hi Masahiro,

On 8 February 2015 at 20:43, Masahiro Yamada yamad...@jp.panasonic.com wrote:
 Hi Simon,

 On Thu,  5 Feb 2015 21:41:43 -0700
 Simon Glass s...@chromium.org wrote:

 Remove driver model CONFIGs from the board config headers and use Kconfig
 instead.

 Signed-off-by: Simon Glass s...@chromium.org
 ---

 Changes in v2: None

  arch/arm/include/asm/arch-at91/at91_pio.h | 12 
  configs/snapper9260_defconfig |  3 +++
  configs/snapper9g20_defconfig |  3 +++
  include/configs/snapper9260.h |  4 
  4 files changed, 10 insertions(+), 12 deletions(-)

 diff --git a/arch/arm/include/asm/arch-at91/at91_pio.h 
 b/arch/arm/include/asm/arch-at91/at91_pio.h
 index 50464ff..3012278 100644
 --- a/arch/arm/include/asm/arch-at91/at91_pio.h
 +++ b/arch/arm/include/asm/arch-at91/at91_pio.h
 @@ -114,14 +114,10 @@ typedef union at91_pio {
   at91_port_t pioa;
   at91_port_t piob;
   at91_port_t pioc;
 - #if (ATMEL_PIO_PORTS  3)
 - at91_port_t piod;
 - #endif
 - #if (ATMEL_PIO_PORTS  4)
 - at91_port_t pioe;
 - #endif
 - } ;
 - at91_port_t port[ATMEL_PIO_PORTS];
 + at91_port_t piod;   /* not present in all hardware */
 + at91_port_t pioe;/* not present in all hardware */
 + };
 + at91_port_t port[5];
  } at91_pio_t;

  #ifdef CONFIG_AT91_GPIO


 I could not understand why this change is
 related to Move driver model CONFIGs to Kconfig.

 Nothing's mentioned about this change in your commit description.


 Perhaps, split into two patches?

With driver model, ATMEL_PIO_PORTS is defined by the platform data so
we can't have a #define for it. I will see if I can split it.

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 12/19] dm: at91: snapper: Move driver model CONFIGs to Kconfig

2015-02-08 Thread Masahiro Yamada 
Hi Simon,

On Thu,  5 Feb 2015 21:41:43 -0700
Simon Glass s...@chromium.org wrote:

 Remove driver model CONFIGs from the board config headers and use Kconfig
 instead.
 
 Signed-off-by: Simon Glass s...@chromium.org
 ---
 
 Changes in v2: None
 
  arch/arm/include/asm/arch-at91/at91_pio.h | 12 
  configs/snapper9260_defconfig |  3 +++
  configs/snapper9g20_defconfig |  3 +++
  include/configs/snapper9260.h |  4 
  4 files changed, 10 insertions(+), 12 deletions(-)
 
 diff --git a/arch/arm/include/asm/arch-at91/at91_pio.h 
 b/arch/arm/include/asm/arch-at91/at91_pio.h
 index 50464ff..3012278 100644
 --- a/arch/arm/include/asm/arch-at91/at91_pio.h
 +++ b/arch/arm/include/asm/arch-at91/at91_pio.h
 @@ -114,14 +114,10 @@ typedef union at91_pio {
   at91_port_t pioa;
   at91_port_t piob;
   at91_port_t pioc;
 - #if (ATMEL_PIO_PORTS  3)
 - at91_port_t piod;
 - #endif
 - #if (ATMEL_PIO_PORTS  4)
 - at91_port_t pioe;
 - #endif
 - } ;
 - at91_port_t port[ATMEL_PIO_PORTS];
 + at91_port_t piod;   /* not present in all hardware */
 + at91_port_t pioe;/* not present in all hardware */
 + };
 + at91_port_t port[5];
  } at91_pio_t;
  
  #ifdef CONFIG_AT91_GPIO


I could not understand why this change is
related to Move driver model CONFIGs to Kconfig.

Nothing's mentioned about this change in your commit description.


Perhaps, split into two patches?



Best Regards
Masahiro Yamada

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 12/19] dm: at91: snapper: Move driver model CONFIGs to Kconfig

2015-02-05 Thread Simon Glass 
Remove driver model CONFIGs from the board config headers and use Kconfig
instead.

Signed-off-by: Simon Glass s...@chromium.org
---

Changes in v2: None

 arch/arm/include/asm/arch-at91/at91_pio.h | 12 
 configs/snapper9260_defconfig |  3 +++
 configs/snapper9g20_defconfig |  3 +++
 include/configs/snapper9260.h |  4 
 4 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/arch/arm/include/asm/arch-at91/at91_pio.h 
b/arch/arm/include/asm/arch-at91/at91_pio.h
index 50464ff..3012278 100644
--- a/arch/arm/include/asm/arch-at91/at91_pio.h
+++ b/arch/arm/include/asm/arch-at91/at91_pio.h
@@ -114,14 +114,10 @@ typedef union at91_pio {
at91_port_t pioa;
at91_port_t piob;
at91_port_t pioc;
-   #if (ATMEL_PIO_PORTS  3)
-   at91_port_t piod;
-   #endif
-   #if (ATMEL_PIO_PORTS  4)
-   at91_port_t pioe;
-   #endif
-   } ;
-   at91_port_t port[ATMEL_PIO_PORTS];
+   at91_port_t piod;   /* not present in all hardware */
+   at91_port_t pioe;/* not present in all hardware */
+   };
+   at91_port_t port[5];
 } at91_pio_t;
 
 #ifdef CONFIG_AT91_GPIO
diff --git a/configs/snapper9260_defconfig b/configs/snapper9260_defconfig
index 7055e2a..035146c 100644
--- a/configs/snapper9260_defconfig
+++ b/configs/snapper9260_defconfig
@@ -1,3 +1,6 @@
 CONFIG_SYS_EXTRA_OPTIONS=AT91SAM9260
 CONFIG_ARM=y
 CONFIG_TARGET_SNAPPER9260=y
+CONFIG_DM=y
+CONFIG_DM_GPIO=y
+CONFIG_DM_SERIAL=y
diff --git a/configs/snapper9g20_defconfig b/configs/snapper9g20_defconfig
index 2faae15..66c44cc 100644
--- a/configs/snapper9g20_defconfig
+++ b/configs/snapper9g20_defconfig
@@ -1,3 +1,6 @@
 CONFIG_SYS_EXTRA_OPTIONS=AT91SAM9G20
 CONFIG_ARM=y
 CONFIG_TARGET_SNAPPER9260=y
+CONFIG_DM=y
+CONFIG_DM_GPIO=y
+CONFIG_DM_SERIAL=y
diff --git a/include/configs/snapper9260.h b/include/configs/snapper9260.h
index 9fa644f..712f9b7 100644
--- a/include/configs/snapper9260.h
+++ b/include/configs/snapper9260.h
@@ -21,10 +21,6 @@
 #define CONFIG_SYS_AT91_MAIN_CLOCK 18432000 /* External Crystal, in Hz */
 #define CONFIG_SYS_AT91_SLOW_CLOCK 32768
 #define CONFIG_SYS_GENERIC_BOARD
-#define CONFIG_DM
-#define CONFIG_CMD_DM
-#define CONFIG_DM_GPIO
-#define CONFIG_DM_SERIAL
 #define CONFIG_SYS_MALLOC_F_LEN(1  10)
 
 /* CPU */
-- 
2.2.0.rc0.207.ga3a616c

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot