Re: [U-Boot] [PATCH v2 2/2] arm: fix compile warnings when semihosting is enabled on ARMv7M target.

2015-10-19 Thread Vadzim Dambrouski 

On 19.10.2015 09:06, Albert ARIBAUD wrote:

Hello Vadzim,

On Mon, 19 Oct 2015 00:13:29 +0300, Vadzim Dambrouski
 wrote:

Signed-off-by: Vadzim Dambrouski 
---

  arch/arm/lib/semihosting.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/lib/semihosting.c b/arch/arm/lib/semihosting.c
index ed5e8e4..6541cb4 100644
--- a/arch/arm/lib/semihosting.c
+++ b/arch/arm/lib/semihosting.c
@@ -92,7 +92,7 @@ static long smh_read(long fd, void *memp, size_t len)
size_t len;
} read;

-   debug("%s: fd %ld, memp %p, len %lu\n", __func__, fd, memp, len);
+   debug("%s: fd %ld, memp %p, len %lu\n", __func__, fd, memp, (ulong)len);

read.fd = fd;
read.memp = memp;
@@ -107,7 +107,7 @@ static long smh_read(long fd, void *memp, size_t len)
 * with an error message.
 */
printf("%s: ERROR ret %ld, fd %ld, len %lu memp %p\n",
-  __func__, ret, fd, len, memp);
+  __func__, ret, fd, (ulong)len, memp);
return -1;
}


len is a size_t; it should not be force-converted into a long, it
should be printed using a 'z' qualifier.

Amicalement,



Well, you are right, I'll send another revision of this patch set.
Thank you for all your assistance.

Regards,
Vadzim Dambrouski
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 2/2] arm: fix compile warnings when semihosting is enabled on ARMv7M target.

2015-10-18 Thread Albert ARIBAUD 
Hello Vadzim,

On Mon, 19 Oct 2015 00:13:29 +0300, Vadzim Dambrouski
 wrote:
> Signed-off-by: Vadzim Dambrouski 
> ---
> 
>  arch/arm/lib/semihosting.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/lib/semihosting.c b/arch/arm/lib/semihosting.c
> index ed5e8e4..6541cb4 100644
> --- a/arch/arm/lib/semihosting.c
> +++ b/arch/arm/lib/semihosting.c
> @@ -92,7 +92,7 @@ static long smh_read(long fd, void *memp, size_t len)
>   size_t len;
>   } read;
>  
> - debug("%s: fd %ld, memp %p, len %lu\n", __func__, fd, memp, len);
> + debug("%s: fd %ld, memp %p, len %lu\n", __func__, fd, memp, (ulong)len);
>  
>   read.fd = fd;
>   read.memp = memp;
> @@ -107,7 +107,7 @@ static long smh_read(long fd, void *memp, size_t len)
>* with an error message.
>*/
>   printf("%s: ERROR ret %ld, fd %ld, len %lu memp %p\n",
> -__func__, ret, fd, len, memp);
> +__func__, ret, fd, (ulong)len, memp);
>   return -1;
>   }

len is a size_t; it should not be force-converted into a long, it
should be printed using a 'z' qualifier.

Amicalement,
-- 
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 2/2] arm: fix compile warnings when semihosting is enabled on ARMv7M target.

2015-10-18 Thread Vadzim Dambrouski 
Signed-off-by: Vadzim Dambrouski 
---

 arch/arm/lib/semihosting.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/lib/semihosting.c b/arch/arm/lib/semihosting.c
index ed5e8e4..6541cb4 100644
--- a/arch/arm/lib/semihosting.c
+++ b/arch/arm/lib/semihosting.c
@@ -92,7 +92,7 @@ static long smh_read(long fd, void *memp, size_t len)
size_t len;
} read;
 
-   debug("%s: fd %ld, memp %p, len %lu\n", __func__, fd, memp, len);
+   debug("%s: fd %ld, memp %p, len %lu\n", __func__, fd, memp, (ulong)len);
 
read.fd = fd;
read.memp = memp;
@@ -107,7 +107,7 @@ static long smh_read(long fd, void *memp, size_t len)
 * with an error message.
 */
printf("%s: ERROR ret %ld, fd %ld, len %lu memp %p\n",
-  __func__, ret, fd, len, memp);
+  __func__, ret, fd, (ulong)len, memp);
return -1;
}
 
-- 
2.6.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot