Re: [U-Boot] [PATCH v2 3/7] riscv: use invalidate/flush_*cache_range functions in cache.c

[Rick Chen]

> > From: Lukas Auer [mailto:lukas.a...@aisec.fraunhofer.de]
> > Sent: Friday, January 04, 2019 8:38 AM
> > To: u-boot@lists.denx.de
> > Cc: Anup Patel; Lukas Auer; Rick Jian-Zhi Chen(陳建志); Bin Meng; Greentime Hu
> > Subject: [PATCH v2 3/7] riscv: use invalidate/flush_*cache_range functions 
> > in
> > cache.c
> >
> > The flush_cache() function in lib/cache.c ignores its arguments and flushes 
> > the
> > complete data and instruction caches. Use the
> > invalidate/flush_*cache_range() functions instead to only flush the 
> > requested
> > memory region.
> >
> > This patch does not change the current behavior of U-Boot, since the
> > implementation of the invalidate/flush_*cache_range() functions flush the
> > complete data and instruction caches. It is in preparation for CPUs with the
> > necessary functionality for flushing a selectable memory range.
> >
> > Signed-off-by: Lukas Auer 
> > ---
> >
> > Changes in v2:
> > - New patch "riscv: use invalidate/flush_*cache_range functions in cache.c"
> >
> >  arch/riscv/lib/cache.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/riscv/lib/cache.c b/arch/riscv/lib/cache.c index
> > 78b19da2c5..5437a122a1 100644
> > --- a/arch/riscv/lib/cache.c
> > +++ b/arch/riscv/lib/cache.c
> > @@ -40,8 +40,8 @@ void cache_flush(void)
> >
> >  void flush_cache(unsigned long addr, unsigned long size)  {
> > - invalidate_icache_all();
> > - flush_dcache_all();
> > + invalidate_icache_range(addr, addr + size);
> > + flush_dcache_range(addr, addr + size);
> >  }
> >
> >  __weak void icache_enable(void)
> > --

Reviewed-by: Rick Chen 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH v2 3/7] riscv: use invalidate/flush_*cache_range functions in cache.c

[Bin Meng]

On Fri, Jan 4, 2019 at 8:38 AM Lukas Auer
 wrote:
>
> The flush_cache() function in lib/cache.c ignores its arguments and
> flushes the complete data and instruction caches. Use the
> invalidate/flush_*cache_range() functions instead to only flush the
> requested memory region.
>
> This patch does not change the current behavior of U-Boot, since the
> implementation of the invalidate/flush_*cache_range() functions flush
> the complete data and instruction caches. It is in preparation for CPUs
> with the necessary functionality for flushing a selectable memory range.
>
> Signed-off-by: Lukas Auer 
> ---
>
> Changes in v2:
> - New patch "riscv: use invalidate/flush_*cache_range functions in
> cache.c"
>
>  arch/riscv/lib/cache.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

[U-Boot] [PATCH v2 3/7] riscv: use invalidate/flush_*cache_range functions in cache.c

[Lukas Auer]

The flush_cache() function in lib/cache.c ignores its arguments and
flushes the complete data and instruction caches. Use the
invalidate/flush_*cache_range() functions instead to only flush the
requested memory region.

This patch does not change the current behavior of U-Boot, since the
implementation of the invalidate/flush_*cache_range() functions flush
the complete data and instruction caches. It is in preparation for CPUs
with the necessary functionality for flushing a selectable memory range.

Signed-off-by: Lukas Auer 
---

Changes in v2:
- New patch "riscv: use invalidate/flush_*cache_range functions in
cache.c"

 arch/riscv/lib/cache.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/lib/cache.c b/arch/riscv/lib/cache.c
index 78b19da2c5..5437a122a1 100644
--- a/arch/riscv/lib/cache.c
+++ b/arch/riscv/lib/cache.c
@@ -40,8 +40,8 @@ void cache_flush(void)
 
 void flush_cache(unsigned long addr, unsigned long size)
 {
-   invalidate_icache_all();
-   flush_dcache_all();
+   invalidate_icache_range(addr, addr + size);
+   flush_dcache_range(addr, addr + size);
 }
 
 __weak void icache_enable(void)
-- 
2.20.1

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot