Re: [U-Boot] [PATCH v2 6/7] net/designware: do explicit port selection for 1Gb mode

[Joe Hershberger]

On Wed, Jan 13, 2016 at 7:59 AM, Alexey Brodkin
 wrote:
> Current implementation only sets "port select" bit for non-1Gb mode.
> That works fine if GMAC has just exited reset state but we may as well
> change connection mode in runtime. Then we'll need to reprogram GMAC for
> that new mode of operation and if previous mode was 10 or 100 Mb and new
> one is 1 Gb we'll need to reset port mode bit.
>
> Signed-off-by: Alexey Brodkin 
> Cc: Bin Meng 
> Cc: Joe Hershberger 
> Cc: Sonic Zhang 
> cc: Simon Glass 

Acked-by: Joe Hershberger 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 6/7] net/designware: do explicit port selection for 1Gb mode

[Alexey Brodkin]

Current implementation only sets "port select" bit for non-1Gb mode.
That works fine if GMAC has just exited reset state but we may as well
change connection mode in runtime. Then we'll need to reprogram GMAC for
that new mode of operation and if previous mode was 10 or 100 Mb and new
one is 1 Gb we'll need to reset port mode bit.

Signed-off-by: Alexey Brodkin 
Cc: Bin Meng 
Cc: Joe Hershberger 
Cc: Sonic Zhang 
cc: Simon Glass 
---

Changes v1 -> v2:
 No changes, this is just a resent in series with other related patches.

 drivers/net/designware.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index 04114a1..39c7279 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -196,6 +196,8 @@ static void dw_adjust_link(struct eth_mac_regs *mac_p,
 
if (phydev->speed != 1000)
conf |= MII_PORTSELECT;
+   else
+   conf &= ~MII_PORTSELECT;
 
if (phydev->speed == 100)
conf |= FES_100;
-- 
2.4.3

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot