Re: [U-Boot] [PATCH v3] Add support for Bluewater Systems Snapper 9260 and 9G20 modules

2011-04-11 Thread Reinhard Meyer 
Dear Ryan Mallon,
> Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
> single board computer modules. Includes NAND flash and Ethernet
> support.
> 
> Signed-off-by: Ryan Mallon 
> ---
> Patches apply against the rework101229 branch of 
> git://git.denx.de/u-boot-atmel.git.
> 
> Builds and runs. Tested Ethernet and NAND booting.

WARNING: Use #include  instead of 
#154: FILE: board/bluewater/snapper9260/snapper9260.c:25:
+#include 
[ignored]

ERROR: trailing whitespace
#201: FILE: board/bluewater/snapper9260/snapper9260.c:72:
+^Iwritel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) | $
[fixed manually]

ERROR: trailing whitespace
#320: FILE: include/configs/snapper9260.h:3:
+ * $
[fixed manually]

WARNING: please, no space before tabs
#356: FILE: include/configs/snapper9260.h:39:
+#define CONFIG_SYS_HZ ^I^I^I1000$
[fixed manually]

ERROR: space required after that close brace '}'
#418: FILE: include/configs/snapper9260.h:101:
+#define CONFIG_SYS_I2C_PCA953X_WIDTH   {{0x28, 16}}
[fixed manually]

ERROR: trailing whitespace
#440: FILE: include/configs/snapper9260.h:123:
+#define I2C_SOFT_DECLARATIONS   $
[fixed manually]

ERROR: space prohibited after that open parenthesis '('
#485: FILE: include/configs/snapper9260.h:168:
+#define CONFIG_SYS_MALLOC_LEN  (  1 << 20)
[fixed manually]

total: 5 errors, 2 warnings, 432 lines checked

Applied to u-boot-atmel/next after fixing style problems.

Thanks,

Reinhard
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3] Add support for Bluewater Systems Snapper 9260 and 9G20 modules

2011-02-07 Thread Ryan Mallon 
On 02/02/2011 03:18 PM, Ryan Mallon wrote:
> Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
> single board computer modules. Includes NAND flash and Ethernet
> support.
> 
> Signed-off-by: Ryan Mallon 

Hello Reinhard,

Is this patch okay for inclusion in your tree yet?

Thanks,
~Ryan

> ---
> Patches apply against the rework101229 branch of 
> git://git.denx.de/u-boot-atmel.git.
> 
> Builds and runs. Tested Ethernet and NAND booting.
> 
> Changes for v3:
>  - Replaced SZ_ macros with shifts
>  - Remove defined values from CONFIG_ defines
>  - Moved boards.cfg entry to correct place
>  - Added MAINTAINERS entry
> 
> Changes for v2:
>  - Updated for recent at91 changes
>  - Use CONFIG_AT91FAMILY in soft_i2c driver
>  - Fixed missing snapper9260.h config file
>  - Add config to boards.cfg not Makefile
>  - Removed config.mk (now in snapper9260.h)
> 
>  MAINTAINERS   |5 +
>  board/bluewater/snapper9260/Makefile  |   53 
>  board/bluewater/snapper9260/snapper9260.c |  169 +
>  boards.cfg|2 +
>  include/configs/snapper9260.h |  191 
> +
>  5 files changed, 420 insertions(+), 0 deletions(-)
>  create mode 100644 board/bluewater/snapper9260/Makefile
>  create mode 100644 board/bluewater/snapper9260/snapper9260.c
>  create mode 100644 include/configs/snapper9260.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a5f0493..f8c1996 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -298,6 +298,11 @@ Dan Malek 
>   stxssa  MPC85xx
>   stxxtc  MPC8xx
>  
> +Ryan Mallon 
> +
> + snapper9260 ARM926EJS (AT91SAM9260 SoC)
> + snapper9g20 ARM926EJS (AT91SAM9G20 SoC)
> +
>  Eran Man 
>  
>   EVB64260_750CX  MPC750CX
> diff --git a/board/bluewater/snapper9260/Makefile 
> b/board/bluewater/snapper9260/Makefile
> new file mode 100644
> index 000..4fccdaa
> --- /dev/null
> +++ b/board/bluewater/snapper9260/Makefile
> @@ -0,0 +1,53 @@
> +#
> +# (C) Copyright 2003-2008
> +# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
> +#
> +# (C) Copyright 2011 Bluewater Systems
> +# Ryan Mallon 
> +#
> +# See file CREDITS for list of people who contributed to this
> +# project.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation; either version 2 of
> +# the License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> +# MA 02111-1307 USA
> +#
> +
> +include $(TOPDIR)/config.mk
> +
> +LIB  = $(obj)lib$(BOARD).o
> +
> +COBJS-y  += snapper9260.o
> +
> +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
> +OBJS := $(addprefix $(obj),$(COBJS-y))
> +SOBJS:= $(addprefix $(obj),$(SOBJS))
> +
> +$(LIB):  $(obj).depend $(OBJS) $(SOBJS)
> + $(call cmd_link_o_target, $(OBJS) $(SOBJS))
> +
> +clean:
> + rm -f $(SOBJS) $(OBJS)
> +
> +distclean:   clean
> + rm -f $(LIB) core *.bak $(obj).depend
> +
> +#
> +
> +# defines $(obj).depend target
> +include $(SRCTREE)/rules.mk
> +
> +sinclude $(obj).depend
> +
> +#
> diff --git a/board/bluewater/snapper9260/snapper9260.c 
> b/board/bluewater/snapper9260/snapper9260.c
> new file mode 100644
> index 000..6bb2ee0
> --- /dev/null
> +++ b/board/bluewater/snapper9260/snapper9260.c
> @@ -0,0 +1,169 @@
> +/*
> + * Bluewater Systems Snapper 9260/9G20 modules
> + *
> + * (C) Copyright 2011 Bluewater Systems
> + *   Author: Andre Renaud 
> + *   Author: Ryan Mallon 
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#include 
> +#include 
> +#in

[U-Boot] [PATCH v3] Add support for Bluewater Systems Snapper 9260 and 9G20 modules

2011-02-01 Thread Ryan Mallon 
Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
single board computer modules. Includes NAND flash and Ethernet
support.

Signed-off-by: Ryan Mallon 
---
Patches apply against the rework101229 branch of 
git://git.denx.de/u-boot-atmel.git.

Builds and runs. Tested Ethernet and NAND booting.

Changes for v3:
 - Replaced SZ_ macros with shifts
 - Remove defined values from CONFIG_ defines
 - Moved boards.cfg entry to correct place
 - Added MAINTAINERS entry

Changes for v2:
 - Updated for recent at91 changes
 - Use CONFIG_AT91FAMILY in soft_i2c driver
 - Fixed missing snapper9260.h config file
 - Add config to boards.cfg not Makefile
 - Removed config.mk (now in snapper9260.h)

 MAINTAINERS   |5 +
 board/bluewater/snapper9260/Makefile  |   53 
 board/bluewater/snapper9260/snapper9260.c |  169 +
 boards.cfg|2 +
 include/configs/snapper9260.h |  191 +
 5 files changed, 420 insertions(+), 0 deletions(-)
 create mode 100644 board/bluewater/snapper9260/Makefile
 create mode 100644 board/bluewater/snapper9260/snapper9260.c
 create mode 100644 include/configs/snapper9260.h

diff --git a/MAINTAINERS b/MAINTAINERS
index a5f0493..f8c1996 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -298,6 +298,11 @@ Dan Malek 
stxssa  MPC85xx
stxxtc  MPC8xx
 
+Ryan Mallon 
+
+   snapper9260 ARM926EJS (AT91SAM9260 SoC)
+   snapper9g20 ARM926EJS (AT91SAM9G20 SoC)
+
 Eran Man 
 
EVB64260_750CX  MPC750CX
diff --git a/board/bluewater/snapper9260/Makefile 
b/board/bluewater/snapper9260/Makefile
new file mode 100644
index 000..4fccdaa
--- /dev/null
+++ b/board/bluewater/snapper9260/Makefile
@@ -0,0 +1,53 @@
+#
+# (C) Copyright 2003-2008
+# Wolfgang Denk, DENX Software Engineering, w...@denx.de.
+#
+# (C) Copyright 2011 Bluewater Systems
+# Ryan Mallon 
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB= $(obj)lib$(BOARD).o
+
+COBJS-y+= snapper9260.o
+
+SRCS   := $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
+OBJS   := $(addprefix $(obj),$(COBJS-y))
+SOBJS  := $(addprefix $(obj),$(SOBJS))
+
+$(LIB):$(obj).depend $(OBJS) $(SOBJS)
+   $(call cmd_link_o_target, $(OBJS) $(SOBJS))
+
+clean:
+   rm -f $(SOBJS) $(OBJS)
+
+distclean: clean
+   rm -f $(LIB) core *.bak $(obj).depend
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#
diff --git a/board/bluewater/snapper9260/snapper9260.c 
b/board/bluewater/snapper9260/snapper9260.c
new file mode 100644
index 000..6bb2ee0
--- /dev/null
+++ b/board/bluewater/snapper9260/snapper9260.c
@@ -0,0 +1,169 @@
+/*
+ * Bluewater Systems Snapper 9260/9G20 modules
+ *
+ * (C) Copyright 2011 Bluewater Systems
+ *   Author: Andre Renaud 
+ *   Author: Ryan Mallon 
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+DECLARE_GLOBAL_DATA_PTR;
+
+/* IO Expander pins */
+#define IO_EXP_ETH_RESET   (0 << 1)
+#define IO_EXP_ETH_POWER   (1 << 1)
+
+static void macb_hw_init(void)
+{
+   struct at91_pmc *pmc   = (struct at91_pmc  *)ATMEL_BASE_PMC;
+   struct at91_port *pioa = (struct at91_p