Re: [U-Boot] [PATCH v3] disk: convert to Kconfig

2017-01-13 Thread Patrick DELAUNAY 
> Subject: Re: [PATCH v3] disk: convert to Kconfig
> 
> >
> > >
> > > First, thanks for doing all of this, I think it's just about ready to 
> > > apply so:
> > >
> > > Reviewed-by: Tom Rini 
> > >
> > > But that said, I'm going to re-run the sync as there's still a few
> > > places where we enable $X in the defconfig file as it wasn't setting
> > > DISTRO_DEFAULTS before, but is now (am335x* and making
> > > EFI_PARTITIONS default y if TEGRA).  But I'll fix that up in-place
> > > so you don't have to re-submit the giant thing.  Thanks!
> > >
> > > --
> > > Tom
> >
> > Hi Tom
> >
> > I see that your patch is now merged and integrated in v2017.01
> > (https://patchwork.ozlabs.org/patch/700546/),
> > do you need some re-submit of my giant patch for the next merge
> windows ?
> > or you can handle it my simple merge ?
> 
> So, I took some attempts at merging this.  The problem is that as the changes
> exist today it's not size-neutral which means that some of the changes aren't
> quite right.  Do you have the time to look at making sure it's size neutral?
> Thanks!

Hi Tom,

I will take some time (in background) to merge my patch on v2017.01 to be sure 
it is neutral .

If I have a better result I will push it again on top of v2017.01 next week.

Patrick

> --
> Tom


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3] disk: convert to Kconfig

2017-01-11 Thread Patrick DELAUNAY 
 
> 
> First, thanks for doing all of this, I think it's just about ready to apply 
> so:
> 
> Reviewed-by: Tom Rini 
> 
> But that said, I'm going to re-run the sync as there's still a few places 
> where
> we enable $X in the defconfig file as it wasn't setting DISTRO_DEFAULTS
> before, but is now (am335x* and making EFI_PARTITIONS default y if
> TEGRA).  But I'll fix that up in-place so you don't have to re-submit the 
> giant
> thing.  Thanks!
> 
> --
> Tom

Hi Tom

I see that your patch is now merged and integrated in v2017.01 
(https://patchwork.ozlabs.org/patch/700546/),
do you need some re-submit of my giant patch for the next merge windows ?
or you can handle it my simple merge ?

Regards

Patrick
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3] disk: convert to Kconfig

2017-01-11 Thread Tom Rini 
On Wed, Jan 11, 2017 at 07:10:53PM +, Patrick DELAUNAY wrote:
>  
> > 
> > First, thanks for doing all of this, I think it's just about ready to apply 
> > so:
> > 
> > Reviewed-by: Tom Rini 
> > 
> > But that said, I'm going to re-run the sync as there's still a few places 
> > where
> > we enable $X in the defconfig file as it wasn't setting DISTRO_DEFAULTS
> > before, but is now (am335x* and making EFI_PARTITIONS default y if
> > TEGRA).  But I'll fix that up in-place so you don't have to re-submit the 
> > giant
> > thing.  Thanks!
> > 
> > --
> > Tom
> 
> Hi Tom
> 
> I see that your patch is now merged and integrated in v2017.01 
> (https://patchwork.ozlabs.org/patch/700546/),
> do you need some re-submit of my giant patch for the next merge windows ?
> or you can handle it my simple merge ?

So, I took some attempts at merging this.  The problem is that as the
changes exist today it's not size-neutral which means that some of the
changes aren't quite right.  Do you have the time to look at making sure
it's size neutral?  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3] disk: convert to Kconfig

2016-12-05 Thread Tom Rini 
On Mon, Dec 05, 2016 at 01:01:05PM +0100, Patrick Delaunay wrote:

> From: Patrick Delaunay 
> 
> This converts the following to Kconfig:
>CONFIG_PARTITIONS
>CONFIG_MAC_PARTITION
>CONFIG_DOS_PARTITION
>CONFIG_ISO_PARTITION
>CONFIG_AMIGA_PARTITION
>CONFIG_EFI_PARTITION
>CONFIG_PARTITION_UUIDS
>CONFIG_PARTITION_TYPE_GUID
> 
> Specific SPL config are added to reduce SPL size
> for some target and solve compilation issues
> 
>CONFIG_SPL_MAC_PARTITION
>CONFIG_SPL_DOS_PARTITION
>CONFIG_SPL_ISO_PARTITION
>CONFIG_SPL_AMIGA_PARTITION
>CONFIG_SPL_EFI_PARTITION
> 
> Associated test are updated to the correct CONFIG (SPL or not)
> by using macro CONFIG_IS_ENABLED
> 
> To update the U-Boot code I use :
> 0- Resync with savedefconfig
>/tools/moveconfig.py -s -Cy
> 
> 1- update defconfig for new SPL option
>./tools/moveconfig.py --spl --commit \
>PARTITIONS MAC_PARTITION DOS_PARTITION \
>ISO_PARTITION AMIGA_PARTITION EFI_PARTITION \
>PARTITION_UUIDS PARTITION_TYPE_GUID
> 
>then replace CONFIG by CONFIG_SPL in defconfig
>sed -i 
> "s/CONFIG_\(DOS\|EFI\|ISO\|MAC\|AMIGA\)_PARTITION/CONFIG_SPL_\1_PARTITION/" \
>configs/*
> 
> 2- update defconfig for existing option
>./tools/moveconfig.py --commit --yes \
>PARTITIONS MAC_PARTITION DOS_PARTITION \
>ISO_PARTITION AMIGA_PARTITION EFI_PARTITION \
>PARTITION_UUIDS PARTITION_TYPE_GUID
> 
> => squash the 2 modifications
> 
> 
> Signed-off-by: Patrick Delaunay 
> Signed-off-by: Patrick Delaunay 

First, thanks for doing all of this, I think it's just about ready to
apply so:

Reviewed-by: Tom Rini 

But that said, I'm going to re-run the sync as there's still a few
places where we enable $X in the defconfig file as it wasn't setting
DISTRO_DEFAULTS before, but is now (am335x* and making EFI_PARTITIONS
default y if TEGRA).  But I'll fix that up in-place so you don't have to
re-submit the giant thing.  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot