Re: [U-Boot] [PATCH v3 0/3] Tegra: MMC: Add DT support for MMC to T20 boards
Stephen,
On Thu, Feb 14, 2013 at 4:27 PM, Stephen Warren wrote:
> On 02/13/2013 02:44 PM, Tom Warren wrote:
>> This patchset adds device-tree support to the Tegra MMC driver.
>> All device config is done via properties in the DT files instead
>> of hard-coded config options/function arguments.
>>
>> I've tested this on my Seaboard and everything works fine,
>> including card detect. For the other T20 boards, I've used
>> the Linux kernel DTS files for the sdhci nodes where there
>> wasn't one already, or expanded the info that was already
>> there. Everything builds fine, but I haven't tested anything
>> but Seaboard.
>
> With the incremental patch below applied,
>
> Tested-by: Stephen Warren
> On: Harmony, Seaboard(really Springbank), Ventana, Whistler,
> Paz00/AC100, TrimSlice.
>
>> commit a5be5907d77eb4ca18dd9a11dd09183148c9d1b2
>> Author: Stephen Warren
>> Date: Thu Feb 14 16:02:24 2013 -0700
>>
>> Fix MMC DT rework
>>
>> diff --git a/drivers/mmc/tegra_mmc.c b/drivers/mmc/tegra_mmc.c
>> index e8e8512..630f6bd 100644
>> --- a/drivers/mmc/tegra_mmc.c
>> +++ b/drivers/mmc/tegra_mmc.c
>> @@ -497,7 +497,6 @@ static int do_mmc_init(int dev_index)
>> struct mmc_host *host;
>> char gpusage[12]; /* "SD/MMCn PWR" or "SD/MMCn CD" */
>> struct mmc *mmc;
>> - int card_det = 0;
>>
>> /* DT should have been read & host config filled in */
>> host = &mmc_host[dev_index];
>> @@ -514,16 +513,15 @@ static int do_mmc_init(int dev_index)
>> if (fdt_gpio_isvalid(&host->pwr_gpio)) {
>> sprintf(gpusage, "SD/MMC%d PWR", dev_index);
>> gpio_request(host->pwr_gpio.gpio, gpusage);
>> - fdtdec_set_gpio(&host->pwr_gpio, 1);
>> + gpio_direction_output(host->pwr_gpio.gpio, 1);
>> debug(" Power GPIO name = %s\n", host->pwr_gpio.name);
>> }
>>
>> if (fdt_gpio_isvalid(&host->cd_gpio)) {
>> sprintf(gpusage, "SD/MMC%d CD", dev_index);
>> gpio_request(host->cd_gpio.gpio, gpusage);
>> - card_det = fdtdec_get_gpio(&host->cd_gpio);
>> + gpio_direction_input(host->cd_gpio.gpio);
>> debug(" CD GPIO name = %s\n", host->cd_gpio.name);
>> - debug("%s: CD state = %d\n", __func__, card_det);
>> }
>>
>> mmc = &mmc_dev[dev_index];
>
Thanks. I'll look at merging this w/my v4 patchset when I get back
from Kansas on Weds.
Tom
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 0/3] Tegra: MMC: Add DT support for MMC to T20 boards
On 02/13/2013 02:44 PM, Tom Warren wrote:
> This patchset adds device-tree support to the Tegra MMC driver.
> All device config is done via properties in the DT files instead
> of hard-coded config options/function arguments.
>
> I've tested this on my Seaboard and everything works fine,
> including card detect. For the other T20 boards, I've used
> the Linux kernel DTS files for the sdhci nodes where there
> wasn't one already, or expanded the info that was already
> there. Everything builds fine, but I haven't tested anything
> but Seaboard.
With the incremental patch below applied,
Tested-by: Stephen Warren
On: Harmony, Seaboard(really Springbank), Ventana, Whistler,
Paz00/AC100, TrimSlice.
> commit a5be5907d77eb4ca18dd9a11dd09183148c9d1b2
> Author: Stephen Warren
> Date: Thu Feb 14 16:02:24 2013 -0700
>
> Fix MMC DT rework
>
> diff --git a/drivers/mmc/tegra_mmc.c b/drivers/mmc/tegra_mmc.c
> index e8e8512..630f6bd 100644
> --- a/drivers/mmc/tegra_mmc.c
> +++ b/drivers/mmc/tegra_mmc.c
> @@ -497,7 +497,6 @@ static int do_mmc_init(int dev_index)
> struct mmc_host *host;
> char gpusage[12]; /* "SD/MMCn PWR" or "SD/MMCn CD" */
> struct mmc *mmc;
> - int card_det = 0;
>
> /* DT should have been read & host config filled in */
> host = &mmc_host[dev_index];
> @@ -514,16 +513,15 @@ static int do_mmc_init(int dev_index)
> if (fdt_gpio_isvalid(&host->pwr_gpio)) {
> sprintf(gpusage, "SD/MMC%d PWR", dev_index);
> gpio_request(host->pwr_gpio.gpio, gpusage);
> - fdtdec_set_gpio(&host->pwr_gpio, 1);
> + gpio_direction_output(host->pwr_gpio.gpio, 1);
> debug(" Power GPIO name = %s\n", host->pwr_gpio.name);
> }
>
> if (fdt_gpio_isvalid(&host->cd_gpio)) {
> sprintf(gpusage, "SD/MMC%d CD", dev_index);
> gpio_request(host->cd_gpio.gpio, gpusage);
> - card_det = fdtdec_get_gpio(&host->cd_gpio);
> + gpio_direction_input(host->cd_gpio.gpio);
> debug(" CD GPIO name = %s\n", host->cd_gpio.name);
> - debug("%s: CD state = %d\n", __func__, card_det);
> }
>
> mmc = &mmc_dev[dev_index];
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 0/3] Tegra: MMC: Add DT support for MMC to T20 boards
On Thu, Feb 14, 2013 at 08:19:54AM +0100, Thierry Reding wrote: > On Wed, Feb 13, 2013 at 02:44:47PM -0700, Tom Warren wrote: > > This patchset adds device-tree support to the Tegra MMC driver. > > All device config is done via properties in the DT files instead > > of hard-coded config options/function arguments. > > > > I've tested this on my Seaboard and everything works fine, > > including card detect. For the other T20 boards, I've used > > the Linux kernel DTS files for the sdhci nodes where there > > wasn't one already, or expanded the info that was already > > there. Everything builds fine, but I haven't tested anything > > but Seaboard. > > > > v2: Changes as per Stephen's & Simon's review > > v3: Changes as per Stephen/Lucas/Thierry/Simon's feedback > > > > Tom Warren (3): > > Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files > > Tegra: fdt: tamonten: Add common tamonten.dtsi file from linux > > Tegra: MMC: Add DT support to MMC driver for all T20 boards > > > > arch/arm/dts/tegra20.dtsi | 16 +- > > arch/arm/include/asm/arch-tegra/mmc.h |2 +- > > arch/arm/include/asm/arch-tegra/tegra_mmc.h | 13 +- > > board/avionic-design/common/tamonten.c| 19 +- > > board/avionic-design/dts/tegra20-medcom-wide.dts |3 +- > > board/avionic-design/dts/tegra20-plutux.dts |3 +- > > board/avionic-design/dts/tegra20-tamonten.dtsi| 489 > > + > > board/avionic-design/dts/tegra20-tec.dts |3 +- > > board/compal/dts/tegra20-paz00.dts| 19 +- > > board/compal/paz00/paz00.c| 26 +- > > board/compulab/dts/tegra20-trimslice.dts | 14 + > > board/compulab/trimslice/trimslice.c | 25 +- > > board/nvidia/common/board.c | 26 +- > > board/nvidia/dts/tegra20-harmony.dts | 18 + > > board/nvidia/dts/tegra20-seaboard.dts | 10 +- > > board/nvidia/dts/tegra20-ventana.dts | 15 + > > board/nvidia/dts/tegra20-whistler.dts | 13 + > > board/nvidia/harmony/harmony.c| 26 +- > > board/nvidia/seaboard/seaboard.c | 25 +- > > board/nvidia/whistler/whistler.c | 30 +- > > board/toradex/colibri_t20_iris/colibri_t20_iris.c | 11 +- > > board/toradex/dts/tegra20-colibri_t20_iris.dts|7 + > > drivers/mmc/tegra_mmc.c | 259 +++ > > dts/Makefile |2 +- > > include/fdtdec.h |1 + > > lib/fdtdec.c |1 + > > 26 files changed, 815 insertions(+), 261 deletions(-) > > create mode 100644 board/avionic-design/dts/tegra20-tamonten.dtsi > > The series, > > Tested-by: Thierry Reding > > on TEC and Medcom-Wide. I don't currently have access to a Plutux, but > it should be fine too. I managed to talk a co-worker into trying this out on Plutux and there were no issues there either. All Tamonten-boards work fine with these patches applied. Thierry pgpfpQzlVletQ.pgp Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 0/3] Tegra: MMC: Add DT support for MMC to T20 boards
Thanks! On Thu, Feb 14, 2013 at 12:19 AM, Thierry Reding wrote: > On Wed, Feb 13, 2013 at 02:44:47PM -0700, Tom Warren wrote: >> This patchset adds device-tree support to the Tegra MMC driver. >> All device config is done via properties in the DT files instead >> of hard-coded config options/function arguments. >> >> I've tested this on my Seaboard and everything works fine, >> including card detect. For the other T20 boards, I've used >> the Linux kernel DTS files for the sdhci nodes where there >> wasn't one already, or expanded the info that was already >> there. Everything builds fine, but I haven't tested anything >> but Seaboard. >> >> v2: Changes as per Stephen's & Simon's review >> v3: Changes as per Stephen/Lucas/Thierry/Simon's feedback >> >> Tom Warren (3): >> Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files >> Tegra: fdt: tamonten: Add common tamonten.dtsi file from linux >> Tegra: MMC: Add DT support to MMC driver for all T20 boards >> >> arch/arm/dts/tegra20.dtsi | 16 +- >> arch/arm/include/asm/arch-tegra/mmc.h |2 +- >> arch/arm/include/asm/arch-tegra/tegra_mmc.h | 13 +- >> board/avionic-design/common/tamonten.c| 19 +- >> board/avionic-design/dts/tegra20-medcom-wide.dts |3 +- >> board/avionic-design/dts/tegra20-plutux.dts |3 +- >> board/avionic-design/dts/tegra20-tamonten.dtsi| 489 >> + >> board/avionic-design/dts/tegra20-tec.dts |3 +- >> board/compal/dts/tegra20-paz00.dts| 19 +- >> board/compal/paz00/paz00.c| 26 +- >> board/compulab/dts/tegra20-trimslice.dts | 14 + >> board/compulab/trimslice/trimslice.c | 25 +- >> board/nvidia/common/board.c | 26 +- >> board/nvidia/dts/tegra20-harmony.dts | 18 + >> board/nvidia/dts/tegra20-seaboard.dts | 10 +- >> board/nvidia/dts/tegra20-ventana.dts | 15 + >> board/nvidia/dts/tegra20-whistler.dts | 13 + >> board/nvidia/harmony/harmony.c| 26 +- >> board/nvidia/seaboard/seaboard.c | 25 +- >> board/nvidia/whistler/whistler.c | 30 +- >> board/toradex/colibri_t20_iris/colibri_t20_iris.c | 11 +- >> board/toradex/dts/tegra20-colibri_t20_iris.dts|7 + >> drivers/mmc/tegra_mmc.c | 259 +++ >> dts/Makefile |2 +- >> include/fdtdec.h |1 + >> lib/fdtdec.c |1 + >> 26 files changed, 815 insertions(+), 261 deletions(-) >> create mode 100644 board/avionic-design/dts/tegra20-tamonten.dtsi > > The series, > > Tested-by: Thierry Reding > > on TEC and Medcom-Wide. I don't currently have access to a Plutux, but > it should be fine too. > > Thierry ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 0/3] Tegra: MMC: Add DT support for MMC to T20 boards
On Wed, Feb 13, 2013 at 02:44:47PM -0700, Tom Warren wrote: > This patchset adds device-tree support to the Tegra MMC driver. > All device config is done via properties in the DT files instead > of hard-coded config options/function arguments. > > I've tested this on my Seaboard and everything works fine, > including card detect. For the other T20 boards, I've used > the Linux kernel DTS files for the sdhci nodes where there > wasn't one already, or expanded the info that was already > there. Everything builds fine, but I haven't tested anything > but Seaboard. > > v2: Changes as per Stephen's & Simon's review > v3: Changes as per Stephen/Lucas/Thierry/Simon's feedback > > Tom Warren (3): > Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files > Tegra: fdt: tamonten: Add common tamonten.dtsi file from linux > Tegra: MMC: Add DT support to MMC driver for all T20 boards > > arch/arm/dts/tegra20.dtsi | 16 +- > arch/arm/include/asm/arch-tegra/mmc.h |2 +- > arch/arm/include/asm/arch-tegra/tegra_mmc.h | 13 +- > board/avionic-design/common/tamonten.c| 19 +- > board/avionic-design/dts/tegra20-medcom-wide.dts |3 +- > board/avionic-design/dts/tegra20-plutux.dts |3 +- > board/avionic-design/dts/tegra20-tamonten.dtsi| 489 > + > board/avionic-design/dts/tegra20-tec.dts |3 +- > board/compal/dts/tegra20-paz00.dts| 19 +- > board/compal/paz00/paz00.c| 26 +- > board/compulab/dts/tegra20-trimslice.dts | 14 + > board/compulab/trimslice/trimslice.c | 25 +- > board/nvidia/common/board.c | 26 +- > board/nvidia/dts/tegra20-harmony.dts | 18 + > board/nvidia/dts/tegra20-seaboard.dts | 10 +- > board/nvidia/dts/tegra20-ventana.dts | 15 + > board/nvidia/dts/tegra20-whistler.dts | 13 + > board/nvidia/harmony/harmony.c| 26 +- > board/nvidia/seaboard/seaboard.c | 25 +- > board/nvidia/whistler/whistler.c | 30 +- > board/toradex/colibri_t20_iris/colibri_t20_iris.c | 11 +- > board/toradex/dts/tegra20-colibri_t20_iris.dts|7 + > drivers/mmc/tegra_mmc.c | 259 +++ > dts/Makefile |2 +- > include/fdtdec.h |1 + > lib/fdtdec.c |1 + > 26 files changed, 815 insertions(+), 261 deletions(-) > create mode 100644 board/avionic-design/dts/tegra20-tamonten.dtsi The series, Tested-by: Thierry Reding on TEC and Medcom-Wide. I don't currently have access to a Plutux, but it should be fine too. Thierry pgpBKLfSL7YWS.pgp Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3 0/3] Tegra: MMC: Add DT support for MMC to T20 boards
This patchset adds device-tree support to the Tegra MMC driver. All device config is done via properties in the DT files instead of hard-coded config options/function arguments. I've tested this on my Seaboard and everything works fine, including card detect. For the other T20 boards, I've used the Linux kernel DTS files for the sdhci nodes where there wasn't one already, or expanded the info that was already there. Everything builds fine, but I haven't tested anything but Seaboard. v2: Changes as per Stephen's & Simon's review v3: Changes as per Stephen/Lucas/Thierry/Simon's feedback Tom Warren (3): Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files Tegra: fdt: tamonten: Add common tamonten.dtsi file from linux Tegra: MMC: Add DT support to MMC driver for all T20 boards arch/arm/dts/tegra20.dtsi | 16 +- arch/arm/include/asm/arch-tegra/mmc.h |2 +- arch/arm/include/asm/arch-tegra/tegra_mmc.h | 13 +- board/avionic-design/common/tamonten.c| 19 +- board/avionic-design/dts/tegra20-medcom-wide.dts |3 +- board/avionic-design/dts/tegra20-plutux.dts |3 +- board/avionic-design/dts/tegra20-tamonten.dtsi| 489 + board/avionic-design/dts/tegra20-tec.dts |3 +- board/compal/dts/tegra20-paz00.dts| 19 +- board/compal/paz00/paz00.c| 26 +- board/compulab/dts/tegra20-trimslice.dts | 14 + board/compulab/trimslice/trimslice.c | 25 +- board/nvidia/common/board.c | 26 +- board/nvidia/dts/tegra20-harmony.dts | 18 + board/nvidia/dts/tegra20-seaboard.dts | 10 +- board/nvidia/dts/tegra20-ventana.dts | 15 + board/nvidia/dts/tegra20-whistler.dts | 13 + board/nvidia/harmony/harmony.c| 26 +- board/nvidia/seaboard/seaboard.c | 25 +- board/nvidia/whistler/whistler.c | 30 +- board/toradex/colibri_t20_iris/colibri_t20_iris.c | 11 +- board/toradex/dts/tegra20-colibri_t20_iris.dts|7 + drivers/mmc/tegra_mmc.c | 259 +++ dts/Makefile |2 +- include/fdtdec.h |1 + lib/fdtdec.c |1 + 26 files changed, 815 insertions(+), 261 deletions(-) create mode 100644 board/avionic-design/dts/tegra20-tamonten.dtsi ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
