Re: [U-Boot] [PATCH v3 01/22] net: FEC: Add compatible for vybrid (vf610) to reuse fec_mxc.c driver

2019-02-11 Thread Lukasz Majewski
Hi Marcel,

> Hi Lukasz
> 
> On Sun, 2019-02-03 at 00:02 +0100, Lukasz Majewski wrote:
> > The NXP's FEC driver can be reused on vf610 device (with DM).
> > 
> > Signed-off-by: Lukasz Majewski 
> > Reviewed-by: Stefan Agner 
> > ---
> > 
> > Changes in v3: None
> > Changes in v2: None
> > 
> >  drivers/net/fec_mxc.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> > index 1a59026a62..5ff49224f4 100644
> > --- a/drivers/net/fec_mxc.c
> > +++ b/drivers/net/fec_mxc.c
> > @@ -1486,6 +1486,7 @@ static const struct udevice_id fecmxc_ids[] =
> > { { .compatible = "fsl,imx6ul-fec" },
> > { .compatible = "fsl,imx53-fec" },
> > { .compatible = "fsl,imx7d-fec" },
> > +   { .compatible = "fsl,mvf600-fec" },
> > { }
> >  };  
> 
> For some reason while the FEC prior to DM was rock solid on Vybrid
> with DM it at times only sends stuff but refuses to receive packets.
> Do you recall having any such issues? Could it have to do with us
> using FEC1 by default rather than FEC0? But then at times it works
> just fine again which is rather strange...

I had also some problems when I switched to DM (but for other NXP
IMX6Q based board - mccmon6). It turned out that the time between probe
in the driver and first read of MDIO was just as in spec (or too short).

As a result the PHY was sometimes in uninitialized state, and silently
read 0x as ID, which prevent us from normal work.

The fix in this case was to increase the delay between powering up PHY
and exiting the ETH driver probe:
http://patchwork.ozlabs.org/patch/1034050/


Please check if this patch (from this series):
"pcm052: bk4: Add board_phy_config() for BK4 to setup ksz8081 phy"

is not solving your problem.

> 
> Cheers
> 
> Marcel




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de


pgpYu1ZcJxyq_.pgp
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH v3 01/22] net: FEC: Add compatible for vybrid (vf610) to reuse fec_mxc.c driver

2019-02-11 Thread Marcel Ziswiler
Hi Lukasz

On Sun, 2019-02-03 at 00:02 +0100, Lukasz Majewski wrote:
> The NXP's FEC driver can be reused on vf610 device (with DM).
> 
> Signed-off-by: Lukasz Majewski 
> Reviewed-by: Stefan Agner 
> ---
> 
> Changes in v3: None
> Changes in v2: None
> 
>  drivers/net/fec_mxc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index 1a59026a62..5ff49224f4 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -1486,6 +1486,7 @@ static const struct udevice_id fecmxc_ids[] = {
>   { .compatible = "fsl,imx6ul-fec" },
>   { .compatible = "fsl,imx53-fec" },
>   { .compatible = "fsl,imx7d-fec" },
> + { .compatible = "fsl,mvf600-fec" },
>   { }
>  };

For some reason while the FEC prior to DM was rock solid on Vybrid with
DM it at times only sends stuff but refuses to receive packets. Do you
recall having any such issues? Could it have to do with us using FEC1
by default rather than FEC0? But then at times it works just fine again
which is rather strange...

Cheers

Marcel
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH v3 01/22] net: FEC: Add compatible for vybrid (vf610) to reuse fec_mxc.c driver

2019-02-02 Thread Lukasz Majewski
The NXP's FEC driver can be reused on vf610 device (with DM).

Signed-off-by: Lukasz Majewski 
Reviewed-by: Stefan Agner 
---

Changes in v3: None
Changes in v2: None

 drivers/net/fec_mxc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index 1a59026a62..5ff49224f4 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -1486,6 +1486,7 @@ static const struct udevice_id fecmxc_ids[] = {
{ .compatible = "fsl,imx6ul-fec" },
{ .compatible = "fsl,imx53-fec" },
{ .compatible = "fsl,imx7d-fec" },
+   { .compatible = "fsl,mvf600-fec" },
{ }
 };
 
-- 
2.11.0

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot