Re: [U-Boot] [PATCH v3 03/16] efi_selftest: do not try to close device path protocol

2018-01-16 Thread Simon Glass
On 10 January 2018 at 23:15, Heinrich Schuchardt  wrote:
> CloseProtocol cannot be called without agent handle.
>
> There is no need to close the device path protocol if
> it has been opened without agent handle.
>
> Signed-off-by: Heinrich Schuchardt 
> ---
> v3
> no change
> v2
> no change
> ---
>  lib/efi_selftest/efi_selftest_devicepath.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


[U-Boot] [PATCH v3 03/16] efi_selftest: do not try to close device path protocol

2018-01-10 Thread Heinrich Schuchardt
CloseProtocol cannot be called without agent handle.

There is no need to close the device path protocol if
it has been opened without agent handle.

Signed-off-by: Heinrich Schuchardt 
---
v3
no change
v2
no change
---
 lib/efi_selftest/efi_selftest_devicepath.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/efi_selftest/efi_selftest_devicepath.c 
b/lib/efi_selftest/efi_selftest_devicepath.c
index 1ab54ebb37..d9a6697892 100644
--- a/lib/efi_selftest/efi_selftest_devicepath.c
+++ b/lib/efi_selftest/efi_selftest_devicepath.c
@@ -299,10 +299,10 @@ static int execute(void)
efi_st_error("FreePool failed\n");
return EFI_ST_FAILURE;
}
-   ret = boottime->close_protocol(handles[i], _device_path,
-  NULL, NULL);
-   if (ret != EFI_SUCCESS)
-   efi_st_todo("Cannot close device path protocol.\n");
+   /*
+* CloseProtocol cannot be called without agent handle.
+* There is no need to close the device path protocol.
+*/
}
ret = boottime->free_pool(handles);
if (ret != EFI_SUCCESS) {
-- 
2.14.2

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot