Re: [U-Boot] [PATCH v3 05/29] dm: Make sure that the root device is probed

2014-07-26 Thread Simon Glass
On 23 July 2014 13:55, Simon Glass  wrote:
> The root device should be probed just like any other device. The effect of
> this is to mark the device as activated, so that it can be removed (along
> with its children) if required.
>
> Signed-off-by: Simon Glass 
> Acked-by: Marek Vasut 

Applied to dm/master.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


[U-Boot] [PATCH v3 05/29] dm: Make sure that the root device is probed

2014-07-23 Thread Simon Glass
The root device should be probed just like any other device. The effect of
this is to mark the device as activated, so that it can be removed (along
with its children) if required.

Signed-off-by: Simon Glass 
Acked-by: Marek Vasut 
---

Changes in v3: None
Changes in v2: None

 drivers/core/root.c | 3 +++
 test/dm/core.c  | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/core/root.c b/drivers/core/root.c
index 1cbb096..bc76370 100644
--- a/drivers/core/root.c
+++ b/drivers/core/root.c
@@ -48,6 +48,9 @@ int dm_init(void)
ret = device_bind_by_name(NULL, &root_info, &DM_ROOT_NON_CONST);
if (ret)
return ret;
+   ret = device_probe(DM_ROOT_NON_CONST);
+   if (ret)
+   return ret;
 
return 0;
 }
diff --git a/test/dm/core.c b/test/dm/core.c
index be3646b..8c18780 100644
--- a/test/dm/core.c
+++ b/test/dm/core.c
@@ -106,7 +106,7 @@ static int dm_test_autoprobe(struct dm_test_state *dms)
ut_asserteq(0, dm_testdrv_op_count[DM_TEST_OP_POST_PROBE]);
 
/* The root device should not be activated until needed */
-   ut_assert(!(dms->root->flags & DM_FLAG_ACTIVATED));
+   ut_assert(dms->root->flags & DM_FLAG_ACTIVATED);
 
/*
 * We should be able to find the three test devices, and they should
-- 
2.0.0.526.g5318336

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot