Re: [U-Boot] [PATCH v3 1/3] i2c: fix init on generic board

[Simon Glass]

Hi Philippe,

On Thu, Sep 19, 2013 at 12:41 PM, Philippe Reynes trem...@yahoo.fr wrote:


 Signed-off-by: Philippe Reynes trem...@yahoo.fr


It looks good, but please can we have an explanation in the commit message?



 ---
  common/board_f.c |4 
  1 files changed, 4 insertions(+), 0 deletions(-)

 diff --git a/common/board_f.c b/common/board_f.c
 index 0ada1af..f0664bc 100644
 --- a/common/board_f.c
 +++ b/common/board_f.c
 @@ -249,7 +249,11 @@ void dram_init_banksize(void)
  static int init_func_i2c(void)
  {
 puts(I2C:   );
 +#ifdef CONFIG_SYS_I2C
 +   i2c_init_all();
 +#else
 i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
 +#endif
 puts(ready\n);
 return 0;
  }
 --
 1.7.4.4

 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot


Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v3 1/3] i2c: fix init on generic board

[Philippe Reynes]

Signed-off-by: Philippe Reynes trem...@yahoo.fr
---
 common/board_f.c |4 
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/common/board_f.c b/common/board_f.c
index 0ada1af..f0664bc 100644
--- a/common/board_f.c
+++ b/common/board_f.c
@@ -249,7 +249,11 @@ void dram_init_banksize(void)
 static int init_func_i2c(void)
 {
puts(I2C:   );
+#ifdef CONFIG_SYS_I2C
+   i2c_init_all();
+#else
i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE);
+#endif
puts(ready\n);
return 0;
 }
-- 
1.7.4.4

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot