Re: [U-Boot] [PATCH v3 11/28] arm: Use sections header to obtain link symbols
Hi Mike, On Sat, Mar 10, 2012 at 5:54 PM, Mike Frysinger wrote: > On Thursday 08 March 2012 01:39:53 Simon Glass wrote: >> On Tue, Mar 6, 2012 at 8:17 AM, Mike Frysinger wrote: >> > On Tuesday 06 March 2012 01:24:21 Simon Glass wrote: >> >> On Mon, Mar 5, 2012 at 9:03 PM, Mike Frysinger wrote: >> >> > On Thursday 16 February 2012 09:48:58 Simon Glass wrote: >> >> >> --- a/board/cm4008/flash.c >> >> >> +++ b/board/cm4008/flash.c >> >> >> >> >> >> #include >> >> >> +#include >> >> > >> >> > arches should provide asm/sections.h, and those are the only headers >> >> > that should know about asm-generic/sections.h >> >> >> >> Similar to my previous comment, but why does each arch have to have >> >> subtly-different section symbol names? From what I have seen so far >> >> there can be unified also. >> > >> > Blackfin has linker symbols that don't belong in any other port. this is >> > also how the kernel does it, and i don't see value in diverging here. >> >> OK, so I think I should update the sections.h patch to add >> asm/sections.h for every arch, initially just with an include to >> asm-generic/sections.h in each one? Does that sound right? > > yep. unless we want to get really ambitious and extend the generated support > like the kernel has now -- it automatically generates sub headers for asm/ > redirects to asm-generic/ if the arch hasn't provided one. I am ambitious enough already :-) I have added these files into the v4 version of the patch. Regards, Simon > -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 11/28] arm: Use sections header to obtain link symbols
On Thursday 08 March 2012 01:39:53 Simon Glass wrote: > On Tue, Mar 6, 2012 at 8:17 AM, Mike Frysinger wrote: > > On Tuesday 06 March 2012 01:24:21 Simon Glass wrote: > >> On Mon, Mar 5, 2012 at 9:03 PM, Mike Frysinger wrote: > >> > On Thursday 16 February 2012 09:48:58 Simon Glass wrote: > >> >> --- a/board/cm4008/flash.c > >> >> +++ b/board/cm4008/flash.c > >> >> > >> >> #include > >> >> +#include > >> > > >> > arches should provide asm/sections.h, and those are the only headers > >> > that should know about asm-generic/sections.h > >> > >> Similar to my previous comment, but why does each arch have to have > >> subtly-different section symbol names? From what I have seen so far > >> there can be unified also. > > > > Blackfin has linker symbols that don't belong in any other port. this is > > also how the kernel does it, and i don't see value in diverging here. > > OK, so I think I should update the sections.h patch to add > asm/sections.h for every arch, initially just with an include to > asm-generic/sections.h in each one? Does that sound right? yep. unless we want to get really ambitious and extend the generated support like the kernel has now -- it automatically generates sub headers for asm/ redirects to asm-generic/ if the arch hasn't provided one. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 11/28] arm: Use sections header to obtain link symbols
Hi Mike, On Tue, Mar 6, 2012 at 8:17 AM, Mike Frysinger wrote: > On Tuesday 06 March 2012 01:24:21 Simon Glass wrote: >> On Mon, Mar 5, 2012 at 9:03 PM, Mike Frysinger wrote: >> > On Thursday 16 February 2012 09:48:58 Simon Glass wrote: >> >> --- a/board/cm4008/flash.c >> >> +++ b/board/cm4008/flash.c >> >> >> >> #include >> >> +#include >> > >> > arches should provide asm/sections.h, and those are the only headers that >> > should know about asm-generic/sections.h >> >> Similar to my previous comment, but why does each arch have to have >> subtly-different section symbol names? From what I have seen so far >> there can be unified also. > > Blackfin has linker symbols that don't belong in any other port. this is also > how the kernel does it, and i don't see value in diverging here. OK, so I think I should update the sections.h patch to add asm/sections.h for every arch, initially just with an include to asm-generic/sections.h in each one? Does that sound right? Regards, Simon > -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 11/28] arm: Use sections header to obtain link symbols
On Tuesday 06 March 2012 01:24:21 Simon Glass wrote: > On Mon, Mar 5, 2012 at 9:03 PM, Mike Frysinger wrote: > > On Thursday 16 February 2012 09:48:58 Simon Glass wrote: > >> --- a/board/cm4008/flash.c > >> +++ b/board/cm4008/flash.c > >> > >> #include > >> +#include > > > > arches should provide asm/sections.h, and those are the only headers that > > should know about asm-generic/sections.h > > Similar to my previous comment, but why does each arch have to have > subtly-different section symbol names? From what I have seen so far > there can be unified also. Blackfin has linker symbols that don't belong in any other port. this is also how the kernel does it, and i don't see value in diverging here. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 11/28] arm: Use sections header to obtain link symbols
Hi Mike, On Mon, Mar 5, 2012 at 9:03 PM, Mike Frysinger wrote: > On Thursday 16 February 2012 09:48:58 Simon Glass wrote: >> --- a/board/cm4008/flash.c >> +++ b/board/cm4008/flash.c >> >> #include >> +#include > > arches should provide asm/sections.h, and those are the only headers that > should know about asm-generic/sections.h Similar to my previous comment, but why does each arch have to have subtly-different section symbol names? From what I have seen so far there can be unified also. Regards, Simon > -mike ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 11/28] arm: Use sections header to obtain link symbols
On Thursday 16 February 2012 09:48:58 Simon Glass wrote: > --- a/board/cm4008/flash.c > +++ b/board/cm4008/flash.c > > #include > +#include arches should provide asm/sections.h, and those are the only headers that should know about asm-generic/sections.h -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3 11/28] arm: Use sections header to obtain link symbols
Include this header to get access to link symbols, which are otherwise removed. Signed-off-by: Simon Glass --- arch/arm/include/asm/u-boot-arm.h |4 arch/arm/lib/board.c |1 + board/cm4008/flash.c |1 + board/cm41xx/flash.c |1 + 4 files changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm/include/asm/u-boot-arm.h b/arch/arm/include/asm/u-boot-arm.h index 4ca75f9..7cfae9b 100644 --- a/arch/arm/include/asm/u-boot-arm.h +++ b/arch/arm/include/asm/u-boot-arm.h @@ -30,12 +30,8 @@ #define _U_BOOT_ARM_H_ 1 /* for the following variables, see start.S */ -extern ulong _bss_start_ofs; /* BSS start relative to _start */ -extern ulong _bss_end_ofs; /* BSS end relative to _start */ -extern ulong _end_ofs; /* end of image relative to _start */ extern ulong IRQ_STACK_START; /* top of IRQ stack */ extern ulong FIQ_STACK_START; /* top of FIQ stack */ -extern ulong _TEXT_BASE; /* code start */ extern ulong _datarel_start_ofs; extern ulong _datarelrolocal_start_ofs; extern ulong _datarellocal_start_ofs; diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index 500e216..abfbb2b 100644 --- a/arch/arm/lib/board.c +++ b/arch/arm/lib/board.c @@ -39,6 +39,7 @@ */ #include +#include #include #include #include diff --git a/board/cm4008/flash.c b/board/cm4008/flash.c index 5522bf0..641d46f 100644 --- a/board/cm4008/flash.c +++ b/board/cm4008/flash.c @@ -28,6 +28,7 @@ */ #include +#include #include diff --git a/board/cm41xx/flash.c b/board/cm41xx/flash.c index 5522bf0..641d46f 100644 --- a/board/cm41xx/flash.c +++ b/board/cm41xx/flash.c @@ -28,6 +28,7 @@ */ #include +#include #include -- 1.7.7.3 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
