Re: [U-Boot] [PATCH v3 2/8] video: squash lines for immediate return

[Stephen Warren]

On 09/06/2016 07:17 AM, Masahiro Yamada wrote:

For vidconsole_post_probe(), it is common coding style to let a
probe method return the value of a register function.

The others will become simple wrapper functions.


drivers/video/tegra124/display.c:
Acked-by: Stephen Warren 

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 2/8] video: squash lines for immediate return

[Simon Glass]

On 6 September 2016 at 07:17, Masahiro Yamada
 wrote:
> For vidconsole_post_probe(), it is common coding style to let a
> probe method return the value of a register function.
>
> The others will become simple wrapper functions.
>
> Signed-off-by: Masahiro Yamada 
> Acked-by: Anatolij Gustschin 
> ---
>
> Changes in v3:
>   - Two more fixes
>   - s/resister/register/
>
>  drivers/video/bridge/ptn3460.c| 7 +--
>  drivers/video/broadwell_igd.c | 5 +
>  drivers/video/exynos/exynos_dp_lowlevel.c | 6 +-
>  drivers/video/tegra124/display.c  | 8 +---
>  drivers/video/vidconsole-uclass.c | 6 +-
>  5 files changed, 5 insertions(+), 27 deletions(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v3 2/8] video: squash lines for immediate return

[Masahiro Yamada]

For vidconsole_post_probe(), it is common coding style to let a
probe method return the value of a register function.

The others will become simple wrapper functions.

Signed-off-by: Masahiro Yamada 
Acked-by: Anatolij Gustschin 
---

Changes in v3:
  - Two more fixes
  - s/resister/register/

 drivers/video/bridge/ptn3460.c| 7 +--
 drivers/video/broadwell_igd.c | 5 +
 drivers/video/exynos/exynos_dp_lowlevel.c | 6 +-
 drivers/video/tegra124/display.c  | 8 +---
 drivers/video/vidconsole-uclass.c | 6 +-
 5 files changed, 5 insertions(+), 27 deletions(-)

diff --git a/drivers/video/bridge/ptn3460.c b/drivers/video/bridge/ptn3460.c
index 2e2ae7c..f9d3720 100644
--- a/drivers/video/bridge/ptn3460.c
+++ b/drivers/video/bridge/ptn3460.c
@@ -11,14 +11,9 @@
 
 static int ptn3460_attach(struct udevice *dev)
 {
-   int ret;
-
debug("%s: %s\n", __func__, dev->name);
-   ret = video_bridge_set_active(dev, true);
-   if (ret)
-   return ret;
 
-   return 0;
+   return video_bridge_set_active(dev, true);
 }
 
 struct video_bridge_ops ptn3460_ops = {
diff --git a/drivers/video/broadwell_igd.c b/drivers/video/broadwell_igd.c
index ce4f296..4286fd0 100644
--- a/drivers/video/broadwell_igd.c
+++ b/drivers/video/broadwell_igd.c
@@ -323,10 +323,7 @@ err:
 static unsigned long gtt_read(struct broadwell_igd_priv *priv,
  unsigned long reg)
 {
-   u32 val;
-
-   val = readl(priv->regs + reg);
-   return val;
+   return readl(priv->regs + reg);
 }
 
 static void gtt_write(struct broadwell_igd_priv *priv, unsigned long reg,
diff --git a/drivers/video/exynos/exynos_dp_lowlevel.c 
b/drivers/video/exynos/exynos_dp_lowlevel.c
index f978473..aae78a8 100644
--- a/drivers/video/exynos/exynos_dp_lowlevel.c
+++ b/drivers/video/exynos/exynos_dp_lowlevel.c
@@ -881,11 +881,7 @@ void exynos_dp_set_lane_count(struct exynos_dp *dp_regs, 
unsigned char count)
 
 unsigned int exynos_dp_get_lane_count(struct exynos_dp *dp_regs)
 {
-   unsigned int reg;
-
-   reg = readl(_regs->lane_count_set);
-
-   return reg;
+   return readl(_regs->lane_count_set);
 }
 
 unsigned char exynos_dp_get_lanex_pre_emphasis(struct exynos_dp *dp_regs,
diff --git a/drivers/video/tegra124/display.c b/drivers/video/tegra124/display.c
index 2f1f0df..d8999c3 100644
--- a/drivers/video/tegra124/display.c
+++ b/drivers/video/tegra124/display.c
@@ -326,13 +326,7 @@ static int display_update_config_from_edid(struct udevice 
*dp_dev,
   int *panel_bppp,
   struct display_timing *timing)
 {
-   int ret;
-
-   ret = display_read_timing(dp_dev, timing);
-   if (ret)
-   return ret;
-
-   return 0;
+   return display_read_timing(dp_dev, timing);
 }
 
 static int display_init(struct udevice *dev, void *lcdbase,
diff --git a/drivers/video/vidconsole-uclass.c 
b/drivers/video/vidconsole-uclass.c
index c8cc05e..e9a90b1 100644
--- a/drivers/video/vidconsole-uclass.c
+++ b/drivers/video/vidconsole-uclass.c
@@ -190,7 +190,6 @@ static int vidconsole_post_probe(struct udevice *dev)
 {
struct vidconsole_priv *priv = dev_get_uclass_priv(dev);
struct stdio_dev *sdev = >sdev;
-   int ret;
 
if (!priv->tab_width_frac)
priv->tab_width_frac = VID_TO_POS(priv->x_charsize) * 8;
@@ -206,11 +205,8 @@ static int vidconsole_post_probe(struct udevice *dev)
sdev->putc = vidconsole_putc;
sdev->puts = vidconsole_puts;
sdev->priv = dev;
-   ret = stdio_register(sdev);
-   if (ret)
-   return ret;
 
-   return 0;
+   return stdio_register(sdev);
 }
 
 UCLASS_DRIVER(vidconsole) = {
-- 
1.9.1

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot